)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b9c99401207a925135a3d28ecc15122ca1b6968b","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b6b74807_0997d910","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"updated":"2021-04-23 09:16:16.000000000","message":"This is actually from https://review.opendev.org/c/openstack/neutron/+/726424 it should be backported separately","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"780d70eff19608300e2a1a22c38c6f8a45b80dd9","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b030d71e_b091aebc","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"in_reply_to":"8e5934ae_edbef809","updated":"2021-05-01 06:03:00.000000000","message":"Maybe You can update commit message to mention that there and we should be good to go then IMO. Wdyt Bernard?","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"5dd0582885893855be2b092d7097b83ac4c62fb1","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fe55b0f3_be3a9437","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"in_reply_to":"b030d71e_b091aebc","updated":"2021-05-03 09:23:03.000000000","message":"That could be an option yes though in fact we have most of that other patch in, here L1095 is not needed anymore as it will return the same db_network right? So, the only missing line will be that session expire from L1098. If it is OK to backport too (including to train), then we can backport both clean patches - if not see if we can drop L1095 and mention this difference in commit message\n\nAdding Rodolfo for the review, I guess you will know best here 😊","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"46e3600d74ad9143a7a5e063c389454b16177990","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8e5934ae_edbef809","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"in_reply_to":"b6b74807_0997d910","updated":"2021-04-23 09:55:24.000000000","message":"You got me :D but I wasn\u0027t sure that new DB engine facade migration was in a state allowing https://review.opendev.org/c/openstack/neutron/+/726424 backport to stable/ussuri. I thought this small refactor won\u0027t hurt here..","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4ca12e2e65643bd06fa32f27b385ecf9c03975f5","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8aed4c79_20379f8c","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"in_reply_to":"dbbe1971_c9023240","updated":"2021-05-05 09:52:17.000000000","message":"Patch: https://review.opendev.org/c/openstack/neutron/+/789771","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cf2fb4c6045a706870a3b2e2440e1a5c54c81b6b","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        need_network_update_notify \u003d False"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":1083,"context_line":"            db_network \u003d self._get_network(context, id)"},{"line_number":1084,"context_line":"            original_network \u003d self.get_network(context, id, net_db\u003ddb_network)"},{"line_number":1085,"context_line":"            self._update_provider_network_attributes("},{"line_number":1086,"context_line":"                context, original_network, net_data)"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dbbe1971_c9023240","line":1084,"range":{"start_line":1083,"start_character":0,"end_line":1084,"end_character":79},"in_reply_to":"fe55b0f3_be3a9437","updated":"2021-05-05 09:49:34.000000000","message":"Let\u0027s keep the git tree correctly documented. I\u0027ll push backport for 726424 into T and U.","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b9c99401207a925135a3d28ecc15122ca1b6968b","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"        return updated_network"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":1141,"context_line":"    def get_network(self, context, id, fields\u003dNone, net_db\u003dNone):"},{"line_number":1142,"context_line":"        with db_api.CONTEXT_READER.using(context):"},{"line_number":1143,"context_line":"            net_db \u003d net_db or self._get_network(context, id)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"            net_data \u003d self._make_network_dict(net_db, context\u003dcontext)"},{"line_number":1146,"context_line":"            self.type_manager.extend_network_dict_provider(context, net_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5200d1ae_07caad88","line":1143,"range":{"start_line":1141,"start_character":0,"end_line":1143,"end_character":61},"updated":"2021-04-23 09:16:16.000000000","message":"Same","commit_id":"886a9c7c1d90570012de17be5b15c9952436eba5"}]}