)]}'
{"lower-constraints.txt":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e8a615dc84287e08645208cfa8fe961913b4210f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"munch\u003d\u003d2.1.0"},{"line_number":51,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":52,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":53,"context_line":"neutron-lib\u003d\u003d2.11.0"},{"line_number":54,"context_line":"openstacksdk\u003d\u003d0.31.2"},{"line_number":55,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":56,"context_line":"os-ken\u003d\u003d0.3.0"}],"source_content_type":"text/plain","patch_set":5,"id":"1d99b042_25bad725","line":53,"updated":"2021-04-28 13:51:20.000000000","message":"I proposed that bump in https://review.opendev.org/c/openstack/neutron/+/788071","commit_id":"9911d414c6a03cbdcc5f46a9ed7cfc59d70a5168"}],"neutron/objects/base.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a43c2219f3f760106d13b7240debb8ff4032d9b9","unresolved":true,"context_lines":[{"line_number":920,"context_line":"        )"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    @classmethod"},{"line_number":923,"context_line":"    def objects_exist(cls, context, validate_filters\u003dTrue, query_field\u003dNone,"},{"line_number":924,"context_line":"                      **kwargs):"},{"line_number":925,"context_line":"        \"\"\"Check if objects are present in DB."},{"line_number":926,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"88a5e72b_dbed7a8b","line":923,"range":{"start_line":923,"start_character":59,"end_line":923,"end_character":75},"updated":"2021-04-23 08:21:37.000000000","message":"please add description in docstring below","commit_id":"aa6a9ef48c89334d4e4646535df8ecf319414f54"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"038a41e58316ca136a49aa085124e5fe89be89ec","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        )"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    @classmethod"},{"line_number":923,"context_line":"    def objects_exist(cls, context, validate_filters\u003dTrue, query_field\u003dNone,"},{"line_number":924,"context_line":"                      **kwargs):"},{"line_number":925,"context_line":"        \"\"\"Check if objects are present in DB."},{"line_number":926,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a1297f35_4733f649","line":923,"range":{"start_line":923,"start_character":59,"end_line":923,"end_character":75},"in_reply_to":"88a5e72b_dbed7a8b","updated":"2021-04-23 08:31:30.000000000","message":"Done","commit_id":"aa6a9ef48c89334d4e4646535df8ecf319414f54"}],"neutron/objects/db/api.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a43c2219f3f760106d13b7240debb8ff4032d9b9","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def count(obj_cls, context, query_field\u003dNone, query_limit\u003dNone, **kwargs):"},{"line_number":38,"context_line":"    return _get_filter_query(obj_cls, context, query_field\u003dquery_field,"},{"line_number":39,"context_line":"                             query_limit\u003dquery_limit, **kwargs).count()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d11fc55d_e937a959","line":38,"range":{"start_line":38,"start_character":59,"end_line":38,"end_character":70},"updated":"2021-04-23 08:21:37.000000000","message":"is it ok to just get random(first) column name from obj_cls.db_model? Thus all callers won\u0027t need to specify additional parameter","commit_id":"aa6a9ef48c89334d4e4646535df8ecf319414f54"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"038a41e58316ca136a49aa085124e5fe89be89ec","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def count(obj_cls, context, query_field\u003dNone, query_limit\u003dNone, **kwargs):"},{"line_number":38,"context_line":"    return _get_filter_query(obj_cls, context, query_field\u003dquery_field,"},{"line_number":39,"context_line":"                             query_limit\u003dquery_limit, **kwargs).count()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fb04a03c_cbc52ad2","line":38,"range":{"start_line":38,"start_character":59,"end_line":38,"end_character":70},"in_reply_to":"d11fc55d_e937a959","updated":"2021-04-23 08:31:30.000000000","message":"No, they won\u0027t, this is why the default value is None. By default, the behaviour of this method will be the same if no \"query_field\" is provided.","commit_id":"aa6a9ef48c89334d4e4646535df8ecf319414f54"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"550e90f5c87591909ff09e6fc3cd4d369d2ccc13","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def count(obj_cls, context, query_field\u003dNone, query_limit\u003dNone, **kwargs):"},{"line_number":38,"context_line":"    return _get_filter_query(obj_cls, context, query_field\u003dquery_field,"},{"line_number":39,"context_line":"                             query_limit\u003dquery_limit, **kwargs).count()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"81c30cf8_08dda441","line":38,"range":{"start_line":38,"start_character":59,"end_line":38,"end_character":70},"in_reply_to":"fb04a03c_cbc52ad2","updated":"2021-04-23 08:37:41.000000000","message":"Sorry, I didn\u0027t understand: if we only need 1 register to get count, why not get first register  from db model? I meant remove query_field parameter from count() at all","commit_id":"aa6a9ef48c89334d4e4646535df8ecf319414f54"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"58c5801fd855edb58ba68e064819aedfeeebe50b","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def count(obj_cls, context, query_field\u003dNone, query_limit\u003dNone, **kwargs):"},{"line_number":38,"context_line":"    return _get_filter_query(obj_cls, context, query_field\u003dquery_field,"},{"line_number":39,"context_line":"                             query_limit\u003dquery_limit, **kwargs).count()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f4f341a8_a57655fe","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":70},"updated":"2021-04-23 11:19:37.000000000","message":"query_field\u003dobj_cls.primary_keys[0]","commit_id":"201cad83f7b94a224704e166626f5de4addf54dc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5528edf01cfe75171001698b86ed1fe19e7b68e8","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def count(obj_cls, context, query_field\u003dNone, query_limit\u003dNone, **kwargs):"},{"line_number":38,"context_line":"    return _get_filter_query(obj_cls, context, query_field\u003dquery_field,"},{"line_number":39,"context_line":"                             query_limit\u003dquery_limit, **kwargs).count()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b688e00a_5d7b22d7","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":70},"in_reply_to":"f4f341a8_a57655fe","updated":"2021-04-23 13:22:37.000000000","message":"Yes, that could improve, in one shoot, all \"count\" calls if not \"query_limit\" is passed. This will improve not only the NeutronDbObject.objects_exits call but all methods calling directly to count.\n\nFurthermore, we don\u0027t need to modify the \"objects_exits\" calls in the code.","commit_id":"201cad83f7b94a224704e166626f5de4addf54dc"}]}