)]}'
{"neutron/plugins/bigswitch/servermanager.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"a4c1fc6e2f235a6c1840e5a623011d25cd7de6ee","unresolved":false,"context_lines":[{"line_number":71,"context_line":"HASH_MATCH_HEADER \u003d \u0027X-BSN-BVS-HASH-MATCH\u0027"},{"line_number":72,"context_line":"# error messages"},{"line_number":73,"context_line":"NXNETWORK \u003d \u0027NXVNS\u0027"},{"line_number":74,"context_line":"# NOTE(kevinbenton): This following is to give mock a target that doesn\u0027t"},{"line_number":75,"context_line":"# affect other users of httplib.HTTPConnection"},{"line_number":76,"context_line":"HTTPConnection \u003d httplib.HTTPConnection"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWH%2F9VkY%3D","line":74,"updated":"2014-04-06 17:40:46.000000000","message":"The following","commit_id":"f64eacfd27220c180f6afc979087b35aa1385550"}],"neutron/tests/unit/bigswitch/test_capabilities.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f851296ccd4af391105c8105c95552ad06717701","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # perform a task to cause capabilities to be retrieved"},{"line_number":74,"context_line":"        with self.floatingip_with_assoc():"},{"line_number":75,"context_line":"            pass"},{"line_number":76,"context_line":"        rcall_p.stop()"},{"line_number":77,"context_line":"        # now mock HTTP class instead of rest so we can see headers"},{"line_number":78,"context_line":"        reqmock \u003d mock.MagicMock()"},{"line_number":79,"context_line":"        respmock \u003d mock.MagicMock().return_value"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9fGc%3D","line":76,"updated":"2014-04-04 07:36:09.000000000","message":"L.69-76 can be written:\n\n  with mock.patch(SERVERRESTCALL, ....):\n      with self.floatingip_with_assoc():\n          pass","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cba1a7aec96c57b587bbc96f01cc71384348eab0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # perform a task to cause capabilities to be retrieved"},{"line_number":74,"context_line":"        with self.floatingip_with_assoc():"},{"line_number":75,"context_line":"            pass"},{"line_number":76,"context_line":"        rcall_p.stop()"},{"line_number":77,"context_line":"        # now mock HTTP class instead of rest so we can see headers"},{"line_number":78,"context_line":"        reqmock \u003d mock.MagicMock()"},{"line_number":79,"context_line":"        respmock \u003d mock.MagicMock().return_value"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9exE%3D","line":76,"in_reply_to":"AAAAWH%2F9fGc%3D","updated":"2014-04-04 08:21:06.000000000","message":"Done","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"}],"neutron/tests/unit/bigswitch/test_router_db.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f851296ccd4af391105c8105c95552ad06717701","unresolved":false,"context_lines":[{"line_number":67,"context_line":"              self).setUp(plugin\u003dself._plugin_name)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class RouterDBMixin(test_base.BigSwitchTestBase,"},{"line_number":71,"context_line":"                    test_l3_plugin.L3BaseForIntTests,"},{"line_number":72,"context_line":"                    test_l3_plugin.L3NatTestCaseMixin):"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9fFI%3D","line":70,"updated":"2014-04-04 07:36:09.000000000","message":"qustion: I think this class is a base class for RouterDb and not a mixin class. This class has no tests but I think this class can be instantiated alone. Am I missing?","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cba1a7aec96c57b587bbc96f01cc71384348eab0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"              self).setUp(plugin\u003dself._plugin_name)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class RouterDBMixin(test_base.BigSwitchTestBase,"},{"line_number":71,"context_line":"                    test_l3_plugin.L3BaseForIntTests,"},{"line_number":72,"context_line":"                    test_l3_plugin.L3NatTestCaseMixin):"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9ewo%3D","line":70,"in_reply_to":"AAAAWH%2F9fFI%3D","updated":"2014-04-04 08:21:06.000000000","message":"You are right, that was a bad name. I have changed it.","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"}],"neutron/tests/unit/bigswitch/test_servermanager.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f851296ccd4af391105c8105c95552ad06717701","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class ServerManagerTests(test_rp.BigSwitchProxyPluginV2TestCase):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        mock.patch.stopall()"},{"line_number":38,"context_line":"        self.socket_p \u003d mock.patch(SERVERMANAGER + \u0027.socket.create_connection\u0027)"},{"line_number":39,"context_line":"        self.socket_mock \u003d self.socket_p.start()"},{"line_number":40,"context_line":"        self.wrap_p \u003d mock.patch(SERVERMANAGER + \u0027.ssl.wrap_socket\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9fEQ%3D","line":37,"updated":"2014-04-04 07:36:09.000000000","message":"is stopall still required?","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cba1a7aec96c57b587bbc96f01cc71384348eab0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class ServerManagerTests(test_rp.BigSwitchProxyPluginV2TestCase):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        mock.patch.stopall()"},{"line_number":38,"context_line":"        self.socket_p \u003d mock.patch(SERVERMANAGER + \u0027.socket.create_connection\u0027)"},{"line_number":39,"context_line":"        self.socket_mock \u003d self.socket_p.start()"},{"line_number":40,"context_line":"        self.wrap_p \u003d mock.patch(SERVERMANAGER + \u0027.ssl.wrap_socket\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9ev8%3D","line":37,"in_reply_to":"AAAAWH%2F9fEQ%3D","updated":"2014-04-04 08:21:06.000000000","message":"Nope. This patch is showing it\u0027s age. :-)","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f851296ccd4af391105c8105c95552ad06717701","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        mock.patch.stopall()"},{"line_number":38,"context_line":"        self.socket_p \u003d mock.patch(SERVERMANAGER + \u0027.socket.create_connection\u0027)"},{"line_number":39,"context_line":"        self.socket_mock \u003d self.socket_p.start()"},{"line_number":40,"context_line":"        self.wrap_p \u003d mock.patch(SERVERMANAGER + \u0027.ssl.wrap_socket\u0027)"},{"line_number":41,"context_line":"        self.wrap_mock \u003d self.wrap_p.start()"},{"line_number":42,"context_line":"        super(ServerManagerTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9fC8%3D","line":39,"updated":"2014-04-04 07:36:09.000000000","message":"Do we still need to keep these variables (socket_p, socket_mock)? stopall does it, so I don\u0027t think we need them.\n\n  mock.patch(SERVERMANGER + \u0027.sokcet.create_connection\u0027).start()","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cba1a7aec96c57b587bbc96f01cc71384348eab0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        mock.patch.stopall()"},{"line_number":38,"context_line":"        self.socket_p \u003d mock.patch(SERVERMANAGER + \u0027.socket.create_connection\u0027)"},{"line_number":39,"context_line":"        self.socket_mock \u003d self.socket_p.start()"},{"line_number":40,"context_line":"        self.wrap_p \u003d mock.patch(SERVERMANAGER + \u0027.ssl.wrap_socket\u0027)"},{"line_number":41,"context_line":"        self.wrap_mock \u003d self.wrap_p.start()"},{"line_number":42,"context_line":"        super(ServerManagerTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9etk%3D","line":39,"in_reply_to":"AAAAWH%2F9fC8%3D","updated":"2014-04-04 08:21:06.000000000","message":"The mock variables are needed, but the patch ones aren\u0027t. I\u0027ve updated it to turn it into one step.","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5fca2341abee9ac420a9e4081efe345cae6ca181","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            self.assertEqual(resp, (0, None, None, None))"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_cert_get_fail(self):"},{"line_number":251,"context_line":"        pl \u003d NeutronManager.get_plugin()"},{"line_number":252,"context_line":"        pl.servers.ssl \u003d True"},{"line_number":253,"context_line":"        with mock.patch(\u0027os.path.exists\u0027, return_value\u003dFalse):"},{"line_number":254,"context_line":"            self.assertRaises(cfg.Error,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F9c8s%3D","line":251,"updated":"2014-04-04 12:27:51.000000000","message":"(suggestion only) get_plugin() is used in many places. It may be better to do the following in setUp()\n\n    self.plugin \u003d manager.NeutronManager.get_plugin()","commit_id":"45c2b0755a6b715098b4900d70682a5992d969c5"}],"neutron/tests/unit/bigswitch/test_ssl.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f851296ccd4af391105c8105c95552ad06717701","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from contextlib import nested"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import webob.exc"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9fBs%3D","line":19,"updated":"2014-04-04 07:36:09.000000000","message":"contextlib is standard module.","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cba1a7aec96c57b587bbc96f01cc71384348eab0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from contextlib import nested"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import webob.exc"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9etI%3D","line":19,"in_reply_to":"AAAAWH%2F9fBs%3D","updated":"2014-04-04 08:21:06.000000000","message":"Done","commit_id":"aa3294ed0b76d0c2d8bf897466282f35609265ba"}]}
