)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fdb473d667857d7526868f361048a6c6b27d7b0b","unresolved":false,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    def delete_ports(self, context, filters):"},{"line_number":1341,"context_line":"        query \u003d context.session.query("},{"line_number":1342,"context_line":"            models_v2.Port).enable_eagerloads(False)"},{"line_number":1343,"context_line":"        query \u003d self._apply_filters_to_query("},{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FxZU%3D","line":1342,"updated":"2014-03-13 22:22:42.000000000","message":"if you\u0027re not doing anymore select for update then you don\u0027t need to disable eagerloads.\n\nBy the way, what allowed us to avoid doing select ... for update?","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bed628b41336ea281f8db4bada82c90e9e8ea4b3","unresolved":false,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    def delete_ports(self, context, filters):"},{"line_number":1341,"context_line":"        query \u003d context.session.query("},{"line_number":1342,"context_line":"            models_v2.Port).enable_eagerloads(False)"},{"line_number":1343,"context_line":"        query \u003d self._apply_filters_to_query("},{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FuBw%3D","line":1342,"in_reply_to":"AAAAWH%2F%2FvGw%3D","updated":"2014-03-14 10:15:03.000000000","message":"I checked if required fields are specified explicitly in query, LEFT OUTER JOIN is not added. http://paste.openstack.org/show/73483/\n\n  session.query(models_v2.Port.id).filter(models_v2.Port.network_id \u003d\u003d network_id).....\n\nI changed the code to specify a field (port id).","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8d9c1dfdc607073d109c53434b5528eaedaa1583","unresolved":false,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    def delete_ports(self, context, filters):"},{"line_number":1341,"context_line":"        query \u003d context.session.query("},{"line_number":1342,"context_line":"            models_v2.Port).enable_eagerloads(False)"},{"line_number":1343,"context_line":"        query \u003d self._apply_filters_to_query("},{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FvGw%3D","line":1342,"in_reply_to":"AAAAWH%2F%2Fwfw%3D","updated":"2014-03-14 06:55:02.000000000","message":"I used enable_eagerloads(False) just because we just want to know port_id list and there is no need to join other tables. Honestly I am not sure how much performance difference there is.\n\ncontext.session.query(models_v2.Port.id) might be another choice.","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"feeb4366f11215433cf7f36ffb92bec0142fea6b","unresolved":false,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"    def delete_ports(self, context, filters):"},{"line_number":1341,"context_line":"        query \u003d context.session.query("},{"line_number":1342,"context_line":"            models_v2.Port).enable_eagerloads(False)"},{"line_number":1343,"context_line":"        query \u003d self._apply_filters_to_query("},{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fwfw%3D","line":1342,"in_reply_to":"AAAAWH%2F%2FxZU%3D","updated":"2014-03-14 00:40:16.000000000","message":"I guess since we are just to delete, so there is no need to load to related outjoined data.","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fdb473d667857d7526868f361048a6c6b27d7b0b","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"},{"line_number":1346,"context_line":"        for port_id in port_ids:"},{"line_number":1347,"context_line":"            self.delete_port(context, port_id)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1350,"context_line":"        query \u003d (context.session.query(models_v2.Port)."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FxZc%3D","line":1347,"updated":"2014-03-13 22:22:42.000000000","message":"In theory this will make the operation not atomic anymore.\nIn practices, this routine is so far called only from dhcp_rpc_base and its constructed in a way that only one port could be deleted.\n\nIn order to avoid future errors should this method be used for deleting multiple ports, I would probably:\n- rename it to delete_port_by_device_id\n- pass network_id and device_id as parameters rather than filters","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bed628b41336ea281f8db4bada82c90e9e8ea4b3","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"},{"line_number":1346,"context_line":"        for port_id in port_ids:"},{"line_number":1347,"context_line":"            self.delete_port(context, port_id)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1350,"context_line":"        query \u003d (context.session.query(models_v2.Port)."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FuJc%3D","line":1347,"in_reply_to":"AAAAWH%2F%2FvFo%3D","updated":"2014-03-14 10:15:03.000000000","message":"I added delete_ports_by_device_id. Theoretically we can have multiple ports on a network with same device_id.","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8d9c1dfdc607073d109c53434b5528eaedaa1583","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"},{"line_number":1346,"context_line":"        for port_id in port_ids:"},{"line_number":1347,"context_line":"            self.delete_port(context, port_id)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1350,"context_line":"        query \u003d (context.session.query(models_v2.Port)."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FvFo%3D","line":1347,"in_reply_to":"AAAAWH%2F%2FxZc%3D","updated":"2014-03-14 06:55:02.000000000","message":"Sounds like a good idea. will do.","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"feeb4366f11215433cf7f36ffb92bec0142fea6b","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"            query, models_v2.Port, filters)"},{"line_number":1345,"context_line":"        port_ids \u003d [p[\u0027id\u0027] for p in query]"},{"line_number":1346,"context_line":"        for port_id in port_ids:"},{"line_number":1347,"context_line":"            self.delete_port(context, port_id)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1350,"context_line":"        query \u003d (context.session.query(models_v2.Port)."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FweY%3D","line":1347,"in_reply_to":"AAAAWH%2F%2FxZc%3D","updated":"2014-03-14 00:40:16.000000000","message":"agreed","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fdb473d667857d7526868f361048a6c6b27d7b0b","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"                self.assertEqual(res.status_int,"},{"line_number":1655,"context_line":"                                 webob.exc.HTTPClientError.code)"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"    def test_delete_ports(self):"},{"line_number":1658,"context_line":"        plugin \u003d NeutronManager.get_plugin()"},{"line_number":1659,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":1660,"context_line":"        with self.subnet() as subnet:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FxX8%3D","line":1657,"updated":"2014-03-13 22:22:42.000000000","message":"With the use case you are building here, you should be able to demonstrate how this patch broke* atomicity for delete_ports.\nFor instance if _delete_port for p2 failed, then delete_ports would have failed, but p1 would have been deleted anyway.\n\n\n* broke is a bit vague here since before atomicity would have been broken anyway in any backed (such as NSX for instance) even if it were preserved in the DB","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8d9c1dfdc607073d109c53434b5528eaedaa1583","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"                self.assertEqual(res.status_int,"},{"line_number":1655,"context_line":"                                 webob.exc.HTTPClientError.code)"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"    def test_delete_ports(self):"},{"line_number":1658,"context_line":"        plugin \u003d NeutronManager.get_plugin()"},{"line_number":1659,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":1660,"context_line":"        with self.subnet() as subnet:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fuvw%3D","line":1657,"in_reply_to":"AAAAWH%2F%2FxX8%3D","updated":"2014-03-14 06:55:02.000000000","message":"What I would like to test is to confirm delete_ports with filters works. I will add a test case to check some deletion fail.","commit_id":"6e4a71c0c55123ab832bf1aef5f99abbdaac9373"}],"neutron/tests/unit/test_db_rpc_base.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9e884e9da729a938165423faba1c684e4013d3f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.callbacks \u003d dhcp_rpc_base.DhcpRpcCallbackMixin()"},{"line_number":34,"context_line":"        self.log_p \u003d mock.patch(\u0027neutron.db.dhcp_rpc_base.LOG\u0027)"},{"line_number":35,"context_line":"        self.log \u003d self.log_p.start()"},{"line_number":36,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_get_active_networks(self):"},{"line_number":39,"context_line":"        plugin_retval \u003d [dict(id\u003d\u0027a\u0027), dict(id\u003d\u0027b\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FmGY%3D","line":36,"updated":"2014-03-15 15:01:44.000000000","message":"Not needed. See review 79830.","commit_id":"e5bd9c2b3606e46edbbeb03fcb35a961f68249ec"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b11173f4ed6f450071c54c8159dc2ba027af6e9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.callbacks \u003d dhcp_rpc_base.DhcpRpcCallbackMixin()"},{"line_number":34,"context_line":"        self.log_p \u003d mock.patch(\u0027neutron.db.dhcp_rpc_base.LOG\u0027)"},{"line_number":35,"context_line":"        self.log \u003d self.log_p.start()"},{"line_number":36,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_get_active_networks(self):"},{"line_number":39,"context_line":"        plugin_retval \u003d [dict(id\u003d\u0027a\u0027), dict(id\u003d\u0027b\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FmEc%3D","line":36,"in_reply_to":"AAAAWH%2F%2FmGY%3D","updated":"2014-03-15 15:45:38.000000000","message":"Done. Thanks totally forgot it.","commit_id":"e5bd9c2b3606e46edbbeb03fcb35a961f68249ec"}]}
