)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"65494ab6c4a338d838cd184666f46456c3ff425e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     fanxiujian \u003cxiujian.fan@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-10 08:42:57 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the increase of fd caused by HA port not recycled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding ha port cleanup causes the ha port"},{"line_number":10,"context_line":"in the bridge device to be removed normally"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"57a750c3_22d704ec","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":53},"updated":"2021-05-11 01:29:03.000000000","message":"After a quick testing, delete a HA router, the ha-port will be deleted. No port or interface information remained in ovsdb. Am I missing something? Did you deployment use the `ovs_use_veth \u003d True` ? This may be a potential problem.","commit_id":"00762cbc3394f82c60e79d0f4046a73ae405f52d"}],"neutron/agent/l3/namespaces.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"65494ab6c4a338d838cd184666f46456c3ff425e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"EXTERNAL_DEV_PREFIX \u003d \u0027qg-\u0027"},{"line_number":28,"context_line":"HA_DEV_PREFIX \u003d \u0027ha-\u0027"},{"line_number":29,"context_line":"# TODO(Carl) It is odd that this file needs this.  It is a dvr detail."},{"line_number":30,"context_line":"ROUTER_2_FIP_DEV_PREFIX \u003d \u0027rfp-\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def build_ns_name(prefix, identifier):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a55567a0_4944a25f","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"updated":"2021-05-11 01:29:03.000000000","message":"For DVR, there is snat namespace with sg-device, so it will have the same issue?\nFor fip-namespace, there is fpr-dev and fg-dev, are they facing the similar situation?","commit_id":"00762cbc3394f82c60e79d0f4046a73ae405f52d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c1ca8b99959080a8d3e8dc44928355abe71a190","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                    d.name,"},{"line_number":147,"context_line":"                    namespace\u003dself.name,"},{"line_number":148,"context_line":"                    prefix\u003dEXTERNAL_DEV_PREFIX)"},{"line_number":149,"context_line":"            elif d.name.startswith(HA_DEV_PREFIX):"},{"line_number":150,"context_line":"                self.driver.unplug(d.name, namespace\u003dself.name,"},{"line_number":151,"context_line":"                                   prefix\u003dHA_DEV_PREFIX)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cfb75a78_bcc2ff6b","line":149,"updated":"2021-05-10 15:20:50.000000000","message":"Is this really solving the problem you described in the LP bug?\n\nI\u0027m saying this because this is called just before the namespace deletion, that will delete any existing interface in the namespace itself. The \"ha-xxxx\" interface will be deleted when the namespace is removed. This is not even a veth pair so there will be no orphan sibling in other namespace.\n\nDid you really check that this indeed solving the issue you reported? I\u0027ve tested creating manually 100 namespaces and inside each namespace 1000 devices (all set to UP). Then I\u0027ve deleted the namespaces with deleting the interfaces.\n\n$ for ns in {1..100}; do ip netns add ns-$ns; for i in {1..1000}; do ip netns exec ns-$ns ip link add dev d$i type dummy; ip netns exec ns-$ns ip link set dev d$i up; done; done\n\nDuring this time I had a watch to \"lsof | wc -l\". When I deleted all namespaces, the number of open files dropped to a number similar to the beginning of the test.","commit_id":"00762cbc3394f82c60e79d0f4046a73ae405f52d"}]}
