)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44c40fd7f3d844b142d456a9b9aa1c3dea4cb928","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    def lookup(self, table, record, default\u003dovs_idl._NO_DEFAULT, timeout\u003dNone,"},{"line_number":155,"context_line":"               notify_handler\u003dNone):"},{"line_number":156,"context_line":"        # Timeout is set to DEFAULT_LOOKUP_TIMEOUT when the passed value is"},{"line_number":157,"context_line":"        # \"None\". Timeout can be disabled passing zero value."},{"line_number":158,"context_line":"        timeout \u003d timeout if timeout is not None else DEFAULT_LOOKUP_TIMEOUT"},{"line_number":159,"context_line":"        self.lookup(table, record, default\u003ddefault, timeout\u003dtimeout,"},{"line_number":160,"context_line":"                    notify_handler\u003dnotify_handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4d8c44d_5cc30581","line":157,"updated":"2021-05-13 08:01:05.000000000","message":"Why not just setting the timeout to DEFAULT_LOOKUP_TIMEOUT by default? And none or 0 disables it?","commit_id":"e3a1f7ad0c3729964a91bd40d80cd384e268c2bf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7c788177cde6f286bf782d27904442e06757cee5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def lookup(self, table, record, default\u003dovs_idl._NO_DEFAULT, timeout\u003dNone,"},{"line_number":155,"context_line":"               notify_handler\u003dNone):"},{"line_number":156,"context_line":"        # Timeout is set to DEFAULT_LOOKUP_TIMEOUT when the passed value is"},{"line_number":157,"context_line":"        # \"None\". Timeout can be disabled passing zero value."},{"line_number":158,"context_line":"        timeout \u003d timeout if timeout is not None else DEFAULT_LOOKUP_TIMEOUT"},{"line_number":159,"context_line":"        self.lookup(table, record, default\u003ddefault, timeout\u003dtimeout,"},{"line_number":160,"context_line":"                    notify_handler\u003dnotify_handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef38c464_d184c74b","line":157,"in_reply_to":"d4d8c44d_5cc30581","updated":"2021-05-13 13:20:44.000000000","message":"Done","commit_id":"e3a1f7ad0c3729964a91bd40d80cd384e268c2bf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44c40fd7f3d844b142d456a9b9aa1c3dea4cb928","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        # Timeout is set to DEFAULT_LOOKUP_TIMEOUT when the passed value is"},{"line_number":157,"context_line":"        # \"None\". Timeout can be disabled passing zero value."},{"line_number":158,"context_line":"        timeout \u003d timeout if timeout is not None else DEFAULT_LOOKUP_TIMEOUT"},{"line_number":159,"context_line":"        self.lookup(table, record, default\u003ddefault, timeout\u003dtimeout,"},{"line_number":160,"context_line":"                    notify_handler\u003dnotify_handler)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f7465a66_b2adf972","line":159,"updated":"2021-05-13 08:01:05.000000000","message":"should it be a super call?","commit_id":"e3a1f7ad0c3729964a91bd40d80cd384e268c2bf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7c788177cde6f286bf782d27904442e06757cee5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        # Timeout is set to DEFAULT_LOOKUP_TIMEOUT when the passed value is"},{"line_number":157,"context_line":"        # \"None\". Timeout can be disabled passing zero value."},{"line_number":158,"context_line":"        timeout \u003d timeout if timeout is not None else DEFAULT_LOOKUP_TIMEOUT"},{"line_number":159,"context_line":"        self.lookup(table, record, default\u003ddefault, timeout\u003dtimeout,"},{"line_number":160,"context_line":"                    notify_handler\u003dnotify_handler)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"db8d2552_e22ae2a4","line":159,"in_reply_to":"3302fce4_2b4b9962","updated":"2021-05-13 13:20:44.000000000","message":"Done","commit_id":"e3a1f7ad0c3729964a91bd40d80cd384e268c2bf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1521f1a49b7bda958f739a7869e0e48b71a251c8","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        # Timeout is set to DEFAULT_LOOKUP_TIMEOUT when the passed value is"},{"line_number":157,"context_line":"        # \"None\". Timeout can be disabled passing zero value."},{"line_number":158,"context_line":"        timeout \u003d timeout if timeout is not None else DEFAULT_LOOKUP_TIMEOUT"},{"line_number":159,"context_line":"        self.lookup(table, record, default\u003ddefault, timeout\u003dtimeout,"},{"line_number":160,"context_line":"                    notify_handler\u003dnotify_handler)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3302fce4_2b4b9962","line":159,"in_reply_to":"f7465a66_b2adf972","updated":"2021-05-13 12:15:58.000000000","message":"Yeah, I\u0027d just change the default in the signature and call super().","commit_id":"e3a1f7ad0c3729964a91bd40d80cd384e268c2bf"}]}