)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"902c7e417959b5c3c4166715e33212b9bea8320b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow the use of legacy routers within RPN segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds to legacy routers (no HA nor DVR) to be connected"},{"line_number":10,"context_line":"to a router provider network segment through the gwateway interface."},{"line_number":11,"context_line":"The router will be connected to one single segment of the RPN; that"},{"line_number":12,"context_line":"means the router will have L2 connectivity to one single subnet."},{"line_number":13,"context_line":"The gateway router port will have an IP address on the subnet CIDR;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4f96b674_a4bff882","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":57},"updated":"2021-05-24 08:39:23.000000000","message":"nitty nit: gateway","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26a992d6ce34fcb28aa741979b2e762bc2aee161","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow the use of legacy routers within RPN segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds to legacy routers (no HA nor DVR) to be connected"},{"line_number":10,"context_line":"to a router provider network segment through the gwateway interface."},{"line_number":11,"context_line":"The router will be connected to one single segment of the RPN; that"},{"line_number":12,"context_line":"means the router will have L2 connectivity to one single subnet."},{"line_number":13,"context_line":"The gateway router port will have an IP address on the subnet CIDR;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ddffac05_c927ab5e","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":57},"in_reply_to":"4f96b674_a4bff882","updated":"2021-05-24 10:52:20.000000000","message":"Done","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow the use of legacy routers within RPN segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds to legacy routers (no HA nor DVR) to be connected"},{"line_number":10,"context_line":"to a router provider network segment through the gateway interface."},{"line_number":11,"context_line":"The router will be connected to one single segment of the RPN; that"},{"line_number":12,"context_line":"means the router will have L2 connectivity to one single subnet."},{"line_number":13,"context_line":"The gateway router port will have an IP address on the subnet CIDR;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d0e552eb_f942b3fa","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":11},"updated":"2021-06-09 13:36:05.000000000","message":"nit: routed","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow the use of legacy routers within RPN segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds to legacy routers (no HA nor DVR) to be connected"},{"line_number":10,"context_line":"to a router provider network segment through the gateway interface."},{"line_number":11,"context_line":"The router will be connected to one single segment of the RPN; that"},{"line_number":12,"context_line":"means the router will have L2 connectivity to one single subnet."},{"line_number":13,"context_line":"The gateway router port will have an IP address on the subnet CIDR;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b394655b_4059df11","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":11},"in_reply_to":"d0e552eb_f942b3fa","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"}],"doc/source/admin/config-routed-networks.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"902c7e417959b5c3c4166715e33212b9bea8320b","unresolved":true,"context_lines":[{"line_number":553,"context_line":"   ─────────────┤                     │"},{"line_number":554,"context_line":"                └─────────────────────┘"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"The router provider network, acting as router gateway, contains all subnets"},{"line_number":557,"context_line":"associated to the segments. In a deployment without router provided networks,"},{"line_number":558,"context_line":"the gateway port has L2 connectivity to all subnet CIDRs. In this case, the"},{"line_number":559,"context_line":"gateway port has only connectivity to the attached segment subnets and its"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8eb99781_f4f789da","line":556,"range":{"start_line":556,"start_character":4,"end_line":556,"end_character":10},"updated":"2021-05-24 08:39:23.000000000","message":"just a question: should it be \"router provider network\" or \"routed provider network\"?","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26a992d6ce34fcb28aa741979b2e762bc2aee161","unresolved":false,"context_lines":[{"line_number":553,"context_line":"   ─────────────┤                     │"},{"line_number":554,"context_line":"                └─────────────────────┘"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"The router provider network, acting as router gateway, contains all subnets"},{"line_number":557,"context_line":"associated to the segments. In a deployment without router provided networks,"},{"line_number":558,"context_line":"the gateway port has L2 connectivity to all subnet CIDRs. In this case, the"},{"line_number":559,"context_line":"gateway port has only connectivity to the attached segment subnets and its"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2c94577b_64fc7248","line":556,"range":{"start_line":556,"start_character":4,"end_line":556,"end_character":10},"in_reply_to":"8eb99781_f4f789da","updated":"2021-05-24 10:52:20.000000000","message":"routed, you are right","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"902c7e417959b5c3c4166715e33212b9bea8320b","unresolved":true,"context_lines":[{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"The problem in the case of connecting the gatewat port to a routed provider"},{"line_number":569,"context_line":"network is that it will have broadcast connectivity only to those subnets"},{"line_number":570,"context_line":"that belong to the host segment:"},{"line_number":571,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"cfd201e6_c3e5b918","line":568,"range":{"start_line":568,"start_character":60,"end_line":568,"end_character":66},"updated":"2021-05-24 08:39:23.000000000","message":"hmm, here You are using \"routed provider network\" so I think that above it was \"router\" by mistake","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26a992d6ce34fcb28aa741979b2e762bc2aee161","unresolved":true,"context_lines":[{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"The problem in the case of connecting the gatewat port to a routed provider"},{"line_number":569,"context_line":"network is that it will have broadcast connectivity only to those subnets"},{"line_number":570,"context_line":"that belong to the host segment:"},{"line_number":571,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"50a472b1_fe8ae2c2","line":568,"range":{"start_line":568,"start_character":60,"end_line":568,"end_character":66},"in_reply_to":"cfd201e6_c3e5b918","updated":"2021-05-24 10:52:20.000000000","message":"yeah, the feature is https://docs.openstack.org/neutron/latest/admin/config-routed-networks.html","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"Could be the case that the user needs to split the communication between"},{"line_number":542,"context_line":"several hosts. It is possible to create tenant networks and connect them using"},{"line_number":543,"context_line":"a router. To access to the router provider network, it should be connected"},{"line_number":544,"context_line":"as router gateway."},{"line_number":545,"context_line":""},{"line_number":546,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dd64a1a7_14ae64ad","line":543,"range":{"start_line":543,"start_character":27,"end_line":543,"end_character":33},"updated":"2021-06-09 13:36:05.000000000","message":"nit: routed","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"Could be the case that the user needs to split the communication between"},{"line_number":542,"context_line":"several hosts. It is possible to create tenant networks and connect them using"},{"line_number":543,"context_line":"a router. To access to the router provider network, it should be connected"},{"line_number":544,"context_line":"as router gateway."},{"line_number":545,"context_line":""},{"line_number":546,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e8d5531f_fb076d99","line":543,"range":{"start_line":543,"start_character":27,"end_line":543,"end_character":33},"in_reply_to":"dd64a1a7_14ae64ad","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                └─────────────────────┘"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"The routed provider network, acting as router gateway, contains all subnets"},{"line_number":557,"context_line":"associated to the segments. In a deployment without router provided networks,"},{"line_number":558,"context_line":"the gateway port has L2 connectivity to all subnet CIDRs. In this case, the"},{"line_number":559,"context_line":"gateway port has only connectivity to the attached segment subnets and its"},{"line_number":560,"context_line":"L2 broadcast domains."}],"source_content_type":"text/x-rst","patch_set":7,"id":"65de6227_c0c252f6","line":557,"range":{"start_line":557,"start_character":52,"end_line":557,"end_character":58},"updated":"2021-06-09 13:36:05.000000000","message":"nit: ditto","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                └─────────────────────┘"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"The routed provider network, acting as router gateway, contains all subnets"},{"line_number":557,"context_line":"associated to the segments. In a deployment without router provided networks,"},{"line_number":558,"context_line":"the gateway port has L2 connectivity to all subnet CIDRs. In this case, the"},{"line_number":559,"context_line":"gateway port has only connectivity to the attached segment subnets and its"},{"line_number":560,"context_line":"L2 broadcast domains."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5bf95ef6_de8bf9be","line":557,"range":{"start_line":557,"start_character":52,"end_line":557,"end_character":58},"in_reply_to":"65de6227_c0c252f6","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":560,"context_line":"L2 broadcast domains."},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."}],"source_content_type":"text/x-rst","patch_set":7,"id":"e708a091_9e2626f0","line":563,"range":{"start_line":563,"start_character":50,"end_line":563,"end_character":52},"updated":"2021-06-09 13:36:05.000000000","message":"nit: not","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":560,"context_line":"L2 broadcast domains."},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."}],"source_content_type":"text/x-rst","patch_set":7,"id":"314febd4_f829eade","line":563,"range":{"start_line":563,"start_character":70,"end_line":563,"end_character":74},"updated":"2021-06-09 13:36:05.000000000","message":"nit: port\u0027s","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":560,"context_line":"L2 broadcast domains."},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fcc9a2e1_fd5be19e","line":563,"range":{"start_line":563,"start_character":70,"end_line":563,"end_character":74},"in_reply_to":"314febd4_f829eade","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":560,"context_line":"L2 broadcast domains."},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."}],"source_content_type":"text/x-rst","patch_set":7,"id":"608d418e_bfdf063f","line":563,"range":{"start_line":563,"start_character":50,"end_line":563,"end_character":52},"in_reply_to":"e708a091_9e2626f0","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f33769901a0c6ac89e3ebf6147a0d4db2ff2408","unresolved":true,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."},{"line_number":567,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"73442cd5_aff0f0a2","line":564,"range":{"start_line":564,"start_character":18,"end_line":564,"end_character":19},"updated":"2021-06-09 13:36:05.000000000","message":"nit: an","commit_id":"f450886ff93a201c6520d84088c3a97330814140"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3545b62b15960a060682c27536ea300f95e7cd6","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"The L3 agent will create, inside the router namespace, a default route in the"},{"line_number":563,"context_line":"gateway port fixed IP CIDR. For each other subnet no belonging to the port"},{"line_number":564,"context_line":"fixed IP address, a onlink route is created. These routes use the gateway port"},{"line_number":565,"context_line":"as routing device and allow to route any packet with destination on these"},{"line_number":566,"context_line":"CIDRs through this port."},{"line_number":567,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9eb279cd_69576010","line":564,"range":{"start_line":564,"start_character":18,"end_line":564,"end_character":19},"in_reply_to":"73442cd5_aff0f0a2","updated":"2021-06-09 15:16:46.000000000","message":"Done","commit_id":"f450886ff93a201c6520d84088c3a97330814140"}],"neutron/db/l3_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71a68202099b81368b84bd0cd0ad64b2717ca40c","unresolved":true,"context_lines":[{"line_number":1835,"context_line":"                        break"},{"line_number":1836,"context_line":"                else:"},{"line_number":1837,"context_line":"                    # This subnet is not used by the port."},{"line_number":1838,"context_line":"                    port[\u0027extra_subnets\u0027].append(subnet_info)"},{"line_number":1839,"context_line":""},{"line_number":1840,"context_line":"            port[\u0027address_scopes\u0027].update(scopes)"},{"line_number":1841,"context_line":"            port[\u0027mtu\u0027] \u003d mtus_by_network.get(port[\u0027network_id\u0027], 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"512fc1ab_a7400ce6","side":"PARENT","line":1838,"range":{"start_line":1838,"start_character":20,"end_line":1838,"end_character":61},"updated":"2021-05-21 12:33:54.000000000","message":"I need to consider the case where the segment has multiple subnets","commit_id":"9e6b7a2284a39ae74d2092083165e3fdf4cb8f33"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"902c7e417959b5c3c4166715e33212b9bea8320b","unresolved":true,"context_lines":[{"line_number":1836,"context_line":"                               \u0027dns_nameservers\u0027: subnet[\u0027dns_nameservers\u0027],"},{"line_number":1837,"context_line":"                               \u0027ipv6_ra_mode\u0027: subnet[\u0027ipv6_ra_mode\u0027],"},{"line_number":1838,"context_line":"                               \u0027subnetpool_id\u0027: subnet[\u0027subnetpool_id\u0027]}"},{"line_number":1839,"context_line":""},{"line_number":1840,"context_line":"                for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":1841,"context_line":"                    if fixed_ip[\u0027subnet_id\u0027] \u003d\u003d subnet[\u0027id\u0027]:"},{"line_number":1842,"context_line":"                        port[\u0027subnets\u0027].append(subnet_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2637c93d_1cd9ed43","line":1839,"updated":"2021-05-24 08:39:23.000000000","message":"nitty nit: unrelated change","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26a992d6ce34fcb28aa741979b2e762bc2aee161","unresolved":false,"context_lines":[{"line_number":1836,"context_line":"                               \u0027dns_nameservers\u0027: subnet[\u0027dns_nameservers\u0027],"},{"line_number":1837,"context_line":"                               \u0027ipv6_ra_mode\u0027: subnet[\u0027ipv6_ra_mode\u0027],"},{"line_number":1838,"context_line":"                               \u0027subnetpool_id\u0027: subnet[\u0027subnetpool_id\u0027]}"},{"line_number":1839,"context_line":""},{"line_number":1840,"context_line":"                for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":1841,"context_line":"                    if fixed_ip[\u0027subnet_id\u0027] \u003d\u003d subnet[\u0027id\u0027]:"},{"line_number":1842,"context_line":"                        port[\u0027subnets\u0027].append(subnet_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"78e9314d_67c93180","line":1839,"in_reply_to":"2637c93d_1cd9ed43","updated":"2021-05-24 10:52:20.000000000","message":"Done","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"902c7e417959b5c3c4166715e33212b9bea8320b","unresolved":true,"context_lines":[{"line_number":1850,"context_line":"                    # The router will add only the onlink routes to those"},{"line_number":1851,"context_line":"                    # subnet CIDRs."},{"line_number":1852,"context_line":"                    if is_gw and seg_plugin_loaded:"},{"line_number":1853,"context_line":"                        if subnet[\u0027segment_id\u0027] \u003d\u003d gw_port_segment:"},{"line_number":1854,"context_line":"                            port[\u0027extra_subnets\u0027].append(subnet_info)"},{"line_number":1855,"context_line":"                    else:"},{"line_number":1856,"context_line":"                        port[\u0027extra_subnets\u0027].append(subnet_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f09b1457_27eade4e","line":1853,"range":{"start_line":1853,"start_character":51,"end_line":1853,"end_character":66},"updated":"2021-05-24 08:39:23.000000000","message":"is it possible that gw_port_segment will not be found in L1817-1821 and will be \"None\" here? If so, is that ok to have it set as None?","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26a992d6ce34fcb28aa741979b2e762bc2aee161","unresolved":true,"context_lines":[{"line_number":1850,"context_line":"                    # The router will add only the onlink routes to those"},{"line_number":1851,"context_line":"                    # subnet CIDRs."},{"line_number":1852,"context_line":"                    if is_gw and seg_plugin_loaded:"},{"line_number":1853,"context_line":"                        if subnet[\u0027segment_id\u0027] \u003d\u003d gw_port_segment:"},{"line_number":1854,"context_line":"                            port[\u0027extra_subnets\u0027].append(subnet_info)"},{"line_number":1855,"context_line":"                    else:"},{"line_number":1856,"context_line":"                        port[\u0027extra_subnets\u0027].append(subnet_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f3cfa342_262161ed","line":1853,"range":{"start_line":1853,"start_character":51,"end_line":1853,"end_character":66},"in_reply_to":"f09b1457_27eade4e","updated":"2021-05-24 10:52:20.000000000","message":"RPN allows to create networks with all subnets associated to segments or none of them; we cannot have some subnets associated to segments and not others in the same network. That means if the external network has subnets with segments, this logic will work.\n\nIn the case you present, if the subnet where the GW port IP is allocated does NOT have an associated segment, that means the other subnets are not associated neither. That means this is not a routed provider network and all subnets must be added as \"extra_subnets\".\n\nI\u0027ll add a test case to cover this scenario.\n\nNOTE: ^^ in \"test__populate_ports_for_subnets_gw_port\", I\u0027ll add \"{\u0027plugin_loaded\u0027: True, \u0027seg1\u0027: None, \u0027seg2\u0027: None}\", that will check this scenario.","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"45251978e1445fd1f38c5c0a70e6fac2dd723ac6","unresolved":true,"context_lines":[{"line_number":1850,"context_line":"                    # The router will add only the onlink routes to those"},{"line_number":1851,"context_line":"                    # subnet CIDRs."},{"line_number":1852,"context_line":"                    if is_gw and seg_plugin_loaded:"},{"line_number":1853,"context_line":"                        if subnet[\u0027segment_id\u0027] \u003d\u003d gw_port_segment:"},{"line_number":1854,"context_line":"                            port[\u0027extra_subnets\u0027].append(subnet_info)"},{"line_number":1855,"context_line":"                    else:"},{"line_number":1856,"context_line":"                        port[\u0027extra_subnets\u0027].append(subnet_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5adf8f95_630dd07a","line":1853,"range":{"start_line":1853,"start_character":51,"end_line":1853,"end_character":66},"in_reply_to":"f3cfa342_262161ed","updated":"2021-05-25 08:02:52.000000000","message":"+1. Thx","commit_id":"0fa49e6f1fc8b13d1e52d0bfeb61eaf53e25230a"}]}