)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"93b22c1ed7b6fa2a3dc4c06f10603016894183be","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":348,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":349,"context_line":"            # a unicast vxlan interface should set the local ip address here"},{"line_number":350,"context_line":"            # to handle a source dev with multiple ip addresses configured."},{"line_number":351,"context_line":"            else:"},{"line_number":352,"context_line":"                args[\u0027local\u0027] \u003d self.local_ip"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dca234e1_2118bc5c","line":350,"range":{"start_line":349,"start_character":12,"end_line":350,"end_character":75},"updated":"2021-05-31 07:16:53.000000000","message":"putting this comment under \u0027else\u0027 below seems more readable, but maybe it\u0027s only me","commit_id":"892bfea7dd51db9984d0144e32ac9b2a52334c7c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e5d255b2541d9f9a3c92b33af322005806f88d27","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":348,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":349,"context_line":"            # a unicast vxlan interface should set the local ip address here"},{"line_number":350,"context_line":"            # to handle a source dev with multiple ip addresses configured."},{"line_number":351,"context_line":"            else:"},{"line_number":352,"context_line":"                args[\u0027local\u0027] \u003d self.local_ip"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"b0026f04_8358f030","line":350,"range":{"start_line":349,"start_character":12,"end_line":350,"end_character":75},"in_reply_to":"dca234e1_2118bc5c","updated":"2021-05-31 13:34:15.000000000","message":"+1","commit_id":"892bfea7dd51db9984d0144e32ac9b2a52334c7c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"93b22c1ed7b6fa2a3dc4c06f10603016894183be","unresolved":true,"context_lines":[{"line_number":348,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":349,"context_line":"            # a unicast vxlan interface should set the local ip address here"},{"line_number":350,"context_line":"            # to handle a source dev with multiple ip addresses configured."},{"line_number":351,"context_line":"            else:"},{"line_number":352,"context_line":"                args[\u0027local\u0027] \u003d self.local_ip"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"            if cfg.CONF.VXLAN.l2_population:"}],"source_content_type":"text/x-python","patch_set":7,"id":"e8e31fc6_8def94b7","line":351,"range":{"start_line":351,"start_character":12,"end_line":351,"end_character":17},"updated":"2021-05-31 07:16:53.000000000","message":"I think it\u0027s better to check unicast explicitly","commit_id":"892bfea7dd51db9984d0144e32ac9b2a52334c7c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2988d39ee91485388a79eb0a917296779ed3fe96","unresolved":true,"context_lines":[{"line_number":350,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":351,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":352,"context_line":"                args[\u0027local\u0027] \u003d self.local_ip"},{"line_number":353,"context_line":"                # L2population should set the local ip address to handle a"},{"line_number":354,"context_line":"                # source dev with multiple ip addresses configured."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"            try:"},{"line_number":357,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c3ca5506_b5266d99","line":354,"range":{"start_line":353,"start_character":16,"end_line":354,"end_character":67},"updated":"2021-06-01 07:46:55.000000000","message":"why it\u0027s below and not above #352?","commit_id":"fddb1972010447542934d855d6cdb7806b41326b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"95fc5439248f989d4f4646d736327a148b392156","unresolved":true,"context_lines":[{"line_number":350,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":351,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":352,"context_line":"                args[\u0027local\u0027] \u003d self.local_ip"},{"line_number":353,"context_line":"                # L2population should set the local ip address to handle a"},{"line_number":354,"context_line":"                # source dev with multiple ip addresses configured."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"            try:"},{"line_number":357,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab9a3574_9331c68f","line":354,"range":{"start_line":353,"start_character":16,"end_line":354,"end_character":67},"in_reply_to":"c3ca5506_b5266d99","updated":"2021-06-01 09:00:38.000000000","message":"+1","commit_id":"fddb1972010447542934d855d6cdb7806b41326b"}]}