)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0ce021073de8c3c6fc8207120700dfdf9b55d45c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-06 16:52:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Privsep with timout for get_link_devices call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add timeout to get_link_devices privsep decorator."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d3f0d2a2_32e6756d","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":45},"updated":"2021-06-07 07:34:54.000000000","message":"I think it should be a generic check, not specific to this command","commit_id":"cfbe45a1e22fbdbc62718618590812429bac1a9a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0ce021073de8c3c6fc8207120700dfdf9b55d45c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-06 16:52:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Privsep with timout for get_link_devices call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add timeout to get_link_devices privsep decorator."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5703bc22_b524ea12","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":19},"updated":"2021-06-07 07:34:54.000000000","message":"nit: timeout","commit_id":"cfbe45a1e22fbdbc62718618590812429bac1a9a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"175b808625005a9a793ef41931f5caa7250a00ff","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Privsep with timout for get_link_devices call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add timeout to get_link_devices privsep decorator."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I55e674ec73ea07352740353210375e76e972a87d"},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/oslo.privsep/+/794993"},{"line_number":13,"context_line":"Related-Bug: #1930401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"801ecb0c_4e7f87ba","line":10,"updated":"2021-06-28 11:33:25.000000000","message":"I left out unit tests, as\n- there is no unit test for this method currently\n- I run into terrible timeouts with quick checks (I can play with it more if we need unit tests for","commit_id":"69766613e1cfe49c822429e76b7fb76e50974e3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b9ef08c4f70b32365e23b7e6f53c640659fdbad3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-06 09:47:14 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Privsep with timout for get_link_devices call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add timeout to get_link_devices privsep decorator."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5fc9bdbf_8d85d000","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":19},"updated":"2021-07-06 07:54:49.000000000","message":"timeout","commit_id":"81190dd7ef823365fe101f75ab6c801ab8a6e8d2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"99f17fcb3cefb59f7fe9d9cbfa0849445d3c42ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-06 09:47:14 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Privsep with timout for get_link_devices call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add timeout to get_link_devices privsep decorator."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b4582538_662dd46f","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":19},"in_reply_to":"5fc9bdbf_8d85d000","updated":"2021-07-06 09:14:28.000000000","message":"Done","commit_id":"81190dd7ef823365fe101f75ab6c801ab8a6e8d2"}],"lower-constraints.txt":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b9ef08c4f70b32365e23b7e6f53c640659fdbad3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"oslo.messaging\u003d\u003d7.0.0"},{"line_number":68,"context_line":"oslo.middleware\u003d\u003d3.31.0"},{"line_number":69,"context_line":"oslo.policy\u003d\u003d3.7.0"},{"line_number":70,"context_line":"oslo.privsep\u003d\u003d2.6.0"},{"line_number":71,"context_line":"oslo.reports\u003d\u003d1.18.0"},{"line_number":72,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":73,"context_line":"oslo.serialization\u003d\u003d2.25.0"}],"source_content_type":"text/plain","patch_set":5,"id":"41ce54db_bcc0a5c5","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":3},"updated":"2021-07-06 07:54:49.000000000","message":"You need to change requirements.txt too","commit_id":"81190dd7ef823365fe101f75ab6c801ab8a6e8d2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a69f36ae2bfd5bd455353a0a001fd322342cd0f3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"oslo.messaging\u003d\u003d7.0.0"},{"line_number":68,"context_line":"oslo.middleware\u003d\u003d3.31.0"},{"line_number":69,"context_line":"oslo.policy\u003d\u003d3.7.0"},{"line_number":70,"context_line":"oslo.privsep\u003d\u003d2.6.0"},{"line_number":71,"context_line":"oslo.reports\u003d\u003d1.18.0"},{"line_number":72,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":73,"context_line":"oslo.serialization\u003d\u003d2.25.0"}],"source_content_type":"text/plain","patch_set":5,"id":"6a857259_2c7889e1","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":3},"in_reply_to":"41ce54db_bcc0a5c5","updated":"2021-07-06 09:14:57.000000000","message":"thanks, I forgot it","commit_id":"81190dd7ef823365fe101f75ab6c801ab8a6e8d2"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fbfc1556c57c490793d48ae2b790cfb0076ed53c","unresolved":true,"context_lines":[{"line_number":569,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"},{"line_number":570,"context_line":"            raise NetworkNamespaceNotFound(netns_name\u003dnamespace)"},{"line_number":571,"context_line":"        raise"},{"line_number":572,"context_line":"    except daemon.FailedToDropPrivileges:"},{"line_number":573,"context_line":"        raise"},{"line_number":574,"context_line":"    except daemon.PrivsepTimeout:"},{"line_number":575,"context_line":"        raise"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"def get_device_names(namespace, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c66259fc_f3ff2319","line":575,"range":{"start_line":572,"start_character":4,"end_line":575,"end_character":13},"updated":"2021-06-10 08:43:47.000000000","message":"no need to handle if just re-raising","commit_id":"5be8e2ff9e04b05d4569834677236b7a8ad434be"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"36b63dcfa7e0c9cd28a89545ed2927755bdb5da4","unresolved":true,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"@privileged.default.entrypoint_with_timeout(timeout\u003d5)"},{"line_number":560,"context_line":"def get_link_devices(namespace, **kwargs):"},{"line_number":561,"context_line":"    \"\"\"List interfaces in a namespace"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    :return: (list) interfaces in a namespace"}],"source_content_type":"text/x-python","patch_set":9,"id":"340c10fb_ebac6ed5","line":560,"range":{"start_line":560,"start_character":4,"end_line":560,"end_character":20},"updated":"2021-07-07 07:22:50.000000000","message":"I checked and looks like this is not the first privileged command called by dhcp agent: \n- the first one with namespace_cmd context is list_netns()\n- the first one with default context is open_namespace() - this one hangs actually.\n\nThat\u0027s why initially I suggested to add some timeout to all privileged commands by default - you never know which one may hang, or at least which one will become first at some point.\n\nI suggest to add timeout to open_namespace(), remove second dhcp agent from fullstack test right in this patch and see how tests perform. \n\nThen may consider adding default privsep context timeout.","commit_id":"dd9320bc8cfc943d0df25ebdfca84ccb548f4372"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf2e64c8dd8c49ccdc1951e2cf366872ef3a1127","unresolved":true,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"@privileged.default.entrypoint_with_timeout(timeout\u003d5)"},{"line_number":560,"context_line":"def get_link_devices(namespace, **kwargs):"},{"line_number":561,"context_line":"    \"\"\"List interfaces in a namespace"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    :return: (list) interfaces in a namespace"}],"source_content_type":"text/x-python","patch_set":9,"id":"76b55202_452b19c1","line":560,"range":{"start_line":560,"start_character":4,"end_line":560,"end_character":20},"in_reply_to":"340c10fb_ebac6ed5","updated":"2021-07-07 13:32:30.000000000","message":"To add default timeout to all privsep calls, hmmm, for that perhaps a new context should be used like default_w_timeout, and decorate the risky calls with that.\nBut sure I will push another one to see","commit_id":"dd9320bc8cfc943d0df25ebdfca84ccb548f4372"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6df9cfb2a1c4c7179b4d7035688ffb2b4e513324","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        return pyroute2.IPRoute()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@privileged.default.entrypoint(timeout\u003d5)"},{"line_number":153,"context_line":"def open_namespace(namespace):"},{"line_number":154,"context_line":"    \"\"\"Open namespace to test if the namespace is ready to be manipulated\"\"\""},{"line_number":155,"context_line":"    with pyroute2.NetNS(namespace, flags\u003d0):"}],"source_content_type":"text/x-python","patch_set":10,"id":"d3ad4512_85bb1342","line":152,"range":{"start_line":152,"start_character":1,"end_line":152,"end_character":30},"updated":"2021-07-07 14:08:58.000000000","message":"seems should be default.entrypoint_with_timeout","commit_id":"b4ea6b68a429c568350d32ae2882ccd9fbde456d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b119085fdc4c961ebda706a83444ca410ded938a","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        return pyroute2.IPRoute()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@privileged.default.entrypoint(timeout\u003d5)"},{"line_number":153,"context_line":"def open_namespace(namespace):"},{"line_number":154,"context_line":"    \"\"\"Open namespace to test if the namespace is ready to be manipulated\"\"\""},{"line_number":155,"context_line":"    with pyroute2.NetNS(namespace, flags\u003d0):"}],"source_content_type":"text/x-python","patch_set":10,"id":"8b2f2b0f_7f72418b","line":152,"range":{"start_line":152,"start_character":1,"end_line":152,"end_character":30},"in_reply_to":"d3ad4512_85bb1342","updated":"2021-07-08 14:37:54.000000000","message":"uhhhhhh......\nThis heat makes me deconcentrated...\n\nthanks","commit_id":"b4ea6b68a429c568350d32ae2882ccd9fbde456d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6df9cfb2a1c4c7179b4d7035688ffb2b4e513324","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    LOG.debug(\"Namespace %s deleted.\", name)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"@privileged.namespace_cmd.entrypoint(timeout\u003d5)"},{"line_number":528,"context_line":"def list_netns(**kwargs):"},{"line_number":529,"context_line":"    \"\"\"List network namespaces."},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8f98066b_6f216c21","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":47},"updated":"2021-07-07 14:08:58.000000000","message":"need to use entrypoint_with_timeout,\nhowever never seen this hanged, so probably not needed at this point","commit_id":"b4ea6b68a429c568350d32ae2882ccd9fbde456d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b119085fdc4c961ebda706a83444ca410ded938a","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    LOG.debug(\"Namespace %s deleted.\", name)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"@privileged.namespace_cmd.entrypoint(timeout\u003d5)"},{"line_number":528,"context_line":"def list_netns(**kwargs):"},{"line_number":529,"context_line":"    \"\"\"List network namespaces."},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4f477f5e_8dca17e8","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":47},"in_reply_to":"8f98066b_6f216c21","updated":"2021-07-08 14:37:54.000000000","message":"Right, let\u0027s see if open_namespace is enough with timeout","commit_id":"b4ea6b68a429c568350d32ae2882ccd9fbde456d"}]}