)]}'
{"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"160bd4a99ccefd34a2facb26953a3ff01df60a86","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                       \u0027or by checking the output of the following command: \\n\u0027"},{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027enable_ovn_idl_for_allservices_worker\u0027,"},{"line_number":201,"context_line":"                default\u003dFalse,"},{"line_number":202,"context_line":"                help\u003d_(\u0027Enable OVN IDLs for AllServicesNeutronWorker.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027By default on the API and maintenance workers \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3205954e_69d0a33d","line":200,"range":{"start_line":200,"start_character":17,"end_line":200,"end_character":54},"updated":"2021-06-10 14:02:53.000000000","message":"a suggestion: why not to add a single variable? By default, it will be an empty list. Users can add the class names there. Those class names could be defined in setup.cfg, as entry points.","commit_id":"32bb8717668779e78c7e7b7e8ecc9beea2ab5822"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"5f04b7892e8bb7a97f947df6b9e3515994c2c997","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                       \u0027or by checking the output of the following command: \\n\u0027"},{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027enable_ovn_idl_for_allservices_worker\u0027,"},{"line_number":201,"context_line":"                default\u003dFalse,"},{"line_number":202,"context_line":"                help\u003d_(\u0027Enable OVN IDLs for AllServicesNeutronWorker.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027By default on the API and maintenance workers \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd45eff3_0d9e44bd","line":200,"range":{"start_line":200,"start_character":17,"end_line":200,"end_character":54},"in_reply_to":"3205954e_69d0a33d","updated":"2021-06-10 15:35:43.000000000","message":"sounds good, I will change it","commit_id":"32bb8717668779e78c7e7b7e8ecc9beea2ab5822"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"94e7bdfe70840b834d5fc912b4fd4803fa390195","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.ListOpt(\u0027additional_worker_classes_with_ovn_idl\u0027,"},{"line_number":201,"context_line":"                default\u003d[],"},{"line_number":202,"context_line":"                help\u003d_(\u0027Additional worker classes to enable OVN IDLs for.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027By default only the API and maintenance workers \u0027"},{"line_number":204,"context_line":"                       \u0027have access to the IDL connections. List additional \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"d71a174f_cde15096","line":201,"updated":"2021-06-11 12:00:31.000000000","message":"Is there any room for making the default adaptable based on configurations known to require IDL in additional workers?\n\nI.e. if the sriovnicswitch mechanism driver is enabled we know that the RpcWorker needs the IDL.","commit_id":"9266299c0965f5e730df96328a3293edae60727a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"a563b468854e0ed2eaa169ff2e23e18c2d003b67","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.ListOpt(\u0027additional_worker_classes_with_ovn_idl\u0027,"},{"line_number":201,"context_line":"                default\u003d[],"},{"line_number":202,"context_line":"                help\u003d_(\u0027Additional worker classes to enable OVN IDLs for.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027By default only the API and maintenance workers \u0027"},{"line_number":204,"context_line":"                       \u0027have access to the IDL connections. List additional \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"8ae88ec6_66ad6f6a","line":201,"in_reply_to":"d13f5b6e_2d4b2ea4","updated":"2021-06-11 12:54:00.000000000","message":"Feel free, I\u0027d be happy to abandon mine so you can work that into your patch. That way we get a more complete solution that covers more of the use cases in one go.","commit_id":"9266299c0965f5e730df96328a3293edae60727a"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"90a95d6595616c90ed8c522b8889a6ac7af6fd3c","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.ListOpt(\u0027additional_worker_classes_with_ovn_idl\u0027,"},{"line_number":201,"context_line":"                default\u003d[],"},{"line_number":202,"context_line":"                help\u003d_(\u0027Additional worker classes to enable OVN IDLs for.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027By default only the API and maintenance workers \u0027"},{"line_number":204,"context_line":"                       \u0027have access to the IDL connections. List additional \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"d13f5b6e_2d4b2ea4","line":201,"in_reply_to":"d71a174f_cde15096","updated":"2021-06-11 12:47:41.000000000","message":"The default is basically implemented in should_post_fork_initialize.\nWe could combine our two patches: add RpcWorker to the defaults in should_post_fork_initialize in case of sriovnicswitch, as in your patch.\nThen maybe mention this in the config option description (adding RpcWorker to the config would be redundant in case of sriovnicswitch then).\nIf there are no objections I could extend my patch that way.","commit_id":"9266299c0965f5e730df96328a3293edae60727a"}]}