)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"06d884eede2b55c24a4c3f80993173faab6b1f44","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoid creating FixedIntervalLoopingCall in agent UT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set polling_interval to 0 to avoid creating LoopingCall"},{"line_number":10,"context_line":"in loadbalancer agent tests, dhcp agent tests, linuxbridge agent tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib6edbc11feba402a4c2f19b7d6833b49879ee626"},{"line_number":13,"context_line":"Closes-Bug: #1288079"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F%2F2kY%3D","line":10,"updated":"2014-03-13 11:13:06.000000000","message":"I see other agents\u0027 UTs use a mock for this. Should this method be applied to all of those for consistency?\n\nA quick grep shows these files:\nneutron/tests/unit/hyperv/test_hyperv_neutron_agent.py\nneutron/tests/unit/ibm/test_sdnve_agent.py\nneutron/tests/unit/mlnx/test_mlnx_neutron_agent.py\nneutron/tests/unit/nec/test_nec_agent.py\nneutron/tests/unit/ofagent/test_ofa_neutron_agent.py\nneutron/tests/unit/openvswitch/test_ovs_neutron_agent.py\nneutron/tests/unit/services/firewall/agents/varmour/test_varmour_router.py\nneutron/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py\nneutron/tests/unit/services/metering/test_metering_agent.py\nneutron/tests/unit/services/vpn/device_drivers/test_cisco_ipsec.py\nneutron/tests/unit/services/vpn/test_vpn_agent.py\nneutron/tests/unit/test_l3_agent.py\nneutron/tests/unit/test_metadata_agent.py","commit_id":"abc92811aa71e92cd93c3a762ab1af8255892776"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4731609619cfa5f676bb4ea55e4bc627ef58af60","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoid creating FixedIntervalLoopingCall in agent UT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set polling_interval to 0 to avoid creating LoopingCall"},{"line_number":10,"context_line":"in loadbalancer agent tests, dhcp agent tests, linuxbridge agent tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib6edbc11feba402a4c2f19b7d6833b49879ee626"},{"line_number":13,"context_line":"Closes-Bug: #1288079"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAWH%2F%2FBsI%3D","line":10,"in_reply_to":"AAAAWH%2F%2F2kY%3D","updated":"2014-03-20 20:29:10.000000000","message":"I have checked every file in that list, in every of them FixedIntervalLoopingCall is mocked in agent test setup","commit_id":"abc92811aa71e92cd93c3a762ab1af8255892776"}],"neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"beb172c4c4854b2cf2eccd6468146b25a107254d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        root_helper \u003d cfg.CONF.AGENT.root_helper"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # disable setting up repiodic state reporting"},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":56,"context_line":"        self.linux_bridge \u003d linuxbridge_neutron_agent.LinuxBridgeManager("},{"line_number":57,"context_line":"            interface_mappings, root_helper)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B4b0%3D","line":55,"updated":"2014-03-11 15:14:58.000000000","message":"This should be done in TestLinuxBridgeAgent below as looping call is created in LinuxBridgeNeutronAgentRPC class","commit_id":"40d973b5f8c6016009ad2b4c5273f2b0d308b3c9"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"29aca4e57c3583d994189a240ca41063dbef7460","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        root_helper \u003d cfg.CONF.AGENT.root_helper"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # disable setting up repiodic state reporting"},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":56,"context_line":"        self.linux_bridge \u003d linuxbridge_neutron_agent.LinuxBridgeManager("},{"line_number":57,"context_line":"            interface_mappings, root_helper)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Bw20%3D","line":55,"in_reply_to":"AAAAVn%2F%2B4b0%3D","updated":"2014-03-12 10:27:42.000000000","message":"right, that was a miss","commit_id":"40d973b5f8c6016009ad2b4c5273f2b0d308b3c9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"630338765d0e8d18c914d3bc1b54c3e064c0ac93","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def setUp(self):"},{"line_number":98,"context_line":"        super(TestLinuxBridgeAgent, self).setUp()"},{"line_number":99,"context_line":"        # disable setting up repiodic state reporting"},{"line_number":100,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":101,"context_line":"        cfg.CONF.set_override(\u0027rpc_backend\u0027,"},{"line_number":102,"context_line":"                              \u0027neutron.openstack.common.rpc.impl_fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAV3%2F%2F%2F7E%3D","line":99,"updated":"2014-03-12 12:19:22.000000000","message":"typo in periodic","commit_id":"a29c1fcfbb682f429a6d152cc6143b6f23b727fc"}],"neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"630338765d0e8d18c914d3bc1b54c3e064c0ac93","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027neutron.services.loadbalancer.agent.agent_api.LbaasAgentApi\u0027"},{"line_number":41,"context_line":"        ).start()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # disable setting up repiodic state reporting"},{"line_number":44,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.mgr \u003d manager.LbaasAgentManager(mock_conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAV3%2F%2F%2F7Q%3D","line":43,"updated":"2014-03-12 12:19:22.000000000","message":"ditto","commit_id":"a29c1fcfbb682f429a6d152cc6143b6f23b727fc"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aaef93043046e261a8b934c350e0f18371f4459a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.tests import base"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestManager(base.BaseTestCase):"},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestManager, self).setUp()"},{"line_number":32,"context_line":"        self.addCleanup(mock.patch.stopall)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F4MM%3D","line":29,"updated":"2014-03-13 07:36:23.000000000","message":"the test now fails when running separately: NoSuchGroupError: no such group: AGENT","commit_id":"9f4c9a0f4d874786ab1834c89e9ba5c4321efca6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aaef93043046e261a8b934c350e0f18371f4459a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        ).start()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # disable setting up periodic state reporting"},{"line_number":44,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.mgr \u003d manager.LbaasAgentManager(mock_conf)"},{"line_number":47,"context_line":"        self.rpc_mock \u003d rpc_mock_cls.return_value"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F4LM%3D","line":44,"updated":"2014-03-13 07:36:23.000000000","message":"I think report interval should be overriden in mock_conf as it is passed to the agent on init and it takes report interval from it rather from cfg.CONF","commit_id":"9f4c9a0f4d874786ab1834c89e9ba5c4321efca6"}],"neutron/tests/unit/test_dhcp_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"630338765d0e8d18c914d3bc1b54c3e064c0ac93","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        dhcp_agent.register_options()"},{"line_number":133,"context_line":"        cfg.CONF.set_override(\u0027interface_driver\u0027,"},{"line_number":134,"context_line":"                              \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":135,"context_line":"        # disable setting up repiodic state reporting"},{"line_number":136,"context_line":"        cfg.CONF.set_override(\u0027report_interval\u0027, 0, \u0027AGENT\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.driver_cls_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAV3%2F%2F%2F60%3D","line":135,"updated":"2014-03-12 12:19:22.000000000","message":"ditto","commit_id":"a29c1fcfbb682f429a6d152cc6143b6f23b727fc"}]}