)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47528dd1e3d4b46d410ecfd34f188bd57f391446","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            # TODO(boden): remove shim below once all events use payloads"},{"line_number":118,"context_line":"            if resource \u003d\u003d resources.SUBNET:"},{"line_number":119,"context_line":"                callback \u003d self._native_event_send_dhcp_notification_payload"},{"line_number":120,"context_line":"            if resource \u003d\u003d resources.NETWORK:"},{"line_number":121,"context_line":"                callback \u003d self._native_event_send_dhcp_notification_payload"},{"line_number":122,"context_line":"            if resource \u003d\u003d resources.PORT:"},{"line_number":123,"context_line":"                registry.subscribe("}],"source_content_type":"text/x-python","patch_set":5,"id":"3c70c657_30fe545b","line":120,"updated":"2021-06-22 07:52:09.000000000","message":"nit: You could do something like\n\n    if resource in [resource.NETWORK, resource.SUBNET]:\n        callback \u003d self._native_event_send_dhcp_notification_payload\n\ninstead of 2 \"ifs\"","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            # TODO(boden): remove shim below once all events use payloads"},{"line_number":118,"context_line":"            if resource \u003d\u003d resources.SUBNET:"},{"line_number":119,"context_line":"                callback \u003d self._native_event_send_dhcp_notification_payload"},{"line_number":120,"context_line":"            if resource \u003d\u003d resources.NETWORK:"},{"line_number":121,"context_line":"                callback \u003d self._native_event_send_dhcp_notification_payload"},{"line_number":122,"context_line":"            if resource \u003d\u003d resources.PORT:"},{"line_number":123,"context_line":"                registry.subscribe("}],"source_content_type":"text/x-python","patch_set":5,"id":"516486bf_b7772fcd","line":120,"in_reply_to":"3c70c657_30fe545b","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                    resources.SUBNET, events.AFTER_DELETE, self,"},{"line_number":505,"context_line":"                    payload\u003devents.DBEventPayload("},{"line_number":506,"context_line":"                        context,"},{"line_number":507,"context_line":"                        resource_id\u003did,"},{"line_number":508,"context_line":"                        metadata\u003d{\u0027for_net_delete\u0027: True},"},{"line_number":509,"context_line":"                        states\u003d(subnet.to_dict(),)))"},{"line_number":510,"context_line":"            with db_api.CONTEXT_WRITER.using(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"e89944a5_9bc0dbfa","line":507,"range":{"start_line":507,"start_character":24,"end_line":507,"end_character":38},"updated":"2021-06-22 07:54:17.000000000","message":"should be subnet id, not net id","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                    resources.SUBNET, events.AFTER_DELETE, self,"},{"line_number":505,"context_line":"                    payload\u003devents.DBEventPayload("},{"line_number":506,"context_line":"                        context,"},{"line_number":507,"context_line":"                        resource_id\u003did,"},{"line_number":508,"context_line":"                        metadata\u003d{\u0027for_net_delete\u0027: True},"},{"line_number":509,"context_line":"                        states\u003d(subnet.to_dict(),)))"},{"line_number":510,"context_line":"            with db_api.CONTEXT_WRITER.using(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"381ee4ed_69695851","line":507,"range":{"start_line":507,"start_character":24,"end_line":507,"end_character":38},"in_reply_to":"e89944a5_9bc0dbfa","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}],"neutron/db/l3_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":1927,"context_line":"    @staticmethod"},{"line_number":1928,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":1929,"context_line":"    def _notify_subnet_gateway_ip_update(resource, event, trigger,"},{"line_number":1930,"context_line":"                                         payload\u003dNone):"},{"line_number":1931,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":1932,"context_line":"        if not l3plugin:"},{"line_number":1933,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"b545c73d_e3b3a615","line":1930,"range":{"start_line":1930,"start_character":48,"end_line":1930,"end_character":53},"updated":"2021-06-22 07:54:17.000000000","message":"I guess payload is always there, so default None could be removed. Moreover you don\u0027t check for None in method body below.","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":1927,"context_line":"    @staticmethod"},{"line_number":1928,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":1929,"context_line":"    def _notify_subnet_gateway_ip_update(resource, event, trigger,"},{"line_number":1930,"context_line":"                                         payload\u003dNone):"},{"line_number":1931,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":1932,"context_line":"        if not l3plugin:"},{"line_number":1933,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"d91c958f_90bdd5f4","line":1930,"range":{"start_line":1930,"start_character":48,"end_line":1930,"end_character":53},"in_reply_to":"b545c73d_e3b3a615","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_DELETE])"},{"line_number":1371,"context_line":"    def _subnet_delete_after_delete_handler(self, rtype, event, trigger,"},{"line_number":1372,"context_line":"                                            payload\u003dNone):"},{"line_number":1373,"context_line":"        context \u003d payload.context"},{"line_number":1374,"context_line":"        try:"},{"line_number":1375,"context_line":"            self.mechanism_manager.delete_subnet_postcommit("}],"source_content_type":"text/x-python","patch_set":5,"id":"2d05f537_a0abb36a","line":1372,"range":{"start_line":1372,"start_character":51,"end_line":1372,"end_character":56},"updated":"2021-06-22 07:54:17.000000000","message":"default not needed","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_DELETE])"},{"line_number":1371,"context_line":"    def _subnet_delete_after_delete_handler(self, rtype, event, trigger,"},{"line_number":1372,"context_line":"                                            payload\u003dNone):"},{"line_number":1373,"context_line":"        context \u003d payload.context"},{"line_number":1374,"context_line":"        try:"},{"line_number":1375,"context_line":"            self.mechanism_manager.delete_subnet_postcommit("}],"source_content_type":"text/x-python","patch_set":5,"id":"011b042f_2c61c38c","line":1372,"range":{"start_line":1372,"start_character":51,"end_line":1372,"end_character":56},"in_reply_to":"2d05f537_a0abb36a","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}],"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    @staticmethod"},{"line_number":441,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":442,"context_line":"    def _subnet_update(resource, event, trigger, payload\u003dNone):"},{"line_number":443,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":444,"context_line":"        if not l3plugin:"},{"line_number":445,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5dd4fac0_c24e611a","line":442,"range":{"start_line":442,"start_character":56,"end_line":442,"end_character":61},"updated":"2021-06-22 07:54:17.000000000","message":"ditto","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    @staticmethod"},{"line_number":441,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":442,"context_line":"    def _subnet_update(resource, event, trigger, payload\u003dNone):"},{"line_number":443,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":444,"context_line":"        if not l3plugin:"},{"line_number":445,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f7c15aa_edd8ce73","line":442,"range":{"start_line":442,"start_character":56,"end_line":442,"end_character":61},"in_reply_to":"5dd4fac0_c24e611a","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}],"neutron/services/segments/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                segment_host_mappings\u003dsegment_host_mappings))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_CREATE])"},{"line_number":228,"context_line":"    def _notify_subnet_created(self, resource, event, trigger, payload\u003dNone):"},{"line_number":229,"context_line":"        context \u003d payload.context"},{"line_number":230,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":231,"context_line":"        segment_id \u003d subnet.get(\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"37789153_f60a10c0","line":228,"range":{"start_line":228,"start_character":70,"end_line":228,"end_character":75},"updated":"2021-06-22 07:54:17.000000000","message":"ditto","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                segment_host_mappings\u003dsegment_host_mappings))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_CREATE])"},{"line_number":228,"context_line":"    def _notify_subnet_created(self, resource, event, trigger, payload\u003dNone):"},{"line_number":229,"context_line":"        context \u003d payload.context"},{"line_number":230,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":231,"context_line":"        segment_id \u003d subnet.get(\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"79e8abc3_13530388","line":228,"range":{"start_line":228,"start_character":70,"end_line":228,"end_character":75},"in_reply_to":"37789153_f60a10c0","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":308,"context_line":"    def _notify_subnet_updated(self, resource, event, trigger,"},{"line_number":309,"context_line":"                               payload\u003dNone):"},{"line_number":310,"context_line":"        context \u003d payload.context"},{"line_number":311,"context_line":"        original_subnet \u003d payload.states[0]"},{"line_number":312,"context_line":"        subnet \u003d payload.latest_state"}],"source_content_type":"text/x-python","patch_set":5,"id":"d7e19f64_0141b5dd","line":309,"range":{"start_line":309,"start_character":38,"end_line":309,"end_character":43},"updated":"2021-06-22 07:54:17.000000000","message":"ditto","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_UPDATE])"},{"line_number":308,"context_line":"    def _notify_subnet_updated(self, resource, event, trigger,"},{"line_number":309,"context_line":"                               payload\u003dNone):"},{"line_number":310,"context_line":"        context \u003d payload.context"},{"line_number":311,"context_line":"        original_subnet \u003d payload.states[0]"},{"line_number":312,"context_line":"        subnet \u003d payload.latest_state"}],"source_content_type":"text/x-python","patch_set":5,"id":"cf565838_95e6cc86","line":309,"range":{"start_line":309,"start_character":38,"end_line":309,"end_character":43},"in_reply_to":"d7e19f64_0141b5dd","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":345,"context_line":"                segment_host_mappings\u003dsegment_host_mappings))"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_DELETE])"},{"line_number":348,"context_line":"    def _notify_subnet_deleted(self, resource, event, trigger, payload\u003dNone):"},{"line_number":349,"context_line":"        context \u003d payload.context"},{"line_number":350,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":351,"context_line":"        if payload.metadata.get(db.FOR_NET_DELETE):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1bcc4ad9_c5c72006","line":348,"range":{"start_line":348,"start_character":70,"end_line":348,"end_character":75},"updated":"2021-06-22 07:54:17.000000000","message":"ditto","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":345,"context_line":"                segment_host_mappings\u003dsegment_host_mappings))"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @registry.receives(resources.SUBNET, [events.AFTER_DELETE])"},{"line_number":348,"context_line":"    def _notify_subnet_deleted(self, resource, event, trigger, payload\u003dNone):"},{"line_number":349,"context_line":"        context \u003d payload.context"},{"line_number":350,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":351,"context_line":"        if payload.metadata.get(db.FOR_NET_DELETE):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f0a96d8_276b2725","line":348,"range":{"start_line":348,"start_character":70,"end_line":348,"end_character":75},"in_reply_to":"1bcc4ad9_c5c72006","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c6d41ceeacf7f5391de7ee6e2ba0645435397719","unresolved":true,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    @registry.receives(resources.SUBNET, [events.BEFORE_CREATE])"},{"line_number":621,"context_line":"    def host_routes_before_create(self, resource, event, trigger,"},{"line_number":622,"context_line":"                                  payload\u003dNone):"},{"line_number":623,"context_line":"        context \u003d payload.context"},{"line_number":624,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":625,"context_line":"        segment_id \u003d subnet.get(\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6086c32e_0b37d421","line":622,"range":{"start_line":622,"start_character":41,"end_line":622,"end_character":46},"updated":"2021-06-22 07:54:17.000000000","message":"ditto and below","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"2a8a986f2344c8ec7ec9da50348fc18bb6ca1c23","unresolved":true,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    @registry.receives(resources.SUBNET, [events.BEFORE_CREATE])"},{"line_number":621,"context_line":"    def host_routes_before_create(self, resource, event, trigger,"},{"line_number":622,"context_line":"                                  payload\u003dNone):"},{"line_number":623,"context_line":"        context \u003d payload.context"},{"line_number":624,"context_line":"        subnet \u003d payload.latest_state"},{"line_number":625,"context_line":"        segment_id \u003d subnet.get(\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b082c8ce_6ff56a77","line":622,"range":{"start_line":622,"start_character":41,"end_line":622,"end_character":46},"in_reply_to":"6086c32e_0b37d421","updated":"2021-06-22 08:30:42.000000000","message":"Done","commit_id":"e053c94684117bd75e3d4d733a57aea22eedc22a"}]}