)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c8fef466fa0b929f8ac19f1afab061c7ded740c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f48242d8_1c224337","updated":"2021-11-05 08:21:03.000000000","message":"Block due to the movement vacillating.","commit_id":"9e121733e6225795792ee576dd6d0d49ac23dbcf"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0f117965d6ee9b64548f17e8e0037f6b76046e1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9bd5af26_b18935c7","in_reply_to":"f48242d8_1c224337","updated":"2021-11-15 17:02:15.000000000","message":"Please check the neutron-meeting log where we discussed this topic last time:\nhttps://meetings.opendev.org/meetings/networking/2021/networking.2021-11-09-14.00.log.html#l-83","commit_id":"9e121733e6225795792ee576dd6d0d49ac23dbcf"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73f180b447c42385eed1d640cceaae38d6df1bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a11fc776_9627075d","updated":"2022-07-01 09:38:40.000000000","message":"You have to rebase on top of https://review.opendev.org/c/openstack/neutron/+/847989 till rally job is broken","commit_id":"8eb58d78293b95907018d5c99ea72ab1f68c9ee3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"588ed881278ae98e379e9c9f5689bc52d8acb272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"08371623_ac5289ba","updated":"2022-06-27 14:59:40.000000000","message":"recheck - error while deploying rally and some issue in the nova-api","commit_id":"8eb58d78293b95907018d5c99ea72ab1f68c9ee3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7845a8b845a90aa26df4942e834d83d382dde617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b4dfa3b9_6c13b26d","updated":"2022-06-27 08:18:51.000000000","message":"recheck - unrelated ovn and trunk tests failures","commit_id":"8eb58d78293b95907018d5c99ea72ab1f68c9ee3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9326d3e329ad8d979a41e3dcbddd444d3a607d6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"aa2d576e_bfd35a0a","updated":"2022-06-22 04:53:09.000000000","message":"recheck test_live_migration_with_trunk failure","commit_id":"8eb58d78293b95907018d5c99ea72ab1f68c9ee3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"39cc9a9863c5631b1c6918311f3cee98d808eb27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"55c7c553_a5e183e5","updated":"2022-07-07 06:31:58.000000000","message":"recheck docs issue fixed","commit_id":"36631806ae4986f3e3265d95ffab30f81b894a26"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7b310c8888aa6fb3ad90ebab0fad15766f4b5ada","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"fe7c157e_0ba99fd2","updated":"2022-08-02 09:42:01.000000000","message":"BTW, a release note to indicate that developers should now refer to neutron_lib, would have made sense?","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c6ea834b234c1a2c733e6323e142d25d43a5eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"397a14ed_87c1972e","updated":"2022-08-05 14:59:39.000000000","message":"We need to clean usage first https://codesearch.opendev.org/?q\u003dopenvswitch.agent.common%20import%20constants\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d710712b0ba3b620c5f18342ca186cc05a74e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6bc5bf6e_c37a9cf6","updated":"2022-08-09 11:18:04.000000000","message":"fwaas patch merged, I think we are OK now.","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9cc3d89241df6eae9d381fd25506ca62a785c6dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4a3419c1_27bfad99","in_reply_to":"397a14ed_87c1972e","updated":"2022-08-05 15:02:04.000000000","message":"Right, fwaas should be updated first.","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c6b7086fd87684ec725b8698f790f8fec0dfe330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4887c680_cd2df85e","in_reply_to":"4a3419c1_27bfad99","updated":"2022-08-09 06:04:48.000000000","message":"Pushed https://review.opendev.org/c/openstack/neutron-fwaas/+/852510 , vspehere looks inactive since years.","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c6ea834b234c1a2c733e6323e142d25d43a5eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"45fd8728_64e6da17","in_reply_to":"fe7c157e_0ba99fd2","updated":"2022-08-05 14:59:39.000000000","message":"I doubt if we need that in this case, others may confirm","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e7c19eff73b5dbf520f60f3759260938aa620fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0b3662e3_c6b176c2","in_reply_to":"fe7c157e_0ba99fd2","updated":"2022-08-05 14:58:57.000000000","message":"Not really, developers can check where those constants are located checking other occurrences in the code.\n\nThe reno should have been done in the n-lib patch, as we usually do (I would need to check if that reno was added).","commit_id":"d82647215cb47216c0e01aace7d7248a06c880d7"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f5e6f95ce1b2940ce09c7d89e740da219df9d851","unresolved":true,"context_lines":[{"line_number":87,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":88,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"INT_BR_ALL_TABLES \u003d ("},{"line_number":91,"context_line":"    LOCAL_SWITCHING,"},{"line_number":92,"context_line":"    DVR_TO_SRC_MAC,"},{"line_number":93,"context_line":"    DVR_TO_SRC_MAC_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b8b68ae7_da203d45","side":"PARENT","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":21},"updated":"2021-09-03 00:53:04.000000000","message":"If new table is going to be added to br-int, how to do with neutron-lib? Add new table to neutorn-lib, wait for neutron-lib to release? Or add this list back to Neutron with a TODO note? Like I said  [1], this is another barrier for ml2 OVS deplopment. So for this list here, I\u0027d perfer to leave it here.\n\n[1] https://review.opendev.org/c/openstack/neutron-lib/+/804613","commit_id":"8a8e49b42a0d3672ed7c10d93452be054cf24bd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"35beebcbbfd57aaa9e0a1804fb0906fa5546bdfd","unresolved":true,"context_lines":[{"line_number":87,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":88,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"INT_BR_ALL_TABLES \u003d ("},{"line_number":91,"context_line":"    LOCAL_SWITCHING,"},{"line_number":92,"context_line":"    DVR_TO_SRC_MAC,"},{"line_number":93,"context_line":"    DVR_TO_SRC_MAC_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d0c360cc_33930f27","side":"PARENT","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":21},"in_reply_to":"13684a2b_f8419d63","updated":"2021-09-07 08:59:48.000000000","message":"Some comments from https://review.opendev.org/c/openstack/neutron-lib/+/804613:\n\n\n1. Since the qos \"VALID_RULE_TYPES\" is moved to neutron-lib, we have done some extra works:\n\n  a. copy the new list back, do the Neutron only development works [1].\n  b. move the list back to neutron-lib [2]\n  c. waiting for neutron-lib to have a new release [3]\n  d. update neutron to use constants from neutron-lib  [4]\n2. They are going to move the \"*_BR_ALL_TABLES\" to neutron-lib [5], and doing the same work of rotating Neutron [6]. For these tables, at least two WIP features will have works on these tables [7][8]. So, let them copy these list back to neutron again? Then add a TODO note? It wastes not only developer time, but also code reviewers bandwidth.\nAgain, since big tent projects are almost retired. If there are constants really needed by sub-projects, it is fine to move those to neutron-lib. Otherwise, leave Neutron used ONLY constants to neutron.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/796363/15/neutron/services/qos/constants.py\n[2] https://review.opendev.org/c/openstack/neutron-lib/+/804378\n[3] https://review.opendev.org/c/openstack/neutron/+/803462\n[4] https://review.opendev.org/c/openstack/neutron/+/804380\n[5] https://review.opendev.org/c/openstack/neutron/+/797121/8/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#b1\n[6] https://review.opendev.org/c/openstack/neutron/+/797120/\n[7] https://review.opendev.org/c/openstack/neutron-specs/+/797798/12/specs/xena/node-local-ip.rst@259\n[8] https://review.opendev.org/c/openstack/neutron/+/804213","commit_id":"8a8e49b42a0d3672ed7c10d93452be054cf24bd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c09650e8922751840d3a99b573d6c2cda79a9a89","unresolved":true,"context_lines":[{"line_number":87,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":88,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"INT_BR_ALL_TABLES \u003d ("},{"line_number":91,"context_line":"    LOCAL_SWITCHING,"},{"line_number":92,"context_line":"    DVR_TO_SRC_MAC,"},{"line_number":93,"context_line":"    DVR_TO_SRC_MAC_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ef0ee9df_67f5d68e","side":"PARENT","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":21},"in_reply_to":"b8b68ae7_da203d45","updated":"2021-09-03 02:41:46.000000000","message":"Keeping the list to neutron, neutron-lib is going to remove this list:\nhttps://review.opendev.org/c/openstack/neutron-lib/+/807224","commit_id":"8a8e49b42a0d3672ed7c10d93452be054cf24bd6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67ddc724bca02b2bf2ff8b44fc87093df6c076f0","unresolved":true,"context_lines":[{"line_number":87,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":88,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"INT_BR_ALL_TABLES \u003d ("},{"line_number":91,"context_line":"    LOCAL_SWITCHING,"},{"line_number":92,"context_line":"    DVR_TO_SRC_MAC,"},{"line_number":93,"context_line":"    DVR_TO_SRC_MAC_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"13684a2b_f8419d63","side":"PARENT","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":21},"in_reply_to":"ef0ee9df_67f5d68e","updated":"2021-09-07 07:51:56.000000000","message":"I will repeat my reply from other patch also here: I don\u0027t agree with that point. IMO those constants should be in neutron-lib as they can be used by other projects as well. And also e.g. stadium projects may introduce new constants for own tables there thus having all in single place (similar like api-def) will help to keep it sane. See e.g. BAGPIPE_FLOOD_TO_TUN_BROADCAST constant - this is perfect example of such additional table used by stadium project which is added to that list. And currently to keep this value only for this project it has to be added to neutron so networking-bagpipe project will have to depend on neutron to use it. And our goal should be to reduce such dependencies on neutron for stadium projects and keep them dependent on neutron-lib.\nSo IMO all those constants (especially those which defines tables) should go to neutron-lib.\n\nAnd yes - if we will need to add new table, we should add it to neutron-lib. That way we can be sure that same value isn\u0027t already used e.g. by some other stadium project as all values will be in the same place always.\nAnd doing new neutron-lib release isn\u0027t big problem. We can do it whenever we want. If You need new release, please just propose patch to releases repo or ping someone on IRC channel 😊","commit_id":"8a8e49b42a0d3672ed7c10d93452be054cf24bd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f5e6f95ce1b2940ce09c7d89e740da219df9d851","unresolved":true,"context_lines":[{"line_number":126,"context_line":"# mirror traffic to EVPN and standard tunnels to gateway nodes"},{"line_number":127,"context_line":"BAGPIPE_FLOOD_TO_TUN_BROADCAST \u003d 222"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"TUN_BR_ALL_TABLES \u003d ("},{"line_number":130,"context_line":"    LOCAL_SWITCHING,"},{"line_number":131,"context_line":"    DVR_PROCESS,"},{"line_number":132,"context_line":"    PATCH_LV_TO_TUN,"}],"source_content_type":"text/x-python","patch_set":8,"id":"216ac117_a22d415c","side":"PARENT","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":21},"updated":"2021-09-03 00:53:04.000000000","message":"ditto","commit_id":"8a8e49b42a0d3672ed7c10d93452be054cf24bd6"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"7633f7f07ac4107673b7f767b2635efc359a17cb","unresolved":true,"context_lines":[{"line_number":73,"context_line":"BASE_INGRESS_TABLE \u003d 81"},{"line_number":74,"context_line":"RULES_INGRESS_TABLE \u003d 82"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"OVS_FIREWALL_TABLES \u003d ("},{"line_number":77,"context_line":"    BASE_EGRESS_TABLE,"},{"line_number":78,"context_line":"    RULES_EGRESS_TABLE,"},{"line_number":79,"context_line":"    ACCEPT_OR_INGRESS_TABLE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"a2b36e64_b27ca10d","side":"PARENT","line":76,"updated":"2021-09-08 11:15:10.000000000","message":"In networking-ovs-dpdk [1]  still using constants list from neutron. But I\u0027m not sure is this stadium project active\n1) https://opendev.org/x/networking-ovs-dpdk/src/branch/master/networking_ovs_dpdk/agent/ovs_dpdk_firewall.py#L26","commit_id":"01f036e0ba613ad5d4dc63e2333614b4cecea782"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6070df8794abb77d131ee7479330a56c6d525e23","unresolved":true,"context_lines":[{"line_number":73,"context_line":"BASE_INGRESS_TABLE \u003d 81"},{"line_number":74,"context_line":"RULES_INGRESS_TABLE \u003d 82"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"OVS_FIREWALL_TABLES \u003d ("},{"line_number":77,"context_line":"    BASE_EGRESS_TABLE,"},{"line_number":78,"context_line":"    RULES_EGRESS_TABLE,"},{"line_number":79,"context_line":"    ACCEPT_OR_INGRESS_TABLE,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fdd753ee_9cec632e","side":"PARENT","line":76,"in_reply_to":"a2b36e64_b27ca10d","updated":"2021-09-08 14:24:31.000000000","message":"Thanks for checking it, by gerrit not really: https://review.opendev.org/q/project:x/networking-ovs-dpdk","commit_id":"01f036e0ba613ad5d4dc63e2333614b4cecea782"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"35beebcbbfd57aaa9e0a1804fb0906fa5546bdfd","unresolved":true,"context_lines":[{"line_number":87,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":88,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"INT_BR_ALL_TABLES \u003d ("},{"line_number":91,"context_line":"    LOCAL_SWITCHING,"},{"line_number":92,"context_line":"    DVR_TO_SRC_MAC,"},{"line_number":93,"context_line":"    DVR_TO_SRC_MAC_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":9,"id":"730fb687_0a6aa309","side":"PARENT","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":21},"updated":"2021-09-07 08:59:48.000000000","message":"This *_ALL_LIST are for neutron only. Any projects want similar list, construct it in their own place. Since, this list is used for neutron to clean stale flows during restart.","commit_id":"01f036e0ba613ad5d4dc63e2333614b4cecea782"}]}