)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5684b2b6817d775430a8186a1459ee15825eec1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix in admin_state_up check function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  * Added a unit test"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If221cf5546e6432b31dd11ec322ddd4b69d161b2"},{"line_number":12,"context_line":"Closes-Bug: #1291103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2F3Uw%3D","line":9,"updated":"2014-03-13 09:48:09.000000000","message":"nit: this  comment isn\u0027t very helpful. It would be better to write here what this patch changes/fixes.","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"9795cb023c06c6742eb1eec97d0f040c15470d7a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix in admin_state_up check function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  * Added a unit test"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If221cf5546e6432b31dd11ec322ddd4b69d161b2"},{"line_number":12,"context_line":"Closes-Bug: #1291103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2F2Bc%3D","line":9,"in_reply_to":"AAAAWH%2F%2F3Uw%3D","updated":"2014-03-13 12:36:52.000000000","message":"Sure.","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9da1867dece090b0c5aebaf69c950bee2343a52e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If221cf5546e6432b31dd11ec322ddd4b69d161b2"},{"line_number":10,"context_line":"Closes-Bug: #1291103"},{"line_number":11,"context_line":"Signed-off-by: Fawad Khaliq \u003cfawad@plumgrid.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAWH%2F%2FqIc%3D","line":11,"updated":"2014-03-14 17:11:57.000000000","message":"FYI... this is not required for OpenStack","commit_id":"7360e67d32dbd8c98ef59c46bf0c7fff16f48d0c"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3986e5f2304fcdde4049ad02fb79d517d096aefe","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If221cf5546e6432b31dd11ec322ddd4b69d161b2"},{"line_number":10,"context_line":"Closes-Bug: #1291103"},{"line_number":11,"context_line":"Signed-off-by: Fawad Khaliq \u003cfawad@plumgrid.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAWH%2F%2FqHY%3D","line":11,"in_reply_to":"AAAAWH%2F%2FqIc%3D","updated":"2014-03-14 17:14:51.000000000","message":"Thanks for pointing it out. I will take care of it from next time.","commit_id":"7360e67d32dbd8c98ef59c46bf0c7fff16f48d0c"}],"neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"4a544839ec8411f35f228b7f5a3b32cfe2366aa9","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def _network_admin_state(self, network):"},{"line_number":556,"context_line":"        try:"},{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\"):"},{"line_number":558,"context_line":"                if network[\"network\"][\"admin_state_up\"] is False:"},{"line_number":559,"context_line":"                    LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":560,"context_line":"                                \"supported by PLUMgrid plugin yet.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Bzh4%3D","line":557,"updated":"2014-03-12 02:17:10.000000000","message":"Don\u0027t need two lines to verify this, remove 558 and modify 557 to:\n\nif network[\"network\"].get(\"admin_state_up\") is False:","commit_id":"2ffe754d3eb8c8fae8312f59ee5a4fc807a23b40"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"6a52c294435481b0b592d1c268db4c9030f074ac","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def _network_admin_state(self, network):"},{"line_number":556,"context_line":"        try:"},{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\"):"},{"line_number":558,"context_line":"                if network[\"network\"][\"admin_state_up\"] is False:"},{"line_number":559,"context_line":"                    LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":560,"context_line":"                                \"supported by PLUMgrid plugin yet.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2BynU%3D","line":557,"in_reply_to":"AAAAVn%2F%2Bzh4%3D","updated":"2014-03-12 06:00:19.000000000","message":"Done","commit_id":"2ffe754d3eb8c8fae8312f59ee5a4fc807a23b40"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e9f9263175121ec9f42d555e6dd9dc598b6de3bd","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\") is False:"},{"line_number":558,"context_line":"                LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":559,"context_line":"                            \"supported by PLUMgrid plugin yet.\")"},{"line_number":560,"context_line":"        except Exception:"},{"line_number":561,"context_line":"            err_message \u003d _(\"Network Admin State Validation Failed: \")"},{"line_number":562,"context_line":"            raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":563,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2ByVQ%3D","line":560,"updated":"2014-03-12 06:25:33.000000000","message":"This exception here can also be removed or perhaps scoped to KeyError","commit_id":"3f53c786a4910b7ad5d9f5b26aa8abc38a88cec1"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"ccc6772271820ebc4043e564f420db8be14a8c2f","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\") is False:"},{"line_number":558,"context_line":"                LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":559,"context_line":"                            \"supported by PLUMgrid plugin yet.\")"},{"line_number":560,"context_line":"        except Exception:"},{"line_number":561,"context_line":"            err_message \u003d _(\"Network Admin State Validation Failed: \")"},{"line_number":562,"context_line":"            raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":563,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F6jE%3D","line":560,"in_reply_to":"AAAAVn%2F%2ByVQ%3D","updated":"2014-03-13 00:03:11.000000000","message":"Changing the scope is a good suggestion. Its coming in the next patch.","commit_id":"3f53c786a4910b7ad5d9f5b26aa8abc38a88cec1"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"91d2c911234158cae20948dd9862dcdac89a37a3","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\") is False:"},{"line_number":558,"context_line":"                LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":559,"context_line":"                            \"supported by PLUMgrid plugin yet.\")"},{"line_number":560,"context_line":"        except KeyError:"},{"line_number":561,"context_line":"            err_message \u003d _(\"Network Admin State Validation Failed\")"},{"line_number":562,"context_line":"            raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":563,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F5OM%3D","line":560,"updated":"2014-03-13 04:40:36.000000000","message":"Not sure you would ever hit this KeyError.","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"9795cb023c06c6742eb1eec97d0f040c15470d7a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\") is False:"},{"line_number":558,"context_line":"                LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":559,"context_line":"                            \"supported by PLUMgrid plugin yet.\")"},{"line_number":560,"context_line":"        except KeyError:"},{"line_number":561,"context_line":"            err_message \u003d _(\"Network Admin State Validation Failed\")"},{"line_number":562,"context_line":"            raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":563,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F2Bo%3D","line":560,"in_reply_to":"AAAAWH%2F%2F3XY%3D","updated":"2014-03-13 12:36:52.000000000","message":"Yes, I agree.","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5684b2b6817d775430a8186a1459ee15825eec1c","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            if network[\"network\"].get(\"admin_state_up\") is False:"},{"line_number":558,"context_line":"                LOG.warning(\"Networks with admin_state_up\u003dFalse are not \""},{"line_number":559,"context_line":"                            \"supported by PLUMgrid plugin yet.\")"},{"line_number":560,"context_line":"        except KeyError:"},{"line_number":561,"context_line":"            err_message \u003d _(\"Network Admin State Validation Failed\")"},{"line_number":562,"context_line":"            raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":563,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F3XY%3D","line":560,"in_reply_to":"AAAAWH%2F%2F5OM%3D","updated":"2014-03-13 09:48:09.000000000","message":"If network[\u0027network\u0027] was a key error things would be very wrong, this exception handling isn\u0027t really needed.","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"}],"neutron/tests/unit/plumgrid/test_plumgrid_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5684b2b6817d775430a8186a1459ee15825eec1c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        plugin \u003d NeutronManager.get_plugin()"},{"line_number":115,"context_line":"        self.assertEqual(plugin._network_admin_state(network), network)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_network_admin_state_without_net_name(self):"},{"line_number":118,"context_line":"        admin_status_up \u003d False"},{"line_number":119,"context_line":"        tenant_id \u003d \u0027tenant_test\u0027"},{"line_number":120,"context_line":"        network \u003d {\u0027network\u0027: {\u0027admin_state_up\u0027: admin_status_up,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F3TM%3D","line":117,"updated":"2014-03-13 09:48:09.000000000","message":"I understand that previously, if you called this test with the unchanged plugin code you would fail with a keyerror on network[\u0027network\u0027][\u0027name\u0027]. Now you\u0027ve removed that code so it won\u0027t happen now. I\u0027m not sure why you are trying to test in this test...","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"9795cb023c06c6742eb1eec97d0f040c15470d7a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        plugin \u003d NeutronManager.get_plugin()"},{"line_number":115,"context_line":"        self.assertEqual(plugin._network_admin_state(network), network)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_network_admin_state_without_net_name(self):"},{"line_number":118,"context_line":"        admin_status_up \u003d False"},{"line_number":119,"context_line":"        tenant_id \u003d \u0027tenant_test\u0027"},{"line_number":120,"context_line":"        network \u003d {\u0027network\u0027: {\u0027admin_state_up\u0027: admin_status_up,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F2AM%3D","line":117,"in_reply_to":"AAAAWH%2F%2F3TM%3D","updated":"2014-03-13 12:36:52.000000000","message":"On a second thought, I think you concern is valid. This is only testing what is already covered by an existing test case, so this should go away :)","commit_id":"947664d3bd1e03b102b73949335a332759feb6da"}]}