)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cd0e4dcc92b8e560b4791b3d8d8c892dc0e5a00f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"consumers and a request from an agent is handled by one of"},{"line_number":11,"context_line":"them randomly. Fortunatly most of RPC callbacks are common"},{"line_number":12,"context_line":"for plugins but a problem occurs if an RPC is not supported"},{"line_number":13,"context_line":"by the recieved plugin."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This is one of risks when using metaplugin. Fundamental fix"},{"line_number":16,"context_line":"of this problem is difficult. But if one of plugin can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FQt4%3D","line":13,"updated":"2014-03-19 02:33:33.000000000","message":"-\u003e received","commit_id":"9da9d05b1d49e342a54d9d4f385710c32bda41f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cd0e4dcc92b8e560b4791b3d8d8c892dc0e5a00f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"selected for RPC handling, the problem does not happen for"},{"line_number":18,"context_line":"many environment."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch adds \u0027rcp_flavor\u0027 configuration parameter to"},{"line_number":21,"context_line":"select an RPC handling plugin. If \u0027rpc_flavor\u0027 is specified,"},{"line_number":22,"context_line":"only the specified plugin becomes \u0027q-plugin\u0027 topic consumer."},{"line_number":23,"context_line":"If \u0027rpc_flavor\u0027 is not specified, the behavior is same as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FQt8%3D","line":20,"updated":"2014-03-19 02:33:33.000000000","message":"rcp -\u003e rpc","commit_id":"9da9d05b1d49e342a54d9d4f385710c32bda41f6"}],"neutron/plugins/metaplugin/meta_neutron_plugin.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d93c5bedfcf787759d9b26e2785e0c55b8b93000","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        plugin_list \u003d [plugin_set.split(\u0027:\u0027)"},{"line_number":95,"context_line":"                       for plugin_set"},{"line_number":96,"context_line":"                       in cfg.CONF.META.plugin_list.split(\u0027,\u0027)]"},{"line_number":97,"context_line":"        rpc_flavor \u003d cfg.CONF.META.rpc_flavor"},{"line_number":98,"context_line":"        topic_save \u003d topics.PLUGIN"},{"line_number":99,"context_line":"        topic_fake \u003d topic_save + \u0027-fake\u0027"},{"line_number":100,"context_line":"        for flavor, plugin_provider in plugin_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6zY%3D","line":97,"updated":"2014-03-12 23:16:23.000000000","message":"For backward compatibly, we should check this rpc_flavor existes or not. \nWe should provide some default value if it isn\u0027t exists","commit_id":"605348ca2947994d076c76f1d1411e7f6ebd43bd"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8e17a5292b9dcb107608a29778d189ebd02cfd85","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        plugin_list \u003d [plugin_set.split(\u0027:\u0027)"},{"line_number":95,"context_line":"                       for plugin_set"},{"line_number":96,"context_line":"                       in cfg.CONF.META.plugin_list.split(\u0027,\u0027)]"},{"line_number":97,"context_line":"        rpc_flavor \u003d cfg.CONF.META.rpc_flavor"},{"line_number":98,"context_line":"        topic_save \u003d topics.PLUGIN"},{"line_number":99,"context_line":"        topic_fake \u003d topic_save + \u0027-fake\u0027"},{"line_number":100,"context_line":"        for flavor, plugin_provider in plugin_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6t8%3D","line":97,"in_reply_to":"AAAAWH%2F%2F6zY%3D","updated":"2014-03-12 23:38:10.000000000","message":"default value of cfg.CONF.META.rpc_flavor is defined blank in  common/config.py.\nI think if rpc_flavor does not exist in metaplugin.ini it is set to blank and the code keep backward compatibility isn\u0027t it ?","commit_id":"605348ca2947994d076c76f1d1411e7f6ebd43bd"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d93c5bedfcf787759d9b26e2785e0c55b8b93000","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       in cfg.CONF.META.plugin_list.split(\u0027,\u0027)]"},{"line_number":97,"context_line":"        rpc_flavor \u003d cfg.CONF.META.rpc_flavor"},{"line_number":98,"context_line":"        topic_save \u003d topics.PLUGIN"},{"line_number":99,"context_line":"        topic_fake \u003d topic_save + \u0027-fake\u0027"},{"line_number":100,"context_line":"        for flavor, plugin_provider in plugin_list:"},{"line_number":101,"context_line":"            # Rename topic used by a plugin other than rpc_flavor during"},{"line_number":102,"context_line":"            # loading the plugin instance if rpc_flavor is specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6zo%3D","line":99,"updated":"2014-03-12 23:16:23.000000000","message":"nit: i prefer \u0027-metaplugin\u0027.\nPersonally, \u0027fake\u0027 sounds more test data\nand we should show who rewrite the topic","commit_id":"605348ca2947994d076c76f1d1411e7f6ebd43bd"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8e17a5292b9dcb107608a29778d189ebd02cfd85","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       in cfg.CONF.META.plugin_list.split(\u0027,\u0027)]"},{"line_number":97,"context_line":"        rpc_flavor \u003d cfg.CONF.META.rpc_flavor"},{"line_number":98,"context_line":"        topic_save \u003d topics.PLUGIN"},{"line_number":99,"context_line":"        topic_fake \u003d topic_save + \u0027-fake\u0027"},{"line_number":100,"context_line":"        for flavor, plugin_provider in plugin_list:"},{"line_number":101,"context_line":"            # Rename topic used by a plugin other than rpc_flavor during"},{"line_number":102,"context_line":"            # loading the plugin instance if rpc_flavor is specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F6us%3D","line":99,"in_reply_to":"AAAAWH%2F%2F6zo%3D","updated":"2014-03-12 23:38:10.000000000","message":"done","commit_id":"605348ca2947994d076c76f1d1411e7f6ebd43bd"}]}