)]}'
{"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e1c573d9a356d89413fda789824b237df4f4b601","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        super(DvrEdgeRouter, self).internal_network_updated("},{"line_number":135,"context_line":"                interface_name, ip_cidrs, mtu, port)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if not port:"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        if not self._is_this_snat_host():"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        sn_port \u003d self.get_snat_port_for_internal_port(port)"},{"line_number":143,"context_line":"        if not sn_port:"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ns_name \u003d dvr_snat_ns.SnatNamespace.get_snat_ns_name(self.router[\u0027id\u0027])"},{"line_number":147,"context_line":"        interface_name \u003d self._get_snat_int_device_name(sn_port[\u0027id\u0027])"},{"line_number":148,"context_line":"        self.driver.set_mtu(interface_name, port[\u0027mtu\u0027], namespace\u003dns_name,"},{"line_number":149,"context_line":"                            prefix\u003dlib_constants.SNAT_INT_DEV_PREFIX)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _dvr_internal_network_removed(self, port):"},{"line_number":152,"context_line":"        super(DvrEdgeRouter, self)._dvr_internal_network_removed(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"57dcad97_a476e539","line":149,"range":{"start_line":137,"start_character":0,"end_line":149,"end_character":69},"updated":"2021-08-09 08:18:52.000000000","message":"These lines seem to be duplicated to the following-up patch.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"485723b81b7f072c4085ea95e363a6cd257fcb53","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        super(DvrEdgeRouter, self).internal_network_updated("},{"line_number":135,"context_line":"                interface_name, ip_cidrs, mtu, port)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if not port:"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        if not self._is_this_snat_host():"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        sn_port \u003d self.get_snat_port_for_internal_port(port)"},{"line_number":143,"context_line":"        if not sn_port:"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ns_name \u003d dvr_snat_ns.SnatNamespace.get_snat_ns_name(self.router[\u0027id\u0027])"},{"line_number":147,"context_line":"        interface_name \u003d self._get_snat_int_device_name(sn_port[\u0027id\u0027])"},{"line_number":148,"context_line":"        self.driver.set_mtu(interface_name, port[\u0027mtu\u0027], namespace\u003dns_name,"},{"line_number":149,"context_line":"                            prefix\u003dlib_constants.SNAT_INT_DEV_PREFIX)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _dvr_internal_network_removed(self, port):"},{"line_number":152,"context_line":"        super(DvrEdgeRouter, self)._dvr_internal_network_removed(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"763237db_eec597e2","line":149,"range":{"start_line":137,"start_character":0,"end_line":149,"end_character":69},"in_reply_to":"57dcad97_a476e539","updated":"2021-08-09 11:16:51.000000000","message":"Sorry, can You give me link to the duplicated lines? I\u0027m not sure about which You are talking about","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6ebf2199178e3ef7a3733da6c4691c92a8f49812","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        super(DvrEdgeRouter, self).internal_network_updated("},{"line_number":135,"context_line":"                interface_name, ip_cidrs, mtu, port)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if not port:"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        if not self._is_this_snat_host():"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        sn_port \u003d self.get_snat_port_for_internal_port(port)"},{"line_number":143,"context_line":"        if not sn_port:"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ns_name \u003d dvr_snat_ns.SnatNamespace.get_snat_ns_name(self.router[\u0027id\u0027])"},{"line_number":147,"context_line":"        interface_name \u003d self._get_snat_int_device_name(sn_port[\u0027id\u0027])"},{"line_number":148,"context_line":"        self.driver.set_mtu(interface_name, port[\u0027mtu\u0027], namespace\u003dns_name,"},{"line_number":149,"context_line":"                            prefix\u003dlib_constants.SNAT_INT_DEV_PREFIX)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _dvr_internal_network_removed(self, port):"},{"line_number":152,"context_line":"        super(DvrEdgeRouter, self)._dvr_internal_network_removed(port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b092920_a9faa3aa","line":149,"range":{"start_line":137,"start_character":0,"end_line":149,"end_character":69},"in_reply_to":"763237db_eec597e2","updated":"2021-08-09 13:31:10.000000000","message":"Never mind, I saw the follow-up first which give me a repeat memory:\nhttps://review.opendev.org/c/openstack/neutron/+/799439/3/neutron/agent/l3/dvr_edge_router.py","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"39314d4a1d5b4a8c62dd00228e2783509bb08109","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"0534b487_b5389a4b","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"updated":"2021-07-05 11:09:57.000000000","message":"Yeah, I can\u0027t find a better way to tell a method param is deprecated","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ddc88d2877071fdf74707215b3be118b5ee03c8","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd6c8ab7_555937ec","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"in_reply_to":"032309ef_1aef0ebb","updated":"2021-07-05 11:50:33.000000000","message":"I see nothing in https://codesearch.openstack.org/?q\u003dinternal_network_updated\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e0c56de33eaa581a3821eb1f935064125c36e8e0","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"e846861d_49098b2e","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"in_reply_to":"0534b487_b5389a4b","updated":"2021-07-05 11:43:05.000000000","message":"I don\u0027t understand this warning. This is a method used only in Neutron. Why don\u0027t we just change the method signature and all calls?\n\nhttps://codesearch.openstack.org/?q\u003dinternal_network_updated\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d9080f10265877a02a8213aaced0e2a741a0908","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f039043_82f42308","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"in_reply_to":"07b039e1_e497f083","updated":"2021-07-19 09:46:07.000000000","message":"You are right, let\u0027s write this warning then.","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50249369590b26243938a2af18ceda822699020a","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"07b039e1_e497f083","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"in_reply_to":"cd6c8ab7_555937ec","updated":"2021-07-05 12:03:21.000000000","message":"I also didn\u0027t saw any usage of it in codesearch but still, it is public method and I didn\u0027t want to e.g. break some 3rd party projects which maybe have this method defined in their d/s code. That\u0027s why I decided to do it that way.","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8ea18a588d72f750239b07e25ee98f1c8cdafbf1","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""},{"line_number":371,"context_line":"                        \"the internal_network_update is deprecated and will \""},{"line_number":372,"context_line":"                        \"be removed in Z cycle. Please pass port dict \""},{"line_number":373,"context_line":"                        \"instead\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"032309ef_1aef0ebb","line":370,"range":{"start_line":370,"start_character":12,"end_line":370,"end_character":23},"in_reply_to":"e846861d_49098b2e","updated":"2021-07-05 11:48:43.000000000","message":"I think maybe VPNaaS could use this signature","commit_id":"314a5963431d7912c6efeab86e1e0ccc29f6d15e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e1c573d9a356d89413fda789824b237df4f4b601","unresolved":true,"context_lines":[{"line_number":362,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":363,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":364,"context_line":"        if port:"},{"line_number":365,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"},{"line_number":366,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])"},{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"b1994a28_08897f69","line":367,"range":{"start_line":365,"start_character":0,"end_line":367,"end_character":29},"updated":"2021-08-09 08:18:52.000000000","message":"These lines can be a utils function in base RouterInfo class.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e484de2bd53326c382433c8c304d0697d400079","unresolved":true,"context_lines":[{"line_number":362,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":363,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":364,"context_line":"        if port:"},{"line_number":365,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"},{"line_number":366,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])"},{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"b7f519a9_aca9fadb","line":367,"range":{"start_line":365,"start_character":0,"end_line":367,"end_character":29},"in_reply_to":"3705e56f_e5faf107","updated":"2021-08-30 10:21:02.000000000","message":"They are but still I think that adding additional method here will be overengineering so I will not do that.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6ebf2199178e3ef7a3733da6c4691c92a8f49812","unresolved":true,"context_lines":[{"line_number":362,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":363,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":364,"context_line":"        if port:"},{"line_number":365,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"},{"line_number":366,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])"},{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3705e56f_e5faf107","line":367,"range":{"start_line":365,"start_character":0,"end_line":367,"end_character":29},"in_reply_to":"636563fd_c0e20b84","updated":"2021-08-09 13:31:10.000000000","message":"These 3 lines are duplicated in 3 places, it\u0027s fine to refactor:\n[1] https://review.opendev.org/c/openstack/neutron/+/799226/2/neutron/agent/l3/ha_router.py@365\n[2] https://review.opendev.org/c/openstack/neutron/+/799226/2/neutron/agent/l3/router_info.py@647\n[3] https://review.opendev.org/c/openstack/neutron/+/799226/2/neutron/agent/l3/dvr_edge_router.py#146","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"485723b81b7f072c4085ea95e363a6cd257fcb53","unresolved":true,"context_lines":[{"line_number":362,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":363,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":364,"context_line":"        if port:"},{"line_number":365,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"},{"line_number":366,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])"},{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"636563fd_c0e20b84","line":367,"range":{"start_line":365,"start_character":0,"end_line":367,"end_character":29},"in_reply_to":"b1994a28_08897f69","updated":"2021-08-09 11:16:51.000000000","message":"It could be but TBH I\u0027m not sure if we really need it. IMHO it would be an overengineering","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85209a2e14d803669a37090f725f56c8760909cc","unresolved":true,"context_lines":[{"line_number":362,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":363,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":364,"context_line":"        if port:"},{"line_number":365,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"},{"line_number":366,"context_line":"            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])"},{"line_number":367,"context_line":"            mtu \u003d port[\u0027mtu\u0027]"},{"line_number":368,"context_line":"            LOG.debug(\"updating internal network for port %s\", port)"},{"line_number":369,"context_line":"        else:"},{"line_number":370,"context_line":"            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"0706b493_fc82fd8e","line":367,"range":{"start_line":365,"start_character":0,"end_line":367,"end_character":29},"in_reply_to":"b7f519a9_aca9fadb","updated":"2021-08-30 11:08:16.000000000","message":"I have the same opinion here, that is overengineering.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e1c573d9a356d89413fda789824b237df4f4b601","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"f978b812_622f4518","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"updated":"2021-08-09 08:18:52.000000000","message":"_process_internal_ports should be the only entry for calling internal_network_updated, so IMO, that if-else checking for port input is not necessary.\n\n\"\"\"\n        if port:\n            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])\n            ip_cidrs \u003d common_utils.fixed_ip_cidrs(port[\u0027fixed_ips\u0027])\n            mtu \u003d port[\u0027mtu\u0027]\n            LOG.debug(\"updating internal network for port %s\", port)\n        else:\n            LOG.warning(\"Passing `interface_name`, `ip_cidrs` and `mtu` to \"\n                        \"the internal_network_update is deprecated and will \"\n                        \"be removed in Z cycle. Please pass port dict \"\n                        \"instead\")\n\"\"\"","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85209a2e14d803669a37090f725f56c8760909cc","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"bac96adf_bd5a1d26","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"27dcbec9_92c872dc","updated":"2021-08-30 11:08:16.000000000","message":"I\u0027m with Liu here. If we know no one is using it, I prefer to change the method signature right now and remove the \"if port\" check.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e484de2bd53326c382433c8c304d0697d400079","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"27dcbec9_92c872dc","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"40aefdb4_bd761113","updated":"2021-08-30 10:21:02.000000000","message":"It should, but is it problem if we will deprecate it for one cycle and then remove in next one?","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ccbcef28df4e2f055996788d4cd413775007ff0","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7c60dda_346f1eb1","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"97039407_f3ac00f2","updated":"2021-08-30 14:49:04.000000000","message":"ok, let\u0027s change it now :)","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"37d2484da6d6aef1770f15249bedd964478ba612","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"97039407_f3ac00f2","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"bac96adf_bd5a1d26","updated":"2021-08-30 11:38:32.000000000","message":"+1, this method is not documented as public API, and a \"formal\" deprecation is an extra job in the future :-)","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6ebf2199178e3ef7a3733da6c4691c92a8f49812","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"40aefdb4_bd761113","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"d457312b_eb111ab0","updated":"2021-08-09 13:31:10.000000000","message":"These are code search of \"internal_network_updated\" in openstack repos and all github repos. IMO, this should be used only in Neutron.\n\nhttps://codesearch.openstack.org/?q\u003dinternal_network_updated\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\nhttps://github.com/search?l\u003dPython\u0026p\u003d6\u0026q\u003dinternal_network_updated\u0026type\u003dCode","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"485723b81b7f072c4085ea95e363a6cd257fcb53","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        for p in updated_ports:"},{"line_number":713,"context_line":"            self._update_internal_ports_cache(p)"},{"line_number":714,"context_line":"            updated_cidrs +\u003d common_utils.fixed_ip_cidrs(p[\u0027fixed_ips\u0027])"},{"line_number":715,"context_line":"            self.internal_network_updated(port\u003dp)"},{"line_number":716,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check if there is any pd prefix update"}],"source_content_type":"text/x-python","patch_set":2,"id":"d457312b_eb111ab0","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":49},"in_reply_to":"f978b812_622f4518","updated":"2021-08-09 11:16:51.000000000","message":"In neutron it is but \"internal_network_updated\" is public method and I don\u0027t want to break any 3rd party implementation which maybe has own implementation of that method.","commit_id":"beaee27d30f640944d25148a1b7a8b015d7cbcf7"}]}