)]}'
{"neutron/tests/fullstack/resources/machine.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"99ad2b74d3a9a8c961c816e10f79083562fe7bbb","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _start_async_dhclient(self, port_id, version\u003dconstants.IP_VERSION_4):"},{"line_number":156,"context_line":"        cmd \u003d [\"dhclient\", \u0027-%s\u0027 % version,"},{"line_number":157,"context_line":"               \u0027-lf\u0027,"},{"line_number":158,"context_line":"               \u0027%s/%s.lease\u0027 % (self.host.neutron_config.temp_dir,"},{"line_number":159,"context_line":"                                port_id),"},{"line_number":160,"context_line":"               \u0027-sf\u0027, self.NO_RESOLV_CONF_DHCLIENT_SCRIPT_PATH,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c146bd4a_4ceb8459","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":19},"updated":"2021-07-05 07:43:42.000000000","message":"just asking, shouldn\u0027t be the same for the \"hosts\" file?","commit_id":"bc5e380ce363301274fcfa1d2ff9c906b17fad34"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d94e0e8d91734b5d87f94dc3b199796d9df452ec","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _start_async_dhclient(self, port_id, version\u003dconstants.IP_VERSION_4):"},{"line_number":156,"context_line":"        cmd \u003d [\"dhclient\", \u0027-%s\u0027 % version,"},{"line_number":157,"context_line":"               \u0027-lf\u0027,"},{"line_number":158,"context_line":"               \u0027%s/%s.lease\u0027 % (self.host.neutron_config.temp_dir,"},{"line_number":159,"context_line":"                                port_id),"},{"line_number":160,"context_line":"               \u0027-sf\u0027, self.NO_RESOLV_CONF_DHCLIENT_SCRIPT_PATH,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7aa4565_07bf7752","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":19},"in_reply_to":"c146bd4a_4ceb8459","updated":"2021-07-05 07:59:00.000000000","message":"Sorry, I did not get your point. \"hosts\" file of what?","commit_id":"bc5e380ce363301274fcfa1d2ff9c906b17fad34"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c97a3b11d16235f64ce926b2a117bc705949dfa2","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _start_async_dhclient(self, port_id, version\u003dconstants.IP_VERSION_4):"},{"line_number":156,"context_line":"        cmd \u003d [\"dhclient\", \u0027-%s\u0027 % version,"},{"line_number":157,"context_line":"               \u0027-lf\u0027,"},{"line_number":158,"context_line":"               \u0027%s/%s.lease\u0027 % (self.host.neutron_config.temp_dir,"},{"line_number":159,"context_line":"                                port_id),"},{"line_number":160,"context_line":"               \u0027-sf\u0027, self.NO_RESOLV_CONF_DHCLIENT_SCRIPT_PATH,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a29b65b6_c9008b8d","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":19},"in_reply_to":"d7aa4565_07bf7752","updated":"2021-07-06 08:30:56.000000000","message":"I was talking about dnsmasq \"hosts\" file, same as \"leases\" file. By default we are using always the same file, /etc/hosts. If we have concerns about sharing \"leases\" file, we should also use \"--no-hosts\" flag and the additional hosts flag [1], same as in the dhcp agent.\n\n[1]https://wiki.gentoo.org/wiki/Dnsmasq#Hosts_file","commit_id":"bc5e380ce363301274fcfa1d2ff9c906b17fad34"}]}