)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3e36e0b233db541a01ddf5be65d1c03e744860b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1316b3f9_16051968","updated":"2021-10-12 07:53:49.000000000","message":"recheck","commit_id":"d7f93ab772616e0949279223604e4446c9151ec2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5251b18d494244f16153d73ccd551beb153c18b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8f47b6d_a2bbd6d9","updated":"2021-10-18 11:00:29.000000000","message":"recheck lots of multinode tests failed","commit_id":"21eabbcf03cb29be9899adbd6eaea207892cf07b"}],"neutron/agent/l3/dvr_edge_ha_router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9d0812038c640d72b35dc24143ec479046c49149","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        # NOTE(slaweq): qr- interface is not in ha_namespace but in qrouter"},{"line_number":80,"context_line":"        # namespace in case of dvr ha ruter"},{"line_number":81,"context_line":"        self._disable_ipv6_addressing_on_interface("},{"line_number":82,"context_line":"            interface_name, namespace\u003dself.ns_name)"},{"line_number":83,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":84,"context_line":"            self._add_vip(ip_cidr, interface_name)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2a2f5242_c8b90f2a","line":82,"updated":"2021-07-05 11:49:45.000000000","message":"so this method is the same a parent class method (from L64 to L84) except for the namespace of the qr- interface, right? I think that worth mentioning it in the method description","commit_id":"7c0fba450a4013581f38feeaec50a2639ba12c3f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8ff8cdcf55f713ca58b619c7fd7e7ecad15c49a","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        # NOTE(slaweq): qr- interface is not in ha_namespace but in qrouter"},{"line_number":80,"context_line":"        # namespace in case of dvr ha ruter"},{"line_number":81,"context_line":"        self._disable_ipv6_addressing_on_interface("},{"line_number":82,"context_line":"            interface_name, namespace\u003dself.ns_name)"},{"line_number":83,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":84,"context_line":"            self._add_vip(ip_cidr, interface_name)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"01b3295c_9d3f2f50","line":82,"in_reply_to":"2a2f5242_c8b90f2a","updated":"2021-07-22 19:18:09.000000000","message":"TBH I\u0027m not sure if this needs to be added as a comment. I\u0027m afraid that such comment can be outdated as soon as someone will propose any other change to this method :)","commit_id":"7c0fba450a4013581f38feeaec50a2639ba12c3f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a98e7d3895507a0a34670a6990b07152d979a3d6","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            self._get_snat_int_device_name,"},{"line_number":62,"context_line":"            constants.SNAT_INT_DEV_PREFIX)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":65,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":66,"context_line":"        if port:"},{"line_number":67,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"4585db7b_9507f92c","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":32},"updated":"2021-08-09 10:43:28.000000000","message":"should it do super call inside?","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"865a6af1417e18a93e3e9b677e46ecf6e83a587f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            self._get_snat_int_device_name,"},{"line_number":62,"context_line":"            constants.SNAT_INT_DEV_PREFIX)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":65,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":66,"context_line":"        if port:"},{"line_number":67,"context_line":"            interface_name \u003d self.get_internal_device_name(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc2a9f39_a39a73cb","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":32},"in_reply_to":"4585db7b_9507f92c","updated":"2021-08-09 11:21:54.000000000","message":"No because it would call method from the ha_router.HaRouter and that\u0027s what would cause error as it would call self._disable_ipv6_addressing_on_interface() with wrong namespace","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c77415fb97320e76dffe7801a4f740206ac5c2f","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":84,"context_line":"            self._add_vip(ip_cidr, interface_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if port:"},{"line_number":87,"context_line":"            self._set_snat_interfce_mtu(port)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff2d9c3f_3895ecee","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":16},"updated":"2021-08-09 08:19:00.000000000","message":"Line 72 says \"\"\"Passing `interface_name`, `ip_cidrs` and `mtu` to the internal_network_update is deprecated\"\"\", so if internal_network_updated is not called with \"port\", with this condition here, mtu will still not get updated?","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"865a6af1417e18a93e3e9b677e46ecf6e83a587f","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":84,"context_line":"            self._add_vip(ip_cidr, interface_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if port:"},{"line_number":87,"context_line":"            self._set_snat_interfce_mtu(port)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":2,"id":"83df8824_723ba50e","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":16},"in_reply_to":"ff2d9c3f_3895ecee","updated":"2021-08-09 11:21:54.000000000","message":"yes, but You\u0027r right, we can remove that if","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d65301fa0579b4282376a35b09752958a2308b45","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                            prefix\u003drouter_info.INTERNAL_DEV_PREFIX)"},{"line_number":70,"context_line":"        self._clear_vips(interface_name)"},{"line_number":71,"context_line":"        # NOTE(slaweq): qr- interface is not in ha_namespace but in qrouter"},{"line_number":72,"context_line":"        # namespace in case of dvr ha ruter"},{"line_number":73,"context_line":"        self._disable_ipv6_addressing_on_interface("},{"line_number":74,"context_line":"            interface_name, namespace\u003dself.ns_name)"},{"line_number":75,"context_line":"        for ip_cidr in ip_cidrs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a6a60ae2_810ccbf2","line":72,"range":{"start_line":72,"start_character":38,"end_line":72,"end_character":43},"updated":"2021-11-04 10:25:51.000000000","message":"router","commit_id":"21eabbcf03cb29be9899adbd6eaea207892cf07b"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c77415fb97320e76dffe7801a4f740206ac5c2f","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":146,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":147,"context_line":"        print(\"Port \u003d %s\" % port)"},{"line_number":148,"context_line":"        super(DvrEdgeRouter, self).internal_network_updated("},{"line_number":149,"context_line":"                interface_name, ip_cidrs, mtu, port)"},{"line_number":150,"context_line":"        if port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"04ec3489_f76922a4","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":33},"updated":"2021-08-09 08:19:00.000000000","message":"LOG not cleared","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"865a6af1417e18a93e3e9b677e46ecf6e83a587f","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def internal_network_updated(self, interface_name\u003dNone, ip_cidrs\u003dNone,"},{"line_number":146,"context_line":"                                 mtu\u003dNone, port\u003dNone):"},{"line_number":147,"context_line":"        print(\"Port \u003d %s\" % port)"},{"line_number":148,"context_line":"        super(DvrEdgeRouter, self).internal_network_updated("},{"line_number":149,"context_line":"                interface_name, ip_cidrs, mtu, port)"},{"line_number":150,"context_line":"        if port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"2b5c75e8_92ba1d7f","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":33},"in_reply_to":"04ec3489_f76922a4","updated":"2021-08-09 11:21:54.000000000","message":"Done","commit_id":"860a9392d89965bb79eef93e0f38b2fa5ad8ce12"}]}