)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8eb67fd98c3af390ca6d3c55761f1a4da78a9960","unresolved":true,"context_lines":[{"line_number":10,"context_line":"from source. We need to set proper flag (Q_BUILD_OVS_FROM_GIT) which"},{"line_number":11,"context_line":"is used in Devstack to tell Devstack to install it from source and"},{"line_number":12,"context_line":"not from packages."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09c79d0e9700cc2bfdf71e5314ea660de75ac1d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"52db6b12_0cf29028","line":13,"updated":"2021-12-09 08:41:00.000000000","message":"dont we need a depends-on for it: https://review.opendev.org/c/openstack/devstack/+/799621 ?","commit_id":"513f46c99a7f76c636c598ed7c681873631c9b28"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1737eb271b20c01bc593bafd9fddc110c9c17f8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5f7a7386_46e49545","updated":"2022-01-13 12:50:10.000000000","message":"I pushed a dependent patch to make vpnaas use the same: https://review.opendev.org/c/openstack/neutron-vpnaas/+/824560","commit_id":"391726bd4c0302ca3ce27f5de8e39ee4c6d91457"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"baa14d973f4c52b2b38c52f266a30e2638a2f221","unresolved":true,"context_lines":[{"line_number":66,"context_line":"INSTALL_BASE_DEPENDENCIES\u003d${INSTALL_BASE_DEPENDENCIES:-$IS_GATE}"},{"line_number":67,"context_line":"BUILD_OVS_FROM_SOURCE\u003d${BUILD_OVS_FROM_SOURCE:-True}"},{"line_number":68,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-main}"},{"line_number":69,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d$BUILD_OVS_FROM_SOURCE"},{"line_number":70,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-master}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"c000ff56_06a8782d","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":20},"updated":"2021-12-09 08:42:12.000000000","message":"When is this failing?\nIf I\u0027m not wrong, in devstack we do\n  Q_BUILD_OVS_FROM_GIT\u003d$(trueorfalse True Q_BUILD_OVS_FROM_GIT)\n\nto set a default value of True if no parameter is passed.\n\nIn any case, we should provide the ability to pass it here, something like\n  Q_BUILD_OVS_FROM_GIT\u003d${BUILD_OVS_FROM_SOURCE:-$Q_BUILD_OVS_FROM_GIT}","commit_id":"513f46c99a7f76c636c598ed7c681873631c9b28"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a372a32c21de9de4a48176b75446bfea7725d743","unresolved":true,"context_lines":[{"line_number":66,"context_line":"INSTALL_BASE_DEPENDENCIES\u003d${INSTALL_BASE_DEPENDENCIES:-$IS_GATE}"},{"line_number":67,"context_line":"BUILD_OVS_FROM_SOURCE\u003d${BUILD_OVS_FROM_SOURCE:-True}"},{"line_number":68,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-main}"},{"line_number":69,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d$BUILD_OVS_FROM_SOURCE"},{"line_number":70,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-master}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"f8c3f359_253095fe","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":20},"in_reply_to":"c000ff56_06a8782d","updated":"2021-12-09 08:43:03.000000000","message":"I mean:\n  Q_BUILD_OVS_FROM_GIT\u003d${Q_BUILD_OVS_FROM_GIT:-$BUILD_OVS_FROM_SOURCE}","commit_id":"513f46c99a7f76c636c598ed7c681873631c9b28"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d709e31b9b82916823bb5e3e1603669078a2a0cc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"INSTALL_BASE_DEPENDENCIES\u003d${INSTALL_BASE_DEPENDENCIES:-$IS_GATE}"},{"line_number":67,"context_line":"BUILD_OVS_FROM_SOURCE\u003d${BUILD_OVS_FROM_SOURCE:-True}"},{"line_number":68,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-main}"},{"line_number":69,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d$BUILD_OVS_FROM_SOURCE"},{"line_number":70,"context_line":"OVS_BRANCH\u003d${OVS_BRANCH:-master}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7ef9ee64_b59be099","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":20},"in_reply_to":"f8c3f359_253095fe","updated":"2021-12-20 07:33:31.000000000","message":"Done.\nI removed BUILD_OVS_FROM_SOURCE option and kept only Q_BUILD_OVS_FROM_GIT as there is no need to keep 2 options for the same purpose.\nIt also needs small change in the neutron-vpnaas repo: https://review.opendev.org/c/openstack/neutron-vpnaas/+/822292","commit_id":"513f46c99a7f76c636c598ed7c681873631c9b28"}]}
