)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ad4dadb03e6cf6de57db1ca12f0614e580f7f055","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3] Don\u0027t run network_update and _process_internal_ports together"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Router_info\u0027s _process_internal_ports() method it the one which is"},{"line_number":10,"context_line":"manipulating router_info.internal_ports cache and network_update()"},{"line_number":11,"context_line":"method from the L3 agent is relying on that Router_info\u0027s cache to"},{"line_number":12,"context_line":"check if updated network is connected to the router or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4dadbdac_7ad2ed5c","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"updated":"2021-07-07 15:22:12.000000000","message":"nit: is","commit_id":"3a2ff07e56b373018a73023fbadd2455378aa5bf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89fbd4646f3d6957d5ef8e94e93e33913a3fdf0c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3] Use processing queue for network update events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Router_info\u0027s _process_internal_ports() method it the one which is"},{"line_number":10,"context_line":"manipulating router_info.internal_ports cache and network_update()"},{"line_number":11,"context_line":"method from the L3 agent is relying on that Router_info\u0027s cache to"},{"line_number":12,"context_line":"check if updated network is connected to the router or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"53e6dd97_d14ba5be","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"updated":"2021-07-08 14:44:12.000000000","message":"is","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c306a7173fa93ebfda2f610f732c553556adfcd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3] Use processing queue for network update events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Router_info\u0027s _process_internal_ports() method it the one which is"},{"line_number":10,"context_line":"manipulating router_info.internal_ports cache and network_update()"},{"line_number":11,"context_line":"method from the L3 agent is relying on that Router_info\u0027s cache to"},{"line_number":12,"context_line":"check if updated network is connected to the router or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"70bac825_a3dd6dd0","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"in_reply_to":"53e6dd97_d14ba5be","updated":"2021-07-08 15:04:13.000000000","message":"Done","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89fbd4646f3d6957d5ef8e94e93e33913a3fdf0c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"So they shouldn\u0027t be run together as that may cause some race conditions"},{"line_number":14,"context_line":"and unexpected issues, like e.g. described in the related bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Until now, network_update even was the only one which was processed"},{"line_number":17,"context_line":"without using queue of events. And because of that such race condition"},{"line_number":18,"context_line":"as described above were possible."},{"line_number":19,"context_line":"To fix that, this patch changes network_update method in the way that it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2abab283_4056d56e","line":16,"range":{"start_line":16,"start_character":26,"end_line":16,"end_character":30},"updated":"2021-07-08 14:44:12.000000000","message":"event","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c306a7173fa93ebfda2f610f732c553556adfcd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"So they shouldn\u0027t be run together as that may cause some race conditions"},{"line_number":14,"context_line":"and unexpected issues, like e.g. described in the related bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Until now, network_update even was the only one which was processed"},{"line_number":17,"context_line":"without using queue of events. And because of that such race condition"},{"line_number":18,"context_line":"as described above were possible."},{"line_number":19,"context_line":"To fix that, this patch changes network_update method in the way that it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"97ce998c_9c1ca758","line":16,"range":{"start_line":16,"start_character":26,"end_line":16,"end_character":30},"in_reply_to":"2abab283_4056d56e","updated":"2021-07-08 15:04:13.000000000","message":"Done","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89fbd4646f3d6957d5ef8e94e93e33913a3fdf0c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"To fix that, this patch changes network_update method in the way that it"},{"line_number":20,"context_line":"now adds update events for each router hosted by agent to the queue."},{"line_number":21,"context_line":"Those events for single routers are then processed, checks if network is"},{"line_number":22,"context_line":"actually connected to the router and if yet, schedules router update to"},{"line_number":23,"context_line":"be processed."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1933234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d90ff66f_1cce0cc9","line":22,"range":{"start_line":22,"start_character":40,"end_line":22,"end_character":43},"updated":"2021-07-08 14:44:12.000000000","message":"yes","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c306a7173fa93ebfda2f610f732c553556adfcd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"To fix that, this patch changes network_update method in the way that it"},{"line_number":20,"context_line":"now adds update events for each router hosted by agent to the queue."},{"line_number":21,"context_line":"Those events for single routers are then processed, checks if network is"},{"line_number":22,"context_line":"actually connected to the router and if yet, schedules router update to"},{"line_number":23,"context_line":"be processed."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1933234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fde3b12_3a555728","line":22,"range":{"start_line":22,"start_character":40,"end_line":22,"end_character":43},"in_reply_to":"d90ff66f_1cce0cc9","updated":"2021-07-08 15:04:13.000000000","message":"Done","commit_id":"97e730fc6a84f4243ed9088492182c08e1c4a1e6"}]}