)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"81948406ab66feadb04d92e568a0f00fcf7a3280","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                # update yet."},{"line_number":278,"context_line":"                LOG.info(\"Waiting for Port Group %(pg)s to be created\","},{"line_number":279,"context_line":"                         {\u0027pg\u0027: ovn_const.OVN_DROP_PORT_GROUP_NAME})"},{"line_number":280,"context_line":"                if not idl.neutron_pg_drop_event.wait():"},{"line_number":281,"context_line":"                    LOG.error(\"Port Group %(pg)s was not created in time\","},{"line_number":282,"context_line":"                              {\u0027pg\u0027: ovn_const.OVN_DROP_PORT_GROUP_NAME})"},{"line_number":283,"context_line":"                    raise re"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9209659_b9d458ff","line":280,"range":{"start_line":280,"start_character":49,"end_line":280,"end_character":53},"updated":"2021-07-08 08:14:38.000000000","message":"I was going to ask to use a timeout. But now I see NeutronPgDropPortGroupCreated is created with a default timeout (ovsdb_connection_timeout), that is used by default in wait. We are ok here.","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c392fc063452abb71f3f82b0fed65cfa75a46b28","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                # update yet."},{"line_number":278,"context_line":"                LOG.info(\"Waiting for Port Group %(pg)s to be created\","},{"line_number":279,"context_line":"                         {\u0027pg\u0027: ovn_const.OVN_DROP_PORT_GROUP_NAME})"},{"line_number":280,"context_line":"                if not idl.neutron_pg_drop_event.wait():"},{"line_number":281,"context_line":"                    LOG.error(\"Port Group %(pg)s was not created in time\","},{"line_number":282,"context_line":"                              {\u0027pg\u0027: ovn_const.OVN_DROP_PORT_GROUP_NAME})"},{"line_number":283,"context_line":"                    raise re"}],"source_content_type":"text/x-python","patch_set":1,"id":"9953a7a6_d09ba607","line":280,"range":{"start_line":280,"start_character":49,"end_line":280,"end_character":53},"in_reply_to":"d9209659_b9d458ff","updated":"2021-07-08 16:31:06.000000000","message":"Yeah, I wish I had added a timeout argument to wait() itself in WaitEvent, instead of relying on the one created with __init__(). Definitely something that could be added to ovsdbapp w/o breaking anything though.","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"81948406ab66feadb04d92e568a0f00fcf7a3280","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        return cmd.DeleteLRouterExtGwCommand(self, lrouter_name, if_exists)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":749,"context_line":"        return self.lookup(\u0027Port_Group\u0027, pg_name, None)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def get_sg_port_groups(self):"},{"line_number":752,"context_line":"        \"\"\"Returns OVN port groups used as Neutron Security Groups."}],"source_content_type":"text/x-python","patch_set":1,"id":"24978756_c1ac369b","line":749,"range":{"start_line":749,"start_character":8,"end_line":749,"end_character":55},"updated":"2021-07-08 08:14:38.000000000","message":"mimicking the base PS logic, shouldn\u0027t we return nothing in case of not finding the register?\n\n    try:\n        return self.lookup(\u0027Port_Group\u0027, pg_name, None)\n    except idlutils.RowNotFound:\n        return","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bd6a1796e3d5e55c6054b6ef2a8c95e4cbd3e616","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        return cmd.DeleteLRouterExtGwCommand(self, lrouter_name, if_exists)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":749,"context_line":"        return self.lookup(\u0027Port_Group\u0027, pg_name, None)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def get_sg_port_groups(self):"},{"line_number":752,"context_line":"        \"\"\"Returns OVN port groups used as Neutron Security Groups."}],"source_content_type":"text/x-python","patch_set":1,"id":"c7003d43_ee8377cf","line":749,"range":{"start_line":749,"start_character":8,"end_line":749,"end_character":55},"in_reply_to":"24978756_c1ac369b","updated":"2021-07-08 16:29:02.000000000","message":"Lookup() returns a default if you pass it (in this case, None)","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"449b8528c578bf5e91c56bdf6a782c80216b28f6","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        return cmd.DeleteLRouterExtGwCommand(self, lrouter_name, if_exists)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":749,"context_line":"        return self.lookup(\u0027Port_Group\u0027, pg_name, None)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def get_sg_port_groups(self):"},{"line_number":752,"context_line":"        \"\"\"Returns OVN port groups used as Neutron Security Groups."}],"source_content_type":"text/x-python","patch_set":1,"id":"ab8615c7_7e492294","line":749,"range":{"start_line":749,"start_character":8,"end_line":749,"end_character":55},"in_reply_to":"8f1a7474_c114dcfa","updated":"2021-07-27 18:27:16.000000000","message":"Done","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b14d6e059849cea515c476f6e8be96c4ad3ab19f","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        return cmd.DeleteLRouterExtGwCommand(self, lrouter_name, if_exists)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":749,"context_line":"        return self.lookup(\u0027Port_Group\u0027, pg_name, None)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def get_sg_port_groups(self):"},{"line_number":752,"context_line":"        \"\"\"Returns OVN port groups used as Neutron Security Groups."}],"source_content_type":"text/x-python","patch_set":1,"id":"8f1a7474_c114dcfa","line":749,"range":{"start_line":749,"start_character":8,"end_line":749,"end_character":55},"in_reply_to":"c7003d43_ee8377cf","updated":"2021-07-09 17:00:18.000000000","message":"Sorry, I missed that part (I need to review better).","commit_id":"c834fcbdd84f75c7584712c7f102e41f019d32ab"}]}