)]}'
{"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"96e12f1b660e5f19d3fd1affd0c59bbf78767458","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":199,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"},{"line_number":200,"context_line":"    cfg.ListOpt(\u0027additional_worker_classes_with_ovn_idl\u0027,"},{"line_number":201,"context_line":"                default\u003d[\u0027RpcWorker\u0027],"},{"line_number":202,"context_line":"                help\u003d_(\u0027Additional worker classes to enable OVN IDLs for.\\n\u0027"},{"line_number":203,"context_line":"                       \u0027The API and maintenance workers always have access to \u0027"},{"line_number":204,"context_line":"                       \u0027the IDL connections and can not be disabled.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e49dd73_9e00d6b6","line":201,"updated":"2021-07-14 15:07:15.000000000","message":"There\u0027s a part of me that thinks that the default shouldn\u0027t be for the \"weird\" case of using neutron dhcp agent. I can see the argument for \"it used to just work, and this is an optimization\" though. Deleting the default would mean config being just:\n  [ovn]\n  additional_worker_classes_with_ovn_idl\u003d\n\n? Do we need a test that verifies that removing the RpcWorker works? Is this all pretty much pointless at this point and we just unconditionally add RpcWorker back and remove the weird config option?","commit_id":"ecbe2596657f0c7f88483a52959406342ad320ef"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"98e629a766d6d9ea7a320a00244e420b8305f736","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        # the OVN IDL connections"},{"line_number":283,"context_line":"        if worker_class in (neutron.wsgi.WorkerService,"},{"line_number":284,"context_line":"                            worker.MaintenanceWorker,"},{"line_number":285,"context_line":"                            service.RpcWorker):"},{"line_number":286,"context_line":"            return True"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Configuration may allow other worker types to use IDL connections."}],"source_content_type":"text/x-python","patch_set":1,"id":"6d3e3589_ff6951b5","line":285,"range":{"start_line":285,"start_character":36,"end_line":285,"end_character":45},"updated":"2021-07-13 17:35:07.000000000","message":"I would propose this patch only for stable versions. In master we have [1].\n\nHowever, I understand your comment in [2]: this is already working in other releases without any configuration and we are introducing a regression [3].\n\n[1]https://review.opendev.org/c/openstack/neutron/+/795781\n[2]https://bugs.launchpad.net/neutron/+bug/1935983/comments/5\n[3]https://review.opendev.org/c/openstack/neutron/+/765874","commit_id":"9ea24676c6017592843c840efd19a3d696788135"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e00976cb037d5a4e01cba9d0807477eed1b1ab98","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        # the OVN IDL connections"},{"line_number":283,"context_line":"        if worker_class in (neutron.wsgi.WorkerService,"},{"line_number":284,"context_line":"                            worker.MaintenanceWorker,"},{"line_number":285,"context_line":"                            service.RpcWorker):"},{"line_number":286,"context_line":"            return True"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Configuration may allow other worker types to use IDL connections."}],"source_content_type":"text/x-python","patch_set":1,"id":"08b43a8c_02c06a3d","line":285,"range":{"start_line":285,"start_character":36,"end_line":285,"end_character":45},"in_reply_to":"43b6a0c5_b89848d6","updated":"2021-07-14 09:07:04.000000000","message":"Yes, yeah I will update the config option documentation as well as add a release note regarding the change of defaults too.","commit_id":"9ea24676c6017592843c840efd19a3d696788135"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6a374de74cccad3c721a33f3978d087ae271101","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        # the OVN IDL connections"},{"line_number":283,"context_line":"        if worker_class in (neutron.wsgi.WorkerService,"},{"line_number":284,"context_line":"                            worker.MaintenanceWorker,"},{"line_number":285,"context_line":"                            service.RpcWorker):"},{"line_number":286,"context_line":"            return True"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Configuration may allow other worker types to use IDL connections."}],"source_content_type":"text/x-python","patch_set":1,"id":"43b6a0c5_b89848d6","line":285,"range":{"start_line":285,"start_character":36,"end_line":285,"end_character":45},"in_reply_to":"6c7fafe6_15c8fac3","updated":"2021-07-14 09:04:19.000000000","message":"Yes, that could be a good idea for master:\n- If you want to optimize it, you can remove this worker from the config and set an empty list.\n- That will work out of the box for ironic deployments.\n- That will need an extra documentation in the config option, explaining why we set \"RpcWorker\" as default value","commit_id":"9ea24676c6017592843c840efd19a3d696788135"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f6c6982602c3fa10fbfc897f10f2e9db97d3911d","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        # the OVN IDL connections"},{"line_number":283,"context_line":"        if worker_class in (neutron.wsgi.WorkerService,"},{"line_number":284,"context_line":"                            worker.MaintenanceWorker,"},{"line_number":285,"context_line":"                            service.RpcWorker):"},{"line_number":286,"context_line":"            return True"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Configuration may allow other worker types to use IDL connections."}],"source_content_type":"text/x-python","patch_set":1,"id":"6c7fafe6_15c8fac3","line":285,"range":{"start_line":285,"start_character":36,"end_line":285,"end_character":45},"in_reply_to":"6d3e3589_ff6951b5","updated":"2021-07-14 08:14:46.000000000","message":"I was thinking, what if we do the other way around and make RpcWorker the default value of that configuration option for the master branch ?\n\nI think that would be the best of the two worlds, it would by default make baremetal provisioning continue to work just like before and still would allow folks to disable RpcWorker from connecting to the db if they so wish.\n\nWhat you think ?","commit_id":"9ea24676c6017592843c840efd19a3d696788135"}]}