)]}'
{"id":"openstack%2Fneutron~800751","triplet_id":"openstack%2Fneutron~master~I3581053f5ea5fecd6a32b193efc8f7055605ca73","project":"openstack/neutron","branch":"master","attention_set":{},"removed_from_attention_set":{"32020":{"account":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"last_update":"2021-10-14 16:15:50.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I3581053f5ea5fecd6a32b193efc8f7055605ca73","subject":"add has lock judgment for OvnNbSynchronizer","status":"ABANDONED","created":"2021-07-14 08:17:52.000000000","updated":"2021-10-14 16:15:50.000000000","total_comment_count":12,"unresolved_comment_count":6,"has_review_started":true,"meta_rev_id":"39b4c73d0ba7a20a46d41e494b34044ec9c79024","_number":800751,"virtual_id_number":800751,"owner":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-07-16 03:16:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-14 08:28:52.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"CC"},{"updated":"2021-07-14 08:29:37.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2021-07-14 08:29:37.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"state":"REVIEWER"},{"updated":"2021-07-14 08:59:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-14 10:09:26.000000000","updated_by":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"reviewer":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"state":"CC"},{"updated":"2021-07-14 10:23:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-14 10:56:09.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-14 11:35:31.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2021-07-19 21:05:38.000000000","updated_by":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-10-14 16:15:50.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"CC"}],"messages":[{"id":"13fcec8c3ac454fdfb6ddbe5bd4689a38f46ffbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-14 08:17:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"953c2cec07e36ddd572573c6ea890570f238e53a","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-14 08:28:52.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nPlease, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"226bf7e3c0b379e442d7b763da48ce51ff99b77b","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 08:59:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7719c6eae3b34ada898b52879f43ffe3 : SUCCESS in 30m 15s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/629204ea0d4944f283b622706e72d96f : SUCCESS in 38m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c31fae514106cc3adc060e40aaba829d1d8a7090","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-14 09:25:33.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Please, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages\n\nAs the question you mentioned: \"If no server has the lock to execute the sync methods, we\u0027ll never execute them\", I think the first restart neutron server can successfully \"OvnNbSynchronizer\", becase the IDL \"OvnNbSynchronizer\" is delayed for 10 seconds, which is just the time for \"DBInconsistenciesPeriodics\" successful locking.\nOf course, I have another question. Can the same IDL request two locks, one for \"DBInconsistenciesPeriodics\" and the other for \"OvnNbSynchronizer\"。","accounts_in_message":[],"_revision_number":1},{"id":"b3dda800665cddad73280ef2324b4b2b713780d8","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-14 10:09:26.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/800751/1 : SUCCESS in 1h 32m 22s","accounts_in_message":[],"_revision_number":1},{"id":"47c9fe7877ac11af7890f1323bb8360c2b8b781b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 10:23:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/c6dd303aa7b44bb6aee0ee28281b8b4f : SUCCESS in 40m 45s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/7cae2726aabc42f4a12572438863f425 : SUCCESS in 1h 57m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dcc95096d8794d3d92b1dcf7e3c2304e : SUCCESS in 37m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e4c6e7b1e21b432598743608061ade08 : SUCCESS in 34m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0bcfe639811d4cabaa4166554fae4f56 : SUCCESS in 13m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/68724eb1239f4282b501a7fa86d27115 : SUCCESS in 27m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/148fda08639c46f592a85d61ec218c68 : SUCCESS in 23m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/04c6d23b0d0242a786bc8f4d1d7a637a : SUCCESS in 26m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/134d64976e1a477994e65de89f0cec78 : SUCCESS in 9m 36s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/e39e5994e6514e05b61d70d2e64ca24a : SUCCESS in 48m 22s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/5050a2c5a77a4aa9a07c23df4d5e4e04 : SUCCESS in 53m 21s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/b1bcf8bf43244786aadbd0548e77e8ed : SUCCESS in 28m 47s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/e09f01e5b10446efba756c07585a5b2d : SUCCESS in 1h 04m 55s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/d0b16b7a54994397bb95bd60a874df0c : SUCCESS in 1h 10m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"511374cd0f2e2865b9921e15d1df2b2b50c13964","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-14 10:56:09.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/1/SRIOV-neutron-macvtap : FAILURE\n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/1/SRIOV-neutron-direct : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"40f30e5101124ae85a972bf012901f2c5c917ef8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-14 10:59:25.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e1e8b57343db79917d9055cec89dce01a60c5cad","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-14 11:35:31.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e (1 comment)\n\u003e \u003e \n\u003e \u003e Please, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages\n\u003e \n\u003e As the question you mentioned: \"If no server has the lock to execute the sync methods, we\u0027ll never execute them\", I think the first restart neutron server can successfully \"OvnNbSynchronizer\", becase the IDL \"OvnNbSynchronizer\" is delayed for 10 seconds, which is just the time for \"DBInconsistenciesPeriodics\" successful locking.\n\u003e Of course, I have another question. Can the same IDL request two locks, one for \"DBInconsistenciesPeriodics\" and the other for \"OvnNbSynchronizer\"。\n\nRight, \"Ovn*Synchronizer\" classes sync methods are executed before the \"DBInconsistenciesPeriodics\" methods.\n\nNow this raises another problem: you are asking for a lock in the NB IDL that is set in \"DBInconsistenciesPeriodics\", AFTER using the NB IDL in \"OvnNbSynchronizer\" [1]\n\nWhat I suggest is, because you are checking for a lock in this IDL, to set if before using it in \"OvnNbSynchronizer\", just before [2].\n\nAbout having two locks in the same IDL instance, lock_name is unique [3]. Can be None or something else, but we can\u0027t have more than one.\n\n[1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n[2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L335\n[3]https://github.com/openvswitch/ovs/blob/d2e97030eda5dfafc875ec056788c49e2570d2ef/python/ovs/db/idl.py#L168","accounts_in_message":[],"_revision_number":2},{"id":"86734aa0b5fc3f7c2fc16b6b4bd6253f33e0adc6","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 11:53:33.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/81dd1002c2e9471eb16a68dd35db1980 : SUCCESS in 38m 29s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/cf015def8e6a42e880aa7b1d313e7d00 : SUCCESS in 34m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c2022be6b27bff08dbdd8f6f3ece1ae3db8733ef","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-14 12:02:30.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \n\u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \n\u003e \u003e \u003e Please, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages\n\u003e \u003e \n\u003e \u003e As the question you mentioned: \"If no server has the lock to execute the sync methods, we\u0027ll never execute them\", I think the first restart neutron server can successfully \"OvnNbSynchronizer\", becase the IDL \"OvnNbSynchronizer\" is delayed for 10 seconds, which is just the time for \"DBInconsistenciesPeriodics\" successful locking.\n\u003e \u003e Of course, I have another question. Can the same IDL request two locks, one for \"DBInconsistenciesPeriodics\" and the other for \"OvnNbSynchronizer\"。\n\u003e \n\u003e Right, \"Ovn*Synchronizer\" classes sync methods are executed before the \"DBInconsistenciesPeriodics\" methods.\n\u003e \n\u003e Now this raises another problem: you are asking for a lock in the NB IDL that is set in \"DBInconsistenciesPeriodics\", AFTER using the NB IDL in \"OvnNbSynchronizer\" [1]\n\u003e \n\u003e What I suggest is, because you are checking for a lock in this IDL, to set if before using it in \"OvnNbSynchronizer\", just before [2].\n\u003e \n\u003e About having two locks in the same IDL instance, lock_name is unique [3]. Can be None or something else, but we can\u0027t have more than one.\n\u003e \n\u003e [1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n\u003e [2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L335\n\u003e [3]https://github.com/openvswitch/ovs/blob/d2e97030eda5dfafc875ec056788c49e2570d2ef/python/ovs/db/idl.py#L168\n\nDo you mean I move the lock of IDL to the front, such as this place [1], before the original position[2]?\n\n\n[1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L317\n\n[2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139","accounts_in_message":[],"_revision_number":2},{"id":"591f4c83d6146d9b828a4a9d44ba255f2807af46","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 12:52:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/62e26ec223c44c0bbe5f45ca4b6aef85 : SUCCESS in 40m 40s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/d0d8bfaa5c7b405b9de7456cbb852ced : SUCCESS in 1h 47m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6d15893f23e845f8939b3b0232a1f43e : SUCCESS in 36m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ab0f9d5147944e7bc38f372f1a92122 : SUCCESS in 32m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9edb9a1fd2904aef9a877dc76c712a2c : SUCCESS in 16m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/666dbd2d9b124612b005eea8739f4a09 : SUCCESS in 26m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2010c654419c483ab65651192e41bc29 : SUCCESS in 28m 40s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9a31965d9a4942608b72ebbdf34b9338 : SUCCESS in 25m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09aab1bc768b41a79a958477aa9f28bf : SUCCESS in 9m 38s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/583769fd3e0246659fef2cf162fb3ada : SUCCESS in 48m 29s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/19391357a2444f8f9e4d50a00545ac19 : SUCCESS in 55m 44s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/e0969845f2e6418c943376ece17c1b4d : SUCCESS in 33m 24s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/43f16ab34ddb46c9a6fa91c5109608ee : SUCCESS in 1h 10m 38s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/631ad67d421f40b78f38deb7f4a274db : SUCCESS in 1h 08m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e57f7f3acad7709b19795739e1cf27c5d36411e7","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-14 12:56:35.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/800751/2 : SUCCESS in 1h 41m 11s","accounts_in_message":[],"_revision_number":2},{"id":"d16e962f0c70ae687d553a72127e86342d9e7fe1","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-14 14:53:14.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2: Code-Review-1\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Please, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages\n\u003e \u003e \u003e \n\u003e \u003e \u003e As the question you mentioned: \"If no server has the lock to execute the sync methods, we\u0027ll never execute them\", I think the first restart neutron server can successfully \"OvnNbSynchronizer\", becase the IDL \"OvnNbSynchronizer\" is delayed for 10 seconds, which is just the time for \"DBInconsistenciesPeriodics\" successful locking.\n\u003e \u003e \u003e Of course, I have another question. Can the same IDL request two locks, one for \"DBInconsistenciesPeriodics\" and the other for \"OvnNbSynchronizer\"。\n\u003e \u003e \n\u003e \u003e Right, \"Ovn*Synchronizer\" classes sync methods are executed before the \"DBInconsistenciesPeriodics\" methods.\n\u003e \u003e \n\u003e \u003e Now this raises another problem: you are asking for a lock in the NB IDL that is set in \"DBInconsistenciesPeriodics\", AFTER using the NB IDL in \"OvnNbSynchronizer\" [1]\n\u003e \u003e \n\u003e \u003e What I suggest is, because you are checking for a lock in this IDL, to set if before using it in \"OvnNbSynchronizer\", just before [2].\n\u003e \u003e \n\u003e \u003e About having two locks in the same IDL instance, lock_name is unique [3]. Can be None or something else, but we can\u0027t have more than one.\n\u003e \u003e \n\u003e \u003e [1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n\u003e \u003e [2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L335\n\u003e \u003e [3]https://github.com/openvswitch/ovs/blob/d2e97030eda5dfafc875ec056788c49e2570d2ef/python/ovs/db/idl.py#L168\n\u003e \n\u003e Do you mean I move the lock of IDL to the front, such as this place [1], before the original position[2]?\n\u003e \n\u003e \n\u003e [1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L317\n\u003e \n\u003e [2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n\nNot to [1] because that will affect to any other worker, but to [0], just before instantiating OvnNbSynchronizer. And yes, remove them from [2].\n\n[0]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L333","accounts_in_message":[],"_revision_number":2},{"id":"d1bce52915005e5c610f0475150811295cb52918","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-14 16:11:03.000000000","message":"Patch Set 2:\n\nBuild Successful \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/2/SRIOV-neutron-macvtap : SUCCESS\n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/2/SRIOV-neutron-direct : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"35ee54c78180453471a08f7577142f5c1eae4da6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 01:28:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"023a9e5ed379d1c369c225bf1b16ab95f96e5e85","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 01:34:40.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2: Code-Review-1\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 1:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Please, format the commit message according to https://wiki.openstack.org/wiki/GitCommitMessages\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e As the question you mentioned: \"If no server has the lock to execute the sync methods, we\u0027ll never execute them\", I think the first restart neutron server can successfully \"OvnNbSynchronizer\", becase the IDL \"OvnNbSynchronizer\" is delayed for 10 seconds, which is just the time for \"DBInconsistenciesPeriodics\" successful locking.\n\u003e \u003e \u003e \u003e Of course, I have another question. Can the same IDL request two locks, one for \"DBInconsistenciesPeriodics\" and the other for \"OvnNbSynchronizer\"。\n\u003e \u003e \u003e \n\u003e \u003e \u003e Right, \"Ovn*Synchronizer\" classes sync methods are executed before the \"DBInconsistenciesPeriodics\" methods.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Now this raises another problem: you are asking for a lock in the NB IDL that is set in \"DBInconsistenciesPeriodics\", AFTER using the NB IDL in \"OvnNbSynchronizer\" [1]\n\u003e \u003e \u003e \n\u003e \u003e \u003e What I suggest is, because you are checking for a lock in this IDL, to set if before using it in \"OvnNbSynchronizer\", just before [2].\n\u003e \u003e \u003e \n\u003e \u003e \u003e About having two locks in the same IDL instance, lock_name is unique [3]. Can be None or something else, but we can\u0027t have more than one.\n\u003e \u003e \u003e \n\u003e \u003e \u003e [1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n\u003e \u003e \u003e [2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L335\n\u003e \u003e \u003e [3]https://github.com/openvswitch/ovs/blob/d2e97030eda5dfafc875ec056788c49e2570d2ef/python/ovs/db/idl.py#L168\n\u003e \u003e \n\u003e \u003e Do you mean I move the lock of IDL to the front, such as this place [1], before the original position[2]?\n\u003e \u003e \n\u003e \u003e \n\u003e \u003e [1]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L317\n\u003e \u003e \n\u003e \u003e [2]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#L138-L139\n\u003e \n\u003e Not to [1] because that will affect to any other worker, but to [0], just before instantiating OvnNbSynchronizer. And yes, remove them from [2].\n\u003e \n\u003e [0]https://github.com/openstack/neutron/blob/3cae410b3094e74549a1941e0b7d833229ae51d5/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L333\n\nyes, I agree with your suggestion. As shown in the modification.\n\nAnd i also has a question: why if another neutron server uses a different lock name can lock the same OVN NB Server and can operate this DB? \nThe same ovsdb resource can be locked by two IDLS as long as the name of the lock is different?","accounts_in_message":[],"_revision_number":3},{"id":"a904fe0c5bbdd7d298d92169eda25014c06506ba","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 02:10:22.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/20c350feefab43fab080c2f40347896c : SUCCESS in 37m 29s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ef6bb73a7fcd4cdd8991619abc58390b : SUCCESS in 38m 52s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d6f5347348e67e90b2c176d3ae3e84ab2d93c87a","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-15 03:02:09.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Neutron Hyper-V CI, add a review comment with run-Cloudbase Neutron Hyper-V CI\n\n- neutron http://cloudbase-ci.com/neutron/800751/3 : FAILURE in 1h 32m 37s","accounts_in_message":[],"_revision_number":3},{"id":"9ec385e137b7c3294019eb7afb76ed188f82fb83","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-15 03:02:31.000000000","message":"Patch Set 3:\n\nBuild Failed \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/3/SRIOV-neutron-macvtap : ABORTED","accounts_in_message":[],"_revision_number":3},{"id":"f477bacf696d001c071aa816912c11d108d7f006","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 03:33:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/108dc8e31cbc4f78b8bcad0c855556c9 : SUCCESS in 41m 59s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/6ac882b26dd64c6483c0b9b604456dc2 : SUCCESS in 1h 59m 59s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/89cc286eb8c44422b0f28431d35033c3 : SUCCESS in 37m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fbe2b2b2aec34691a38590231b25ccc1 : SUCCESS in 38m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d461071838654f9993dc5056a322488f : SUCCESS in 14m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/53687d897d3b4fbf8d8cd91dfa31e485 : SUCCESS in 28m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/377c3e4da047485280765e5e4af04177 : SUCCESS in 24m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c8e301d1b49d4c2b8884485e11013067 : SUCCESS in 27m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9e08d5e9c38f4b3db9cf93cb46b91481 : SUCCESS in 9m 00s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/83475deabef34415b0377956b41cb7da : SUCCESS in 49m 48s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/adf3d54289924ea88538a392fafb04d0 : SUCCESS in 1h 00m 52s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/2d90067ee2e6484898c21235c66b50e8 : SUCCESS in 33m 55s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/73fbd2a981c64def87e244ed94f09916 : SUCCESS in 1h 12m 23s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/24c0335998a24d3cad81084de944949a : SUCCESS in 1h 16m 23s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"faa159158b1bc9c6f9810588fd8f6765dd037a23","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-15 07:19:52.000000000","message":"Patch Set 3:\n\nBuild Successful \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/3/SRIOV-neutron-macvtap : SUCCESS\n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/3/SRIOV-neutron-direct : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"669caf3d579460897cf2233a914ea6233d6ff18b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 09:09:03.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ea1bf5fc82a10fa0a906a5ba408941f7083cd8b3","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 09:44:19.000000000","message":"Patch Set 4:\n\n(3 comments)\n\nQuestions inline","accounts_in_message":[],"_revision_number":4},{"id":"bbc1fe3ecff69226146868e215c18947aae73009","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 09:45:23.000000000","message":"Patch Set 4:\n\nTemporary -1 until the questions are answered","accounts_in_message":[],"_revision_number":4},{"id":"beddcacf8dfe4e27db9e9ffe3bd2761deaf1909b","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 09:45:27.000000000","message":"Patch Set 4: Code-Review-1","accounts_in_message":[],"_revision_number":4},{"id":"e2cdf8848f4b0a02487cbaea98c16b70d24df8a7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 09:49:55.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8659d83710ee4de59e6a18c8f6f5b7a0 : SUCCESS in 28m 59s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/cfa6066efdde48299024ad61ac7c0a76 : SUCCESS in 39m 01s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"6d6dc9120535740aadc8d91e3f12617e7c53a5cf","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-15 10:09:29.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"43cbc484648f506c5f492a47bc84d1e0d89dddda","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 10:32:14.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"b5f59f80eaab019eaca96aa54d50a543089027d1","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 10:33:25.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"093b67d31bddeb4466ccf36505fafca0f8161110","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-15 10:37:51.000000000","message":"Patch Set 4:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/800751/4 : SUCCESS in 1h 28m 04s","accounts_in_message":[],"_revision_number":4},{"id":"714eb59b9231a3fe655d83ca904a8836416a007f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 11:39:25.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/d98415fb1069466bb86c37acf2b08c7d : SUCCESS in 32m 30s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/e1a64e06825549aeb6188b8838b7aaf7 : SUCCESS in 2h 25m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6b65471b08d84768ad83094c7323b2ac : SUCCESS in 26m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1cc49adf768e448da6d04a7cdc0041ce : SUCCESS in 32m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/93cd56a895704a808998f05b426cc22b : SUCCESS in 12m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/298dc9d0d26d4bdeb43afe3b575e6130 : SUCCESS in 24m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bf42704bc3494469add21d264cb2f579 : SUCCESS in 23m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3d7f2bd49f874ec69dfc89b50c3514b2 : SUCCESS in 23m 47s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8da81a6a5c4b4731893f214ec1fd2e93 : SUCCESS in 9m 07s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/faa7c6201ad04ef2a317860d5f0c39c8 : SUCCESS in 45m 44s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/81e28ca92e4a42daa8dbcde81b931a40 : SUCCESS in 49m 53s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/5307e0e6fcd94cdd9ab59b457dd0452c : SUCCESS in 32m 55s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/a4b22468a0b1400da83cd780b2bec2d2 : SUCCESS in 1h 04m 51s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/d558298ddc164f67b0f99218d450a0c8 : SUCCESS in 1h 11m 19s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"e867cd9fc1b5a83478644465ca55846779898816","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 11:44:57.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e (3 comments)\n\u003e \n\u003e Questions inline\n\nneutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py\nLine 351\nYeah,check the NB lock in \"nb_synchronizer.sync()\" method  and we should check for is_lock_contended here , i think this is ok\n\nneutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py\nLine 101\nI also think it is no need to account for that has_lock/is_lock_contended in the script itself\n\nhttps://github.com/openstack/neutron/blob/603951809a45797697135e03eb4870c094371480/neutron/cmd/ovn/neutron_ovn_db_sync_util.py#L235-L242\n\nLine 1238\nQ: Do we also need a lock for SB DB here ?\ndue SB NB lock , \"OvnSbSynchronizer.do_sync\" method is just do sync to mariadb db, not sync to sb nb, so it is not need a lock.\nhttps://review.opendev.org/c/openstack/neutron/+/800751/4/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py#L1245-L1272","accounts_in_message":[],"_revision_number":4},{"id":"9af35110a8d83eb26864ec47997ff018dba7fa44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 11:47:26.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"8eb02edf47c3314800c440b08d8c3bd6831a3d71","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-15 11:51:21.000000000","message":"Patch Set 4:\n\nBuild Failed \n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/4/SRIOV-neutron-direct : ABORTED\n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/4/SRIOV-neutron-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"3c633a59cd8a04c076d88fe38e0076e77879f7d8","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2021-07-15 12:21:19.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"0742e212c1f36a97a25c784893944903d520f5f5","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 12:27:28.000000000","message":"Patch Set 5:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ffaa38df14de4b9a9ebd66b47491ce68 : SUCCESS in 38m 22s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b1097c2466b74e8ab2fa70197c134215 : SUCCESS in 30m 34s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"1b52e25c50cbdbfa79bf01c2cffd9c6c9f02a3a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-15 12:34:54.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c387b3c664251b5e24ecb74cf848fc9deea7c9ee","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-15 12:36:48.000000000","message":"Patch Set 5:\n\nBuild Failed \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/5/SRIOV-neutron-macvtap : ABORTED","accounts_in_message":[],"_revision_number":5},{"id":"0af6245bb0a1ce3be990387683643b49cc39b346","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-07-15 12:56:59.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"8eb0b8da6b35305bf370862226b6497155e85f58","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 13:17:39.000000000","message":"Patch Set 6:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/24a382af648f4b10b349888c54ed1aa9 : SUCCESS in 31m 38s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/5dc28f93e2e0479381294f78312f5fee : SUCCESS in 39m 17s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"f15f32778c2e1689f2ce06d87ac7d661edef6efa","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-15 14:16:55.000000000","message":"Patch Set 6:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/800751/6 : SUCCESS in 1h 40m 54s","accounts_in_message":[],"_revision_number":6},{"id":"b8634344463340f7e6d8b893491b03a5a6297938","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 14:17:16.000000000","message":"Patch Set 6: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/166b0e70946f4be2bcca8af925e320c5 : SUCCESS in 44m 42s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/9134802418cf487299e06659debd57f0 : SUCCESS in 1h 32m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ec32ddf7413b4a94ace9cf9d5cef1d91 : SUCCESS in 37m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c20c6984d96a4bd1961c1b9180f41987 : SUCCESS in 33m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c4741bd7c714e358ef9eb6adfb35088 : FAILURE in 7m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c62cc013f8db4a9c94a78db139d075a0 : SUCCESS in 23m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/54b80183de03418b90afe586b9627a17 : SUCCESS in 21m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/61b3c45b22d540eda66a15ff2d89a10d : SUCCESS in 21m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95feb6f9ba194c7e8bb36df0fcfc7c34 : SUCCESS in 10m 42s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/ac7b1351001a4c838e677680cbd82820 : FAILURE in 45m 34s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/0cd14625aaa047a8a47735eb4c00d3f6 : SUCCESS in 51m 50s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/4f121b252a8e456ebe2c4cfbec1b9463 : SUCCESS in 32m 48s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/960ee96f04264c2797673274aaae7421 : SUCCESS in 1h 06m 46s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/3b7610f7da5f4336918fd1a96baf9878 : SUCCESS in 1h 08m 21s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"b6d5bd33ede3fe299dfe30d0e7ee0e519cbc3e45","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-15 14:36:32.000000000","message":"Patch Set 6:\n\nBuild Successful \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/6/SRIOV-neutron-macvtap : SUCCESS\n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/6/SRIOV-neutron-direct : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"e75c1fac54c743bb07de1c359519f37886dd1fa0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"date":"2021-07-16 01:18:22.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"8935e665815e32a1016384b0f9fe95cbb174fc37","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-16 02:06:01.000000000","message":"Patch Set 7:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/844738efe05c4dd8b63864bb11a127af : SUCCESS in 45m 57s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/0db8c2fc502c4af08c6e8f39be2e635d : SUCCESS in 45m 46s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"5ff825b4f495c83ff52ad52e48dcd7eab912af62","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-16 03:16:39.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/6796267ae7924ca3bd1dae646aaa462b : POST_FAILURE in 1h 11m 14s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/4c563acde417460f90a01da4c80295dd : SUCCESS in 1h 56m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0b001bdf9d4d46aead52c9712f58bfb2 : SUCCESS in 37m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fe45c4aee23c4509a9f1de5030aceda4 : SUCCESS in 38m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/66440281c21648dc85f60b9630b83561 : SUCCESS in 15m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/de34536c77e64fd087ff6e4c2572bbd7 : SUCCESS in 28m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/397c498a275f4694918f4ebb2b39ee23 : SUCCESS in 29m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/792765ee61264cfba00f70dc457a93d6 : SUCCESS in 27m 57s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a7d5146c17f4b2883225af2aaaa0bdf : SUCCESS in 9m 52s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/560f7a4aac214d3990d16cc68cd887e8 : FAILURE in 51m 12s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/b1bf2867e36f4ac3a3924db3ccffeb5c : SUCCESS in 52m 10s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/7424c3c82d4b47ee9fea6dfafc1d703c : SUCCESS in 31m 15s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/4a1c5b61339f49669da907fc2313fbcd : SUCCESS in 1h 14m 37s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/2a55de1660b5406db5e48a92dc9c0c95 : SUCCESS in 1h 05m 09s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"46abb18d10654ccd5e8462c1cbe0507aa8b41d6f","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2021-07-16 03:54:40.000000000","message":"Patch Set 7:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/800751/7 : SUCCESS in 1h 42m 13s","accounts_in_message":[],"_revision_number":7},{"id":"d2e4b8d15ec4abba457dd964a6c7cf63518b648b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-16 06:30:04.000000000","message":"Patch Set 7:\n\nBuild Successful \n\n* SRIOV-neutron-macvtap http://13.74.249.42/refs/changes/51/800751/7/SRIOV-neutron-macvtap : SUCCESS\n\n* SRIOV-neutron-direct http://13.74.249.42/refs/changes/51/800751/7/SRIOV-neutron-direct : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"fa76c8bc69f28592e61002afac05009ba15ceffe","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:05:38.000000000","message":"Patch Set 1:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":1},{"id":"fab49e4dfee062916ccede964631a1182f3d8684","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:11:16.000000000","message":"Patch Set 2:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":2},{"id":"e99bb7e7836a57c2e91db3557a123892b3f20cba","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:16:49.000000000","message":"Patch Set 3:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":3},{"id":"7b0075286b9abec248baf768d6e2047f7d031323","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:18:13.000000000","message":"Patch Set 4:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":4},{"id":"39822a5b9619a3e2fe24228ec4756ba77b6e921a","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:20:59.000000000","message":"Patch Set 5:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":5},{"id":"bd961455ef326f21929914cd9a807441422d3ba4","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:22:22.000000000","message":"Patch Set 6:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":6},{"id":"02305c3717b6ac1aacbb1c38e7f2c488d43c9469","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2021-07-19 21:34:51.000000000","message":"Patch Set 7:\n\nArista third party testing FAILED [ Failed to upload log files ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":7},{"id":"39b4c73d0ba7a20a46d41e494b34044ec9c79024","tag":"autogenerated:gerrit:abandon","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-10-14 16:15:50.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"0cf1d49cf6fe04dd08626f2da888d96ac9e92bc8","revisions":{"c479d79edfc297d87d97a8ea1fa0d3dafec36d32":{"kind":"REWORK","_number":1,"created":"2021-07-14 08:17:52.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/1"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:44.000000000","tz":480},"subject":"In \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\". This class methods check the lock status but not the OvnNbSynchronizer\" class, sharing the same NB_IDL. Because of that, see the txn.NOT_LOCKED errors in some servers and keep printing.","message":"In \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/c479d79edfc297d87d97a8ea1fa0d3dafec36d32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/c479d79edfc297d87d97a8ea1fa0d3dafec36d32"}]},"branch":"refs/heads/master"},"523f4948545db00d5266b8a39d8eca2ac5e67d68":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-07-14 10:59:25.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/2"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 10:58:58.000000000","tz":0},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/523f4948545db00d5266b8a39d8eca2ac5e67d68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/523f4948545db00d5266b8a39d8eca2ac5e67d68"}]},"branch":"refs/heads/master","description":"Edit commit message"},"22fe34cf468d19a231eb7a73416b0a0ddc73435c":{"kind":"REWORK","_number":3,"created":"2021-07-15 01:28:51.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/3"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-15 01:28:13.000000000","tz":480},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/22fe34cf468d19a231eb7a73416b0a0ddc73435c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/22fe34cf468d19a231eb7a73416b0a0ddc73435c"}]},"branch":"refs/heads/master"},"b2a2e3202541c2a6357c177d6037ab313c3c3486":{"kind":"REWORK","_number":4,"created":"2021-07-15 09:09:03.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/4"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-15 09:08:29.000000000","tz":480},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/b2a2e3202541c2a6357c177d6037ab313c3c3486"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/b2a2e3202541c2a6357c177d6037ab313c3c3486"}]},"branch":"refs/heads/master"},"7d73ba5e4f2972571386b0793e7c2f4009cba12f":{"kind":"REWORK","_number":5,"created":"2021-07-15 11:47:26.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/5"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-15 11:46:50.000000000","tz":480},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/7d73ba5e4f2972571386b0793e7c2f4009cba12f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/7d73ba5e4f2972571386b0793e7c2f4009cba12f"}]},"branch":"refs/heads/master"},"fed179e8a22f30ef98042d273e094de96dc117b3":{"kind":"REWORK","_number":6,"created":"2021-07-15 12:34:54.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/6"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-15 12:34:22.000000000","tz":480},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/fed179e8a22f30ef98042d273e094de96dc117b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/fed179e8a22f30ef98042d273e094de96dc117b3"}]},"branch":"refs/heads/master"},"0cf1d49cf6fe04dd08626f2da888d96ac9e92bc8":{"kind":"REWORK","_number":7,"created":"2021-07-16 01:18:22.000000000","uploader":{"_account_id":32020,"name":"zhangtongjian","email":"zhangtj03@inspur.com","username":"zhangtongjian"},"ref":"refs/changes/51/800751/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/51/800751/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/51/800751/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/51/800751/7"}}},"commit":{"parents":[{"commit":"3cae410b3094e74549a1941e0b7d833229ae51d5","subject":"use payloads for PORT AFTER_DELETE events","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3cae410b3094e74549a1941e0b7d833229ae51d5"}]}],"author":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-14 08:12:35.000000000","tz":480},"committer":{"name":"zhangtongjian","email":"125163227@qq.com","date":"2021-07-16 01:17:41.000000000","tz":480},"subject":"add has lock judgment for OvnNbSynchronizer","message":"add has lock judgment for OvnNbSynchronizer\n\nIn \"DBInconsistenciesPeriodics\", we set a lock named \"ovn_db_inconsistencies_periodics\".\nThis class methods check the lock status but not the OvnNbSynchronizer\" class,\nsharing the same NB_IDL.\nBecause of that, see the txn.NOT_LOCKED errors in some servers and keep printing.\n\nCloses-Bug: #1935888\n\nChange-Id: I3581053f5ea5fecd6a32b193efc8f7055605ca73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/0cf1d49cf6fe04dd08626f2da888d96ac9e92bc8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/0cf1d49cf6fe04dd08626f2da888d96ac9e92bc8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}