)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":33145,"name":"Kevin Li","email":"liwenhai3@huawei.com","username":"liwenhai"},"change_message_id":"006ed72f8507447e1f3b693ab8e67b69143b370c","unresolved":true,"context_lines":[{"line_number":835,"context_line":"        # cir and cbs should be set in bytes instead of bits"},{"line_number":836,"context_line":"        qos_other_config \u003d {"},{"line_number":837,"context_line":"            \u0027cir\u0027: str(int(max_bw_in_bits / 8)),"},{"line_number":838,"context_line":"            \u0027cbs\u0027: str(int(max_burst_in_bits / 8))"},{"line_number":839,"context_line":"        }"},{"line_number":840,"context_line":"        qos \u003d self.find_qos(port_name)"},{"line_number":841,"context_line":"        qos_uuid \u003d qos[\u0027_uuid\u0027] if qos else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ee93006_48be2c2b","line":838,"updated":"2021-07-21 01:23:48.000000000","message":"max_bw_in_bits // 8\nmax_burst_in_bits // 8\n\nswitch to python3 grammar","commit_id":"4c953374d46f1afa07239ba3cf88ce85269708bd"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f4c60c2df62be2429c6b40842a444e463f771c8f","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        # cir and cbs should be set in bytes instead of bits"},{"line_number":836,"context_line":"        qos_other_config \u003d {"},{"line_number":837,"context_line":"            \u0027cir\u0027: str(int(max_bw_in_bits / 8)),"},{"line_number":838,"context_line":"            \u0027cbs\u0027: str(int(max_burst_in_bits / 8))"},{"line_number":839,"context_line":"        }"},{"line_number":840,"context_line":"        qos \u003d self.find_qos(port_name)"},{"line_number":841,"context_line":"        qos_uuid \u003d qos[\u0027_uuid\u0027] if qos else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9527275_29b8d3df","line":838,"in_reply_to":"3ee93006_48be2c2b","updated":"2021-07-21 12:10:56.000000000","message":"Done","commit_id":"4c953374d46f1afa07239ba3cf88ce85269708bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4463ad0b07f35d543b2abb059430d37ea270bddb","unresolved":true,"context_lines":[{"line_number":806,"context_line":"    def _update_ingress_bw_limit_for_port("},{"line_number":807,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":808,"context_line":"        qos_other_config \u003d {"},{"line_number":809,"context_line":"            \u0027max-rate\u0027: str(int(max_bw_in_bits))"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":"        queue_other_config \u003d {"},{"line_number":812,"context_line":"            \u0027max-rate\u0027: str(int(max_bw_in_bits)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"65bfc2d0_1f8d5c39","line":809,"range":{"start_line":809,"start_character":28,"end_line":809,"end_character":31},"updated":"2021-07-21 13:08:22.000000000","message":"That\u0027s weird because max_bw_in_bits \u003d max_kbps * p_const.SI_BASE, and max_kbps is an integer value coming from the API. The problem related in the bug won\u0027t affect here.\n\nIn any case, that won\u0027t hurt.","commit_id":"8261b67b6e6248c5cc1a4426544188e5bd9bfa03"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"cca28eb871a3ceff1b5d00bdddfa9e8d50ee1572","unresolved":true,"context_lines":[{"line_number":806,"context_line":"    def _update_ingress_bw_limit_for_port("},{"line_number":807,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":808,"context_line":"        qos_other_config \u003d {"},{"line_number":809,"context_line":"            \u0027max-rate\u0027: str(int(max_bw_in_bits))"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":"        queue_other_config \u003d {"},{"line_number":812,"context_line":"            \u0027max-rate\u0027: str(int(max_bw_in_bits)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ff44f30_581c0173","line":809,"range":{"start_line":809,"start_character":28,"end_line":809,"end_character":31},"in_reply_to":"65bfc2d0_1f8d5c39","updated":"2021-07-22 11:47:15.000000000","message":"Yes, the bug is only present where the division happens. I did put this here not because it changes the behavior, but for the next reader of the code to notice, this must be an int.","commit_id":"8261b67b6e6248c5cc1a4426544188e5bd9bfa03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4463ad0b07f35d543b2abb059430d37ea270bddb","unresolved":true,"context_lines":[{"line_number":834,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":835,"context_line":"        # cir and cbs should be set in bytes instead of bits"},{"line_number":836,"context_line":"        qos_other_config \u003d {"},{"line_number":837,"context_line":"            \u0027cir\u0027: str(max_bw_in_bits // 8),"},{"line_number":838,"context_line":"            \u0027cbs\u0027: str(max_burst_in_bits // 8)"},{"line_number":839,"context_line":"        }"},{"line_number":840,"context_line":"        qos \u003d self.find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"032dd991_fc678bed","line":837,"range":{"start_line":837,"start_character":38,"end_line":837,"end_character":41},"updated":"2021-07-21 13:08:22.000000000","message":"good suggestion by Kevin","commit_id":"8261b67b6e6248c5cc1a4426544188e5bd9bfa03"}]}