)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"cbcb76bb5af4644c70d39599bdd553060fd94a0e","unresolved":true,"context_lines":[{"line_number":1413,"context_line":"            payload\u003devents.DBEventPayload("},{"line_number":1414,"context_line":"                context, states\u003d(assoc_result,),"},{"line_number":1415,"context_line":"                resource_id\u003dfloatingip_obj.id,"},{"line_number":1416,"context_line":"                metadata\u003d{"},{"line_number":1417,"context_line":"                    \u0027association_event\u0027: assoc_result[\u0027association_event\u0027]}))"},{"line_number":1418,"context_line":"        if assoc_result[\u0027association_event\u0027]:"},{"line_number":1419,"context_line":"            LOG.info(FIP_ASSOC_MSG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f6ce144_f7bea3a9","line":1416,"updated":"2021-07-20 14:01:21.000000000","message":"Why we need use metadata here? \u0027association_event\u0027 in handler we can get from states.","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"c5e32187b79c2b3fcaf4fcbf6e6d1d183e2446ac","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"            payload\u003devents.DBEventPayload("},{"line_number":1414,"context_line":"                context, states\u003d(assoc_result,),"},{"line_number":1415,"context_line":"                resource_id\u003dfloatingip_obj.id,"},{"line_number":1416,"context_line":"                metadata\u003d{"},{"line_number":1417,"context_line":"                    \u0027association_event\u0027: assoc_result[\u0027association_event\u0027]}))"},{"line_number":1418,"context_line":"        if assoc_result[\u0027association_event\u0027]:"},{"line_number":1419,"context_line":"            LOG.info(FIP_ASSOC_MSG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"04f14476_de1ac979","line":1416,"in_reply_to":"3f6ce144_f7bea3a9","updated":"2021-07-20 15:17:53.000000000","message":"Because while indeed association_event is in assoc_result dict, states parameter should be used only for state (fields) of FloatingIP, which association_event is not. For additional data metadata field should be used.\n\nDict passed as state is fixed in next patch in chain.\nIt will no longer contain association_event.","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"cbcb76bb5af4644c70d39599bdd553060fd94a0e","unresolved":true,"context_lines":[{"line_number":1480,"context_line":"            payload\u003devents.DBEventPayload("},{"line_number":1481,"context_line":"                context, states\u003d(assoc_result,),"},{"line_number":1482,"context_line":"                resource_id\u003dfloatingip_obj.id,"},{"line_number":1483,"context_line":"                metadata\u003d{"},{"line_number":1484,"context_line":"                    \u0027association_event\u0027: assoc_result[\u0027association_event\u0027]}))"},{"line_number":1485,"context_line":"        if assoc_result[\u0027association_event\u0027] is not None:"},{"line_number":1486,"context_line":"            port_id \u003d old_fixed_port_id or assoc_result[\u0027fixed_port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"99bf4713_6818f79a","line":1483,"updated":"2021-07-20 14:01:21.000000000","message":"Ditto","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"c5e32187b79c2b3fcaf4fcbf6e6d1d183e2446ac","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"            payload\u003devents.DBEventPayload("},{"line_number":1481,"context_line":"                context, states\u003d(assoc_result,),"},{"line_number":1482,"context_line":"                resource_id\u003dfloatingip_obj.id,"},{"line_number":1483,"context_line":"                metadata\u003d{"},{"line_number":1484,"context_line":"                    \u0027association_event\u0027: assoc_result[\u0027association_event\u0027]}))"},{"line_number":1485,"context_line":"        if assoc_result[\u0027association_event\u0027] is not None:"},{"line_number":1486,"context_line":"            port_id \u003d old_fixed_port_id or assoc_result[\u0027fixed_port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"20f7dc9b_c766dca4","line":1483,"in_reply_to":"99bf4713_6818f79a","updated":"2021-07-20 15:17:53.000000000","message":"Ack","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"580579328fbb2770fef31dccfdfb3d7f12d1b2c4","unresolved":true,"context_lines":[{"line_number":1687,"context_line":"            # Process DNS record removal after committing the transaction"},{"line_number":1688,"context_line":"            if self._is_dns_integration_supported:"},{"line_number":1689,"context_line":"                self._process_dns_floatingip_delete(context, fip.to_dict())"},{"line_number":1690,"context_line":"            registry.notify(resources.FLOATING_IP, events.AFTER_UPDATE, self,"},{"line_number":1691,"context_line":"                            **assoc_result)"},{"line_number":1692,"context_line":"            registry.publish("},{"line_number":1693,"context_line":"                resources.FLOATING_IP, events.AFTER_UPDATE, self,"},{"line_number":1694,"context_line":"                payload\u003devents.DBEventPayload("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a598a95_2d6446f1","line":1691,"range":{"start_line":1690,"start_character":12,"end_line":1691,"end_character":43},"updated":"2021-07-21 07:15:36.000000000","message":"seems should be removed","commit_id":"eddfae6b4ab04941ad4482893b047b5dc67e50f8"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"5d24a9f89377152b239efc75f8af1d314bca43db","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"            # Process DNS record removal after committing the transaction"},{"line_number":1688,"context_line":"            if self._is_dns_integration_supported:"},{"line_number":1689,"context_line":"                self._process_dns_floatingip_delete(context, fip.to_dict())"},{"line_number":1690,"context_line":"            registry.notify(resources.FLOATING_IP, events.AFTER_UPDATE, self,"},{"line_number":1691,"context_line":"                            **assoc_result)"},{"line_number":1692,"context_line":"            registry.publish("},{"line_number":1693,"context_line":"                resources.FLOATING_IP, events.AFTER_UPDATE, self,"},{"line_number":1694,"context_line":"                payload\u003devents.DBEventPayload("}],"source_content_type":"text/x-python","patch_set":2,"id":"c2680f9e_97283807","line":1691,"range":{"start_line":1690,"start_character":12,"end_line":1691,"end_character":43},"in_reply_to":"7a598a95_2d6446f1","updated":"2021-07-21 09:26:51.000000000","message":"Oh, good catch, I have no idea how I missed that.","commit_id":"eddfae6b4ab04941ad4482893b047b5dc67e50f8"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e42723ea8dd745bc6c96e12863a81681c85a0484","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            # FloatingIP agent gateway port"},{"line_number":452,"context_line":"            if router_dict.get(\u0027distributed\u0027):"},{"line_number":453,"context_line":"                hostid \u003d self._get_dvr_service_port_hostid("},{"line_number":454,"context_line":"                    payload.context, fip[\u0027fixed_port_id\u0027])"},{"line_number":455,"context_line":"                if hostid:"},{"line_number":456,"context_line":"                    # FIXME (Swami): This FIP Agent Gateway port should be"},{"line_number":457,"context_line":"                    # created only once and there should not be a duplicate"}],"source_content_type":"text/x-python","patch_set":1,"id":"92a79b53_4ae2ff85","line":454,"range":{"start_line":454,"start_character":20,"end_line":454,"end_character":35},"updated":"2021-07-20 14:15:51.000000000","message":"nit: could just do \"context \u003d payload.context\" in the beginning","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"c5e32187b79c2b3fcaf4fcbf6e6d1d183e2446ac","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            # FloatingIP agent gateway port"},{"line_number":452,"context_line":"            if router_dict.get(\u0027distributed\u0027):"},{"line_number":453,"context_line":"                hostid \u003d self._get_dvr_service_port_hostid("},{"line_number":454,"context_line":"                    payload.context, fip[\u0027fixed_port_id\u0027])"},{"line_number":455,"context_line":"                if hostid:"},{"line_number":456,"context_line":"                    # FIXME (Swami): This FIP Agent Gateway port should be"},{"line_number":457,"context_line":"                    # created only once and there should not be a duplicate"}],"source_content_type":"text/x-python","patch_set":1,"id":"edc5c76e_2781a9c4","line":454,"range":{"start_line":454,"start_character":20,"end_line":454,"end_character":35},"in_reply_to":"92a79b53_4ae2ff85","updated":"2021-07-20 15:17:53.000000000","message":"Ack","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e42723ea8dd745bc6c96e12863a81681c85a0484","unresolved":true,"context_lines":[{"line_number":475,"context_line":"                    # have a device_owner and ports that are owned by the"},{"line_number":476,"context_line":"                    # dvr service ports except for the compute port and"},{"line_number":477,"context_line":"                    # dhcp port."},{"line_number":478,"context_line":"                    if (port[\u0027device_owner\u0027] \u003d\u003d \u0027\u0027 or"},{"line_number":479,"context_line":"                            port[\u0027device_owner\u0027] in allowed_device_owners):"},{"line_number":480,"context_line":"                        addr_pair_active_service_port_list \u003d ("},{"line_number":481,"context_line":"                            self._get_ports_for_allowed_address_pair_ip("}],"source_content_type":"text/x-python","patch_set":1,"id":"0b126be4_7c49c335","line":478,"range":{"start_line":478,"start_character":48,"end_line":478,"end_character":50},"updated":"2021-07-20 14:15:51.000000000","message":"please avoid unrelated changes","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"c5e32187b79c2b3fcaf4fcbf6e6d1d183e2446ac","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                    # have a device_owner and ports that are owned by the"},{"line_number":476,"context_line":"                    # dvr service ports except for the compute port and"},{"line_number":477,"context_line":"                    # dhcp port."},{"line_number":478,"context_line":"                    if (port[\u0027device_owner\u0027] \u003d\u003d \u0027\u0027 or"},{"line_number":479,"context_line":"                            port[\u0027device_owner\u0027] in allowed_device_owners):"},{"line_number":480,"context_line":"                        addr_pair_active_service_port_list \u003d ("},{"line_number":481,"context_line":"                            self._get_ports_for_allowed_address_pair_ip("}],"source_content_type":"text/x-python","patch_set":1,"id":"a90f7888_66438b1c","line":478,"range":{"start_line":478,"start_character":48,"end_line":478,"end_character":50},"in_reply_to":"0b126be4_7c49c335","updated":"2021-07-20 15:17:53.000000000","message":"Ack","commit_id":"994ffc3e817a8cee4a48599f77f13a3091a16678"}]}