)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"7d3b4e35c81b1f6a4aeabb56341dc6ffc0ccb52f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55e3b0ee_4854f21c","updated":"2021-11-15 05:04:00.000000000","message":"can someone help? would love to get this upstream!","commit_id":"5f0468558c390d42d6b1608a29fa8d6af6aad355"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2c31f1ffb5d0ac55ef432fda9ddbbe99bbac1489","unresolved":true,"context_lines":[{"line_number":299,"context_line":"                for acla in neutron_acls:"},{"line_number":300,"context_line":"                    LOG.warning(\u0027ACL found in Neutron but not in \u0027"},{"line_number":301,"context_line":"                                \u0027OVN DB for port group %s\u0027, acla[\u0027port_group\u0027])"},{"line_number":302,"context_line":"                    txn.add(self.ovn_api.pg_acl_add(**acla, may_exist\u003dTrue))"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            with self.ovn_api.transaction(check_error\u003dTrue) as txn:"},{"line_number":305,"context_line":"                for aclr in ovn_acls:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0885c12_e63605d8","line":302,"range":{"start_line":302,"start_character":41,"end_line":302,"end_character":51},"updated":"2021-07-22 07:35:01.000000000","message":"In that case, you\u0027ll add one single OVN register having more than one Neutron ACL. What happens when the ACL is being deleted? Will fhe second register fail when executing pg_acl_del on the same OVN register (that is already deleted)?","commit_id":"5f0468558c390d42d6b1608a29fa8d6af6aad355"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c92403e73458b233b425bc7e4e8fa471bb02c486","unresolved":true,"context_lines":[{"line_number":299,"context_line":"                for acla in neutron_acls:"},{"line_number":300,"context_line":"                    LOG.warning(\u0027ACL found in Neutron but not in \u0027"},{"line_number":301,"context_line":"                                \u0027OVN DB for port group %s\u0027, acla[\u0027port_group\u0027])"},{"line_number":302,"context_line":"                    txn.add(self.ovn_api.pg_acl_add(**acla, may_exist\u003dTrue))"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            with self.ovn_api.transaction(check_error\u003dTrue) as txn:"},{"line_number":305,"context_line":"                for aclr in ovn_acls:"}],"source_content_type":"text/x-python","patch_set":1,"id":"42d3fa28_afb40dfb","line":302,"range":{"start_line":302,"start_character":41,"end_line":302,"end_character":51},"in_reply_to":"0730b28f_2d61acc6","updated":"2022-02-21 12:02:57.000000000","message":"right, we need to replicate the existing code implemented in [1]\n\n[1]https://review.opendev.org/c/openstack/neutron/+/736386/6/neutron/common/ovn/acl.py","commit_id":"5f0468558c390d42d6b1608a29fa8d6af6aad355"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"ddb67fac2452cce75b75bc4e9ada3c49a9df8ae5","unresolved":true,"context_lines":[{"line_number":299,"context_line":"                for acla in neutron_acls:"},{"line_number":300,"context_line":"                    LOG.warning(\u0027ACL found in Neutron but not in \u0027"},{"line_number":301,"context_line":"                                \u0027OVN DB for port group %s\u0027, acla[\u0027port_group\u0027])"},{"line_number":302,"context_line":"                    txn.add(self.ovn_api.pg_acl_add(**acla, may_exist\u003dTrue))"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            with self.ovn_api.transaction(check_error\u003dTrue) as txn:"},{"line_number":305,"context_line":"                for aclr in ovn_acls:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0730b28f_2d61acc6","line":302,"range":{"start_line":302,"start_character":41,"end_line":302,"end_character":51},"in_reply_to":"f0885c12_e63605d8","updated":"2021-07-23 02:33:17.000000000","message":"What happens on a delete is that OVN will check if there are multiple SG rules with same normalized CIDR, and not do anything in OVN the first delete. See:\nhttps://opendev.org/openstack/neutron/src/commit/17f2ba3afbbbb929155c2ac3fa396784badd981b/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L361-L366","commit_id":"5f0468558c390d42d6b1608a29fa8d6af6aad355"}]}