)]}'
{"neutron/plugins/vmware/plugins/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74a1d01a2e41753209a638c5c8e069f974863160","unresolved":false,"context_lines":[{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        # Ensure the connection to the \u0027metadata access network\u0027"},{"line_number":1750,"context_line":"        # is removed  (with the network) if this the last subnet"},{"line_number":1751,"context_line":"        # on the router"},{"line_number":1752,"context_line":"        self.handle_router_metadata_access("},{"line_number":1753,"context_line":"            context, router_id, interface\u003dinfo)"},{"line_number":1754,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FzoU%3D","line":1751,"updated":"2014-03-13 17:26:57.000000000","message":"I\u0027d consider moving this line in the try-catch.","commit_id":"1174c580513147d681fb09319bd489538ae14215"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"bf445087eb1faa0f583c5717bc832443c285edb3","unresolved":false,"context_lines":[{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        # Ensure the connection to the \u0027metadata access network\u0027"},{"line_number":1750,"context_line":"        # is removed  (with the network) if this the last subnet"},{"line_number":1751,"context_line":"        # on the router"},{"line_number":1752,"context_line":"        self.handle_router_metadata_access("},{"line_number":1753,"context_line":"            context, router_id, interface\u003dinfo)"},{"line_number":1754,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fyko%3D","line":1751,"in_reply_to":"AAAAWH%2F%2FzoU%3D","updated":"2014-03-13 19:46:35.000000000","message":"Done","commit_id":"1174c580513147d681fb09319bd489538ae14215"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0f086e17ffbe501e2f0a84ff423322a9f4818258","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"            # is removed  (with the network) if this the last subnet"},{"line_number":1753,"context_line":"            # on the router"},{"line_number":1754,"context_line":"            self.handle_router_metadata_access("},{"line_number":1755,"context_line":"                context, router_id, interface\u003dinfo)"},{"line_number":1756,"context_line":"            if not subnet:"},{"line_number":1757,"context_line":"                subnet \u003d self._get_subnet(context, subnet_id)"},{"line_number":1758,"context_line":"            router \u003d self._get_router(context, router_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FxL0%3D","line":1755,"updated":"2014-03-13 22:52:32.000000000","message":"I think that moving handle_router_metadata access in the try...except block is a bit unrelated to this change. I think the handler function should already take care of router not found errors.\n\nalso, this won\u0027t even make a lot of sense if one uses metadata access through logical service nodes.","commit_id":"9be805e75ab6d519598d7006820446510e86ea6a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"66844f8a65b2963c78f53da6aa368c2a8c778bf9","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"            # is removed  (with the network) if this the last subnet"},{"line_number":1753,"context_line":"            # on the router"},{"line_number":1754,"context_line":"            self.handle_router_metadata_access("},{"line_number":1755,"context_line":"                context, router_id, interface\u003dinfo)"},{"line_number":1756,"context_line":"            if not subnet:"},{"line_number":1757,"context_line":"                subnet \u003d self._get_subnet(context, subnet_id)"},{"line_number":1758,"context_line":"            router \u003d self._get_router(context, router_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fwko%3D","line":1755,"in_reply_to":"AAAAWH%2F%2FxL0%3D","updated":"2014-03-14 00:22:27.000000000","message":"Sorry I didn\u0027t mean to rebase this. Armando commented on my first patch set saying to move this here. It should be fine either way it looks like to me.","commit_id":"9be805e75ab6d519598d7006820446510e86ea6a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f0792543a3229202b65fe689401459715e0efd98","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"            # is removed  (with the network) if this the last subnet"},{"line_number":1753,"context_line":"            # on the router"},{"line_number":1754,"context_line":"            self.handle_router_metadata_access("},{"line_number":1755,"context_line":"                context, router_id, interface\u003dinfo)"},{"line_number":1756,"context_line":"            if not subnet:"},{"line_number":1757,"context_line":"                subnet \u003d self._get_subnet(context, subnet_id)"},{"line_number":1758,"context_line":"            router \u003d self._get_router(context, router_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Frsk%3D","line":1755,"in_reply_to":"AAAAWH%2F%2FxL0%3D","updated":"2014-03-14 14:23:09.000000000","message":"a) The handle_router_metadata calls itself remove_router_interface\n\nb) notFound may be triggered regardless of the dhcp backend.","commit_id":"9be805e75ab6d519598d7006820446510e86ea6a"}]}