)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"985cfc987dc6971920f4ec958d700104cf7b5522","unresolved":true,"context_lines":[{"line_number":1477,"context_line":"                             self,"},{"line_number":1478,"context_line":"                             payload\u003devents.DBEventPayload("},{"line_number":1479,"context_line":"                                 context,"},{"line_number":1480,"context_line":"                                 metadata\u003d{\u0027floatingip_db\u0027: floatingip_db},"},{"line_number":1481,"context_line":"                                 states\u003d(old_floatingip, floatingip)))"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        registry.notify(resources.FLOATING_IP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"54ad2252_d16d4588","line":1480,"range":{"start_line":1480,"start_character":33,"end_line":1480,"end_character":41},"updated":"2021-08-03 13:54:27.000000000","message":"nit: why not desired state like previously?","commit_id":"aa98afdeca35f6fabbbbd70f5cfc0f0c9f6dba2a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"81b1c537259f9d816e41148102c0ad6a0fb24290","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"                             self,"},{"line_number":1478,"context_line":"                             payload\u003devents.DBEventPayload("},{"line_number":1479,"context_line":"                                 context,"},{"line_number":1480,"context_line":"                                 metadata\u003d{\u0027floatingip_db\u0027: floatingip_db},"},{"line_number":1481,"context_line":"                                 states\u003d(old_floatingip, floatingip)))"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        registry.notify(resources.FLOATING_IP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd4ed48d_9766c3c3","line":1480,"range":{"start_line":1480,"start_character":33,"end_line":1480,"end_character":41},"in_reply_to":"54ad2252_d16d4588","updated":"2021-08-03 14:50:03.000000000","message":"Done","commit_id":"aa98afdeca35f6fabbbbd70f5cfc0f0c9f6dba2a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"246772101d879abb6c83b43e90be0892a3765e6a","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1430,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1431,"context_line":"                        self._update_fip_assoc,"},{"line_number":1432,"context_line":"                        **assoc_result)"},{"line_number":1433,"context_line":"        if assoc_result[\u0027association_event\u0027]:"},{"line_number":1434,"context_line":"            LOG.info(FIP_ASSOC_MSG,"},{"line_number":1435,"context_line":"                     {\u0027fip_id\u0027: assoc_result[\u0027floating_ip_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"698b9d4d_414cd391","line":1432,"range":{"start_line":1432,"start_character":26,"end_line":1432,"end_character":38},"updated":"2021-08-11 06:47:14.000000000","message":"Why not covering this notify as well?\n(Note if it will be part of the patch in n-d-r this is used:\nhttps://opendev.org/openstack/neutron-dynamic-routing/src/branch/master/neutron_dynamic_routing/services/bgp/bgp_plugin.py#L80-L82 )","commit_id":"57cfc57da694da40eaeb6c825c5e4548d7d6d9bc"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0ce4af137a77de9163228d5e1bc9546d0a8efd1b","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1430,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1431,"context_line":"                        self._update_fip_assoc,"},{"line_number":1432,"context_line":"                        **assoc_result)"},{"line_number":1433,"context_line":"        if assoc_result[\u0027association_event\u0027]:"},{"line_number":1434,"context_line":"            LOG.info(FIP_ASSOC_MSG,"},{"line_number":1435,"context_line":"                     {\u0027fip_id\u0027: assoc_result[\u0027floating_ip_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"6b55819a_aa92182a","line":1432,"range":{"start_line":1432,"start_character":26,"end_line":1432,"end_character":38},"in_reply_to":"698b9d4d_414cd391","updated":"2021-08-11 07:26:54.000000000","message":"This one is covered in another patch: https://review.opendev.org/c/openstack/neutron/+/801453","commit_id":"57cfc57da694da40eaeb6c825c5e4548d7d6d9bc"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6c99f3aa57e9c762368c7ce4ba22dc8ff72730c3","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        # the request body must contain a \"port_id\" field which is not"},{"line_number":156,"context_line":"        # allowed in port forwarding functionality."},{"line_number":157,"context_line":"        context \u003d payload.context"},{"line_number":158,"context_line":"        floatingip \u003d payload.latest_state"},{"line_number":159,"context_line":"        floatingip_id \u003d None"},{"line_number":160,"context_line":"        if event \u003d\u003d events.PRECOMMIT_UPDATE:"},{"line_number":161,"context_line":"            fip_db \u003d payload.desired_state"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1df2bfa_8d470cbe","line":158,"range":{"start_line":158,"start_character":21,"end_line":158,"end_character":41},"updated":"2021-08-04 07:45:20.000000000","message":"latest_state is now desired_state, to get obj from states can use payload.states[-1]","commit_id":"c671204afd4f04b44f9b412b576df743a57a4567"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"d1562361f4f4d383b677b79a5a4f6445618649ed","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # the request body must contain a \"port_id\" field which is not"},{"line_number":156,"context_line":"        # allowed in port forwarding functionality."},{"line_number":157,"context_line":"        context \u003d payload.context"},{"line_number":158,"context_line":"        floatingip \u003d payload.latest_state"},{"line_number":159,"context_line":"        floatingip_id \u003d None"},{"line_number":160,"context_line":"        if event \u003d\u003d events.PRECOMMIT_UPDATE:"},{"line_number":161,"context_line":"            fip_db \u003d payload.desired_state"}],"source_content_type":"text/x-python","patch_set":5,"id":"2774c6f1_000bc377","line":158,"range":{"start_line":158,"start_character":21,"end_line":158,"end_character":41},"in_reply_to":"d1df2bfa_8d470cbe","updated":"2021-08-04 07:50:06.000000000","message":"Done","commit_id":"c671204afd4f04b44f9b412b576df743a57a4567"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c8c96399c672714b1e92d30bf7efd064e19bd0cd","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        # the request body must contain a \"port_id\" field which is not"},{"line_number":156,"context_line":"        # allowed in port forwarding functionality."},{"line_number":157,"context_line":"        context \u003d payload.context"},{"line_number":158,"context_line":"        floatingip \u003d payload.states[-1]"},{"line_number":159,"context_line":"        floatingip_id \u003d None"},{"line_number":160,"context_line":"        if event \u003d\u003d events.PRECOMMIT_UPDATE:"},{"line_number":161,"context_line":"            fip_db \u003d payload.desired_state"}],"source_content_type":"text/x-python","patch_set":8,"id":"654cd607_4ff63e08","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":39},"updated":"2021-08-10 15:11:48.000000000","message":"please move it as \u0027floatingip \u003d payload.states[-1]\u0027 under line 160 \u0027if\u0027, and as \u0027port \u003d payload.states[-1]\u0027 under line 172 \u0027if\u0027","commit_id":"bdf7904be462ade4eced58b21396e2e72640df98"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"ef27668e30480affbbeb573d497db4f45f5d3eb5","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # the request body must contain a \"port_id\" field which is not"},{"line_number":156,"context_line":"        # allowed in port forwarding functionality."},{"line_number":157,"context_line":"        context \u003d payload.context"},{"line_number":158,"context_line":"        floatingip \u003d payload.states[-1]"},{"line_number":159,"context_line":"        floatingip_id \u003d None"},{"line_number":160,"context_line":"        if event \u003d\u003d events.PRECOMMIT_UPDATE:"},{"line_number":161,"context_line":"            fip_db \u003d payload.desired_state"}],"source_content_type":"text/x-python","patch_set":8,"id":"0592a2ef_5e9f94e3","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":39},"in_reply_to":"654cd607_4ff63e08","updated":"2021-08-10 15:34:37.000000000","message":"Done","commit_id":"bdf7904be462ade4eced58b21396e2e72640df98"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c8c96399c672714b1e92d30bf7efd064e19bd0cd","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                          \u0027request does not contain port_id.\u0027, floatingip_id)"},{"line_number":171,"context_line":"                return"},{"line_number":172,"context_line":"        elif event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":173,"context_line":"            floatingip_id \u003d floatingip.get(\u0027device_id\u0027)"},{"line_number":174,"context_line":"        if not floatingip_id:"},{"line_number":175,"context_line":"            return"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1273f306_23f781d1","line":173,"range":{"start_line":173,"start_character":28,"end_line":173,"end_character":38},"updated":"2021-08-10 15:11:48.000000000","message":"please see above comment, here payload.states[-1] is actually a port dict. \u0027floatingip\u0027 is confusing here","commit_id":"bdf7904be462ade4eced58b21396e2e72640df98"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"ef27668e30480affbbeb573d497db4f45f5d3eb5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          \u0027request does not contain port_id.\u0027, floatingip_id)"},{"line_number":171,"context_line":"                return"},{"line_number":172,"context_line":"        elif event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":173,"context_line":"            floatingip_id \u003d floatingip.get(\u0027device_id\u0027)"},{"line_number":174,"context_line":"        if not floatingip_id:"},{"line_number":175,"context_line":"            return"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2cc85c76_f63d2ecb","line":173,"range":{"start_line":173,"start_character":28,"end_line":173,"end_character":38},"in_reply_to":"1273f306_23f781d1","updated":"2021-08-10 15:34:37.000000000","message":"Done","commit_id":"bdf7904be462ade4eced58b21396e2e72640df98"}]}