)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"c997495b9d4a185626c9f01f25c10d55b7b1f1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ab506c4_868ff078","updated":"2021-10-28 04:38:32.000000000","message":"recheck","commit_id":"771fdc0b0716cbbbe41db3835def3eb9b423c66a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"581ac2596b3877a26ee80304f3d7403583f35ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"845813b1_b58e8290","updated":"2021-11-01 19:31:46.000000000","message":"recheck","commit_id":"771fdc0b0716cbbbe41db3835def3eb9b423c66a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ea672596603bf7921fc61feba7ec372a9bfdd54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b92b818f_a779acf0","updated":"2021-10-25 11:03:04.000000000","message":"recheck","commit_id":"771fdc0b0716cbbbe41db3835def3eb9b423c66a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98ac9ea476c654a7f4ec513c3a9e6ba30dd81078","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e412c2d6_ee0cf58f","updated":"2021-10-12 07:52:18.000000000","message":"recheck","commit_id":"771fdc0b0716cbbbe41db3835def3eb9b423c66a"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0653e00493125c5de054c189686da3b05bb227c4","unresolved":true,"context_lines":[{"line_number":367,"context_line":"                                               \u0027add\u0027,"},{"line_number":368,"context_line":"                                               device\u003ddevice,"},{"line_number":369,"context_line":"                                               device_exists\u003ddevice_exists)"},{"line_number":370,"context_line":"                for allowed_address_pair in p.get(\u0027allowed_address_pairs\u0027, []):"},{"line_number":371,"context_line":"                    ip_version \u003d netaddr.IPNetwork("},{"line_number":372,"context_line":"                        allowed_address_pair[\u0027ip_address\u0027]).version"},{"line_number":373,"context_line":"                    if ip_version \u003d\u003d subnet_ip_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b5ed525_9462d6ea","line":370,"updated":"2021-07-26 15:34:26.000000000","message":"I have the same concerns here as in [1]. What happens when the number of allowed address pairs is too high?\n\n[1]https://review.opendev.org/c/openstack/neutron/+/800059/1/neutron/agent/l3/dvr_local_router.py","commit_id":"238ca17ae2797bfaea6a098ec7edd9a4e6a9dc03"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1b94407c3b2da42dcaf7675c8f84b97a54a53f24","unresolved":true,"context_lines":[{"line_number":367,"context_line":"                                               \u0027add\u0027,"},{"line_number":368,"context_line":"                                               device\u003ddevice,"},{"line_number":369,"context_line":"                                               device_exists\u003ddevice_exists)"},{"line_number":370,"context_line":"                for allowed_address_pair in p.get(\u0027allowed_address_pairs\u0027, []):"},{"line_number":371,"context_line":"                    ip_version \u003d netaddr.IPNetwork("},{"line_number":372,"context_line":"                        allowed_address_pair[\u0027ip_address\u0027]).version"},{"line_number":373,"context_line":"                    if ip_version \u003d\u003d subnet_ip_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f45384e7_6bc494d4","line":370,"in_reply_to":"5981ea42_842a750d","updated":"2021-09-07 08:11:41.000000000","message":"As I see we call _update_arp_entry less (only when ip version is Ok) so it seems ok from performance perspective. Am I miss something?","commit_id":"238ca17ae2797bfaea6a098ec7edd9a4e6a9dc03"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c97ce3f3e48537a054dd81b9fd3cd7e6f1e3cad8","unresolved":true,"context_lines":[{"line_number":367,"context_line":"                                               \u0027add\u0027,"},{"line_number":368,"context_line":"                                               device\u003ddevice,"},{"line_number":369,"context_line":"                                               device_exists\u003ddevice_exists)"},{"line_number":370,"context_line":"                for allowed_address_pair in p.get(\u0027allowed_address_pairs\u0027, []):"},{"line_number":371,"context_line":"                    ip_version \u003d netaddr.IPNetwork("},{"line_number":372,"context_line":"                        allowed_address_pair[\u0027ip_address\u0027]).version"},{"line_number":373,"context_line":"                    if ip_version \u003d\u003d subnet_ip_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5981ea42_842a750d","line":370,"in_reply_to":"5b5ed525_9462d6ea","updated":"2021-08-03 12:52:56.000000000","message":"Without that patch we are still iterating over all IPs from the allowed address pairs. The only difference is that now we are checking version of the IP addresses before updating arp entry. So I don\u0027t think this patch may cause any performance degradation.","commit_id":"238ca17ae2797bfaea6a098ec7edd9a4e6a9dc03"}]}