)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"757c7083a78c00519aad495726a9d94ce30c6aca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes broken neutron-netns-cleanup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some configuration parameters used in neutron.agent.linux.utils"},{"line_number":10,"context_line":"where missing. The namespace attribute in the FakeNetwork object"},{"line_number":11,"context_line":"was missing, and used in neutron.agent.linux.dhcp. Also, the plugin"},{"line_number":12,"context_line":"object was missing for release_dhcp_port operation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2F0TU%3D","line":10,"updated":"2014-03-13 19:23:27.000000000","message":"a/where/were :)","commit_id":"366bc93b1e70e86173e65f07c4401ee5ff9d9b46"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a59b427d2ca3e81a827255a95c94aa7141b32a7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes broken neutron-netns-cleanup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some configuration parameters used in neutron.agent.linux.utils"},{"line_number":10,"context_line":"where missing. The namespace attribute in the FakeNetwork object"},{"line_number":11,"context_line":"was missing, and used in neutron.agent.linux.dhcp. Also, the plugin"},{"line_number":12,"context_line":"object was missing for release_dhcp_port operation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FizM%3D","line":10,"in_reply_to":"AAAAWH%2F%2F0TU%3D","updated":"2014-03-17 07:20:30.000000000","message":"Hi Jay, thank you very much, I will fix this, add some regression tests, and commit a new change set.","commit_id":"366bc93b1e70e86173e65f07c4401ee5ff9d9b46"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f5f0287f7cc057d75260fa79e661fff546d04bed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes broken neutron-netns-cleanup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some configuration parameters used in neutron.agent.linux.utils"},{"line_number":10,"context_line":"where missing. The namespace attribute in the FakeNetwork object"},{"line_number":11,"context_line":"was missing, and used in neutron.agent.linux.dhcp. Also, the plugin"},{"line_number":12,"context_line":"object was missing for release_dhcp_port operation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FWs8%3D","line":10,"in_reply_to":"AAAAWH%2F%2FizM%3D","updated":"2014-03-18 12:30:12.000000000","message":"Done.","commit_id":"366bc93b1e70e86173e65f07c4401ee5ff9d9b46"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24bba144309f612519cfafa3db85d35a2eff43","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes broken neutron-netns-cleanup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some configuration parameters used in neutron.agent.linux.utils"},{"line_number":10,"context_line":"where missing. The namespace attribute in the FakeNetwork object"},{"line_number":11,"context_line":"was missing, and used in neutron.agent.linux.dhcp. Also, the plugin"},{"line_number":12,"context_line":"object was missing for release_dhcp_port operation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2FWrA%3D","line":10,"updated":"2014-03-18 14:56:28.000000000","message":"s/where/were","commit_id":"2fdba49f80cd1426fe1cae7388c3d3e35207e5c9"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"75d6a350c19b6b0234209cd745a36a0d1644c75e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes broken neutron-netns-cleanup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some configuration parameters used in neutron.agent.linux.utils"},{"line_number":10,"context_line":"where missing. The namespace attribute in the FakeNetwork object"},{"line_number":11,"context_line":"was missing, and used in neutron.agent.linux.dhcp. Also, the plugin"},{"line_number":12,"context_line":"object was missing for release_dhcp_port operation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2FVe4%3D","line":10,"in_reply_to":"AAAAWH%2F%2FWrA%3D","updated":"2014-03-18 15:03:36.000000000","message":"Done","commit_id":"2fdba49f80cd1426fe1cae7388c3d3e35207e5c9"}],"neutron/agent/netns_cleanup_util.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d1f4338995b94c3456f3c850d6a6572a1696bb31","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        conf\u003dconf,"},{"line_number":79,"context_line":"        network\u003ddhcp.NetModel(conf.use_namespaces, {\u0027id\u0027: network_id}),"},{"line_number":80,"context_line":"        root_helper\u003droot_helper,"},{"line_number":81,"context_line":"        version\u003dNone,"},{"line_number":82,"context_line":"        plugin\u003dplugin_rpc)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if dhcp_driver.active:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfTo%3D","line":81,"updated":"2014-03-26 13:14:40.000000000","message":"None is implicit","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0eb02e12a74d9dc9ccd570e859067766739936e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        conf\u003dconf,"},{"line_number":79,"context_line":"        network\u003ddhcp.NetModel(conf.use_namespaces, {\u0027id\u0027: network_id}),"},{"line_number":80,"context_line":"        root_helper\u003droot_helper,"},{"line_number":81,"context_line":"        version\u003dNone,"},{"line_number":82,"context_line":"        plugin\u003dplugin_rpc)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if dhcp_driver.active:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfK4%3D","line":81,"in_reply_to":"AAAAWH%2F%2BfTo%3D","updated":"2014-03-26 13:34:11.000000000","message":"Right!! :)\n\nDone","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25f2f0bc9f9b6510a0c97bd8e594228f02b9a5e4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        conf\u003dconf,"},{"line_number":79,"context_line":"        network\u003ddhcp.NetModel(conf.use_namespaces, {\u0027id\u0027: network_id}),"},{"line_number":80,"context_line":"        root_helper\u003droot_helper,"},{"line_number":81,"context_line":"        plugin\u003dplugin_rpc)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if dhcp_driver.active:"},{"line_number":84,"context_line":"        dhcp_driver.disable()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F9wLk%3D","line":81,"updated":"2014-04-02 11:25:52.000000000","message":"The actual DhcpPluginApi is instantiated and this leads to release_dhcp_port RPC method is called. netns cleanup is a standalone tool and we need to avoid any communications like rpc.","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d3bc326bea5d3d28f7f0a5640502503b42f403f1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        conf\u003dconf,"},{"line_number":79,"context_line":"        network\u003ddhcp.NetModel(conf.use_namespaces, {\u0027id\u0027: network_id}),"},{"line_number":80,"context_line":"        root_helper\u003droot_helper,"},{"line_number":81,"context_line":"        plugin\u003dplugin_rpc)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if dhcp_driver.active:"},{"line_number":84,"context_line":"        dhcp_driver.disable()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F9vYQ%3D","line":81,"in_reply_to":"AAAAWH%2F9wLk%3D","updated":"2014-04-02 13:12:09.000000000","message":"After carefully checking I believe you\u0027re right,\nI\u0027m updating the patch to remove the RPC connection.","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d47c895b2b99642637b074987e09f0f9af0eb5d6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        root_helper\u003droot_helper,"},{"line_number":83,"context_line":"        plugin\u003dFakeDhcpPlugin())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if dhcp_driver.active:"},{"line_number":86,"context_line":"        dhcp_driver.disable()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9uh4%3D","line":85,"updated":"2014-04-02 14:50:26.000000000","message":"This line can be also removed, it\u0027s checked inside of disable()","commit_id":"907bf41afbdb9f565c45a535f637c8928d0be52a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"8d298e93ec00e2c750b36e736a12e93b979816cf","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        root_helper\u003droot_helper,"},{"line_number":83,"context_line":"        plugin\u003dFakeDhcpPlugin())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if dhcp_driver.active:"},{"line_number":86,"context_line":"        dhcp_driver.disable()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F9t%2BQ%3D","line":85,"in_reply_to":"AAAAWH%2F9uh4%3D","updated":"2014-04-02 15:44:31.000000000","message":"Thanks for pointing out, you\u0027re right.\n\nIf that\u0027s ok with you I\u0027ll make that enhancement in a separate patch.","commit_id":"907bf41afbdb9f565c45a535f637c8928d0be52a"}],"neutron/tests/functional/agent/linux/test_agent_netns_cleanup.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b24bba144309f612519cfafa3db85d35a2eff43","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(TestNetnsCleanupWithDnsmasqDriverAndOVS, self).setUp()"},{"line_number":42,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":43,"context_line":"        self.conf \u003d self._setup_conf()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _setup_conf(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FWtE%3D","line":42,"updated":"2014-03-18 14:56:28.000000000","message":"not needed; done in BaseTestCase.","commit_id":"2fdba49f80cd1426fe1cae7388c3d3e35207e5c9"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"75d6a350c19b6b0234209cd745a36a0d1644c75e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(TestNetnsCleanupWithDnsmasqDriverAndOVS, self).setUp()"},{"line_number":42,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":43,"context_line":"        self.conf \u003d self._setup_conf()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _setup_conf(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FVcM%3D","line":42,"in_reply_to":"AAAAWH%2F%2FWtE%3D","updated":"2014-03-18 15:03:36.000000000","message":"You\u0027re right!,\ndone!","commit_id":"2fdba49f80cd1426fe1cae7388c3d3e35207e5c9"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b988be1a6dbe579e006ed4d44f7bd26b1ee085b0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            mock.patch.object(ip_lib, \u0027device_exists\u0027, return_value\u003dTrue),"},{"line_number":59,"context_line":"            mock.patch.object(ovs_lib.OVSBridge, \u0027delete_port\u0027),"},{"line_number":60,"context_line":"            mock.patch.object(rpc, \u0027call\u0027)) as \\"},{"line_number":61,"context_line":"                (_, _, _, execute_mock, _, delete_port_mock, rpc_call_mock):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            util.kill_dhcp(self.conf, \u0027qdhcp-fake-ns\u0027)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FS8g%3D","line":61,"updated":"2014-03-18 19:46:44.000000000","message":"Ok, I plan to reduce mocking here.\n\nI\u0027d like to patch only the rpc calls  (to avoid runtime plugin dependency, neutron-server rpc, etc..), and provide a port, then\n\n1) Allow the dnsmasq service creation for a network\n\n2) Call kill_dhcp\n\n3) make sure the resources are cleaned up.","commit_id":"f1100400080234f322ed9cb5f382cd1316edd718"}],"neutron/tests/unit/test_agent_netns_cleanup.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d1f4338995b94c3456f3c850d6a6572a1696bb31","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def test_setup_conf(self):"},{"line_number":28,"context_line":"        expected_opts \u003d interface.OPTS"},{"line_number":29,"context_line":"        conf \u003d util.setup_conf()"},{"line_number":30,"context_line":"        self.assertTrue(all([opt.name in conf for opt in expected_opts]))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_kill_dhcp(self, dhcp_active\u003dTrue):"},{"line_number":33,"context_line":"        conf \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfWs%3D","line":30,"updated":"2014-03-26 13:14:40.000000000","message":"Does it belong here? It\u0027s testing oslo.config rather than netns_cleanup itself.","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0eb02e12a74d9dc9ccd570e859067766739936e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def test_setup_conf(self):"},{"line_number":28,"context_line":"        expected_opts \u003d interface.OPTS"},{"line_number":29,"context_line":"        conf \u003d util.setup_conf()"},{"line_number":30,"context_line":"        self.assertTrue(all([opt.name in conf for opt in expected_opts]))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_kill_dhcp(self, dhcp_active\u003dTrue):"},{"line_number":33,"context_line":"        conf \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfNg%3D","line":30,"in_reply_to":"AAAAWH%2F%2BfWs%3D","updated":"2014-03-26 13:34:11.000000000","message":"No,\n\nIt\u0027s testing util (netns_cleanup_util).setup_conf, to make sure that it does import the neutron.agent.linux.interface.OPTS that are required by some parts of the ovs_util part in the neutron.agent.linux code.\n\nOther tests didn\u0027t trigger that dependency, so I\u0027m ensuring that the interface options are available.","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d1f4338995b94c3456f3c850d6a6572a1696bb31","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                           conf.AGENT.root_helper,"},{"line_number":48,"context_line":"                                           mock.ANY)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            self.assertIsNotNone(import_object.call_args[1][\u0027plugin\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if dhcp_active:"},{"line_number":53,"context_line":"                driver.assert_has_calls([mock.call.disable()])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfVc%3D","line":50,"updated":"2014-03-26 13:14:40.000000000","message":"I guess you should edit import_object.called_once_with according defined values instead of adding this line.","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3050f2c61d4be276e09560ff426f206e808bd34b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                           conf.AGENT.root_helper,"},{"line_number":48,"context_line":"                                           mock.ANY)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            self.assertIsNotNone(import_object.call_args[1][\u0027plugin\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if dhcp_active:"},{"line_number":53,"context_line":"                driver.assert_has_calls([mock.call.disable()])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Beic%3D","line":50,"in_reply_to":"AAAAWH%2F%2BfLM%3D","updated":"2014-03-26 14:50:49.000000000","message":"Ok, if you set plugin\u003dmock.ANY it ensures that the call is done \nwith something in \"plugin\".\n\nalso, called_once_with must be assert_called_once_with","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0eb02e12a74d9dc9ccd570e859067766739936e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                           conf.AGENT.root_helper,"},{"line_number":48,"context_line":"                                           mock.ANY)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"            self.assertIsNotNone(import_object.call_args[1][\u0027plugin\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if dhcp_active:"},{"line_number":53,"context_line":"                driver.assert_has_calls([mock.call.disable()])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BfLM%3D","line":50,"in_reply_to":"AAAAWH%2F%2BfVc%3D","updated":"2014-03-26 13:34:11.000000000","message":"I didn\u0027t try that because I wasn\u0027t expecting mock to match \n    ctx \u003d context.get_admin_context_without_session()\n    plugin_rpc \u003d dhcp_agent.DhcpPluginApi(topics.PLUGIN,\n                   ctx,\n                   conf.use_namespaces)\n\ntwo different \"plugin_rpc\" objects.\n\nBut I\u0027m going to try in a few minutes.","commit_id":"58d1cbeed6372e7775741581b12d5d2645145586"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f89bde2a6b22246828eb4d04b3015feb39c62dc2","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                mock_get_bridge_for_iface.assert_called_once_with("},{"line_number":113,"context_line":"                    conf.AGENT.root_helper, \u0027tap1\u0027)"},{"line_number":114,"context_line":"                ovs_br_cls.assert_called_once_with(\u0027br-int\u0027,"},{"line_number":115,"context_line":"                                                   conf.AGENT.root_helper)"},{"line_number":116,"context_line":"                ovs_bridge.assert_has_calls("},{"line_number":117,"context_line":"                    [mock.call.delete_port(device.name)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2BX%2BQ%3D","line":114,"updated":"2014-03-27 09:15:16.000000000","message":"minor nitpick: This isn\u0027t related to the bug 1291915.\nSo this fix should go to the patch for bug 1297875.\n\nIt\u0027s up to you.","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c462bd5a6fb9493140289e2d61b142a4067ea9d","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                mock_get_bridge_for_iface.assert_called_once_with("},{"line_number":113,"context_line":"                    conf.AGENT.root_helper, \u0027tap1\u0027)"},{"line_number":114,"context_line":"                ovs_br_cls.assert_called_once_with(\u0027br-int\u0027,"},{"line_number":115,"context_line":"                                                   conf.AGENT.root_helper)"},{"line_number":116,"context_line":"                ovs_bridge.assert_has_calls("},{"line_number":117,"context_line":"                    [mock.call.delete_port(device.name)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2BX6E%3D","line":114,"in_reply_to":"AAAAWH%2F%2BX%2BQ%3D","updated":"2014-03-27 09:24:12.000000000","message":"I don\u0027t think splitting is worth the effort. Though Miguel could usefully add another Related-Bug reference into commit message.","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"be96a631d52588b0d486cf4955f39bbe5963cf00","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                mock_get_bridge_for_iface.assert_called_once_with("},{"line_number":113,"context_line":"                    conf.AGENT.root_helper, \u0027tap1\u0027)"},{"line_number":114,"context_line":"                ovs_br_cls.assert_called_once_with(\u0027br-int\u0027,"},{"line_number":115,"context_line":"                                                   conf.AGENT.root_helper)"},{"line_number":116,"context_line":"                ovs_bridge.assert_has_calls("},{"line_number":117,"context_line":"                    [mock.call.delete_port(device.name)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2BWoA%3D","line":114,"in_reply_to":"AAAAWH%2F%2BX50%3D","updated":"2014-03-27 12:48:36.000000000","message":"Thanks for the comments Isaku \u0026 Ihar, it makes sense, but as I\u0027m fixing part 1297875  in the above import_object.called_once_with -\u003eassert_called_once_with I think the benefits of a separate patch for this are a little bit diluted.\n\nAll the unrelated files will go in a separate patch.\n\nThanks for the note, it\u0027s always good to spend a few extra cycles in analyzing consequences of this kind of details (backporting/cherrypicking/independence, etc...)","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64686f71ed5a9cc29f567cec538daf5fab0390a0","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                mock_get_bridge_for_iface.assert_called_once_with("},{"line_number":113,"context_line":"                    conf.AGENT.root_helper, \u0027tap1\u0027)"},{"line_number":114,"context_line":"                ovs_br_cls.assert_called_once_with(\u0027br-int\u0027,"},{"line_number":115,"context_line":"                                                   conf.AGENT.root_helper)"},{"line_number":116,"context_line":"                ovs_bridge.assert_has_calls("},{"line_number":117,"context_line":"                    [mock.call.delete_port(device.name)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2BX50%3D","line":114,"in_reply_to":"AAAAWH%2F%2BX6E%3D","updated":"2014-03-27 09:25:01.000000000","message":"Ah, it\u0027s already there, missed that. :(","commit_id":"6d062bf8848c0c0663b2b51787da991a08d7fb92"}]}