)]}'
{"neutron/tests/functional/test_server.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"093be707dda76c9ada3c99f3a127e89eba7cbd72","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(TestNeutronServer, self).setUp()"},{"line_number":54,"context_line":"        self.service_pid \u003d None"},{"line_number":55,"context_line":"        self.workers \u003d None"},{"line_number":56,"context_line":"        self._mp_queue \u003d multiprocessing.Queue()"},{"line_number":57,"context_line":"        self.health_checker \u003d self._check_active"},{"line_number":58,"context_line":"        self.pipein, self.pipeout \u003d os.pipe()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed3eafee_1ceb2947","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":27},"updated":"2021-08-10 07:18:29.000000000","message":"unrelated: this is confusing, self.workers is an int....","commit_id":"fafcabdbe0dccf2747884a35f3a094486c806fa6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f4d432d796b61366ecf26f35af0692a8e2bd2caa","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        # If number of workers is 1 it is assumed that we run"},{"line_number":94,"context_line":"        # a service in the current process."},{"line_number":95,"context_line":"        if self.workers \u003e 1:"},{"line_number":96,"context_line":"            workers \u003d self._get_workers(10, processes_queue\u003dprocesses_queue)"},{"line_number":97,"context_line":"            self.assertEqual(len(workers), self.workers)"},{"line_number":98,"context_line":"            return workers"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3910a4_d7406ce6","line":96,"range":{"start_line":96,"start_character":40,"end_line":96,"end_character":42},"updated":"2021-08-04 14:57:37.000000000","message":"nit: timeout\u003d10 for clarity, now it reads like number of requested workers","commit_id":"fafcabdbe0dccf2747884a35f3a094486c806fa6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f4d432d796b61366ecf26f35af0692a8e2bd2caa","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return [self.service_pid]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_workers(self, timeout, processes_queue\u003dNone):"},{"line_number":108,"context_line":"        \"\"\"Get the list of processes in which WSGI server is running.\"\"\""},{"line_number":109,"context_line":"        def safe_ppid(proc):"},{"line_number":110,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9d28af0f_d7280586","line":107,"range":{"start_line":107,"start_character":27,"end_line":107,"end_character":34},"updated":"2021-08-04 14:57:37.000000000","message":"nit: can be default 10. On the other hand: is this parameter really needed?","commit_id":"fafcabdbe0dccf2747884a35f3a094486c806fa6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f4d432d796b61366ecf26f35af0692a8e2bd2caa","unresolved":true,"context_lines":[{"line_number":128,"context_line":"            except queue.Empty:"},{"line_number":129,"context_line":"                raise exception"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # Wait at most 10 seconds to spawn workers"},{"line_number":132,"context_line":"        condition \u003d lambda: self.workers \u003d\u003d len(get_workers_pid())"},{"line_number":133,"context_line":"        utils.wait_until_true(condition, timeout\u003dtimeout, sleep\u003d0.1,"},{"line_number":134,"context_line":"                              exception\u003dexception)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a579dc8c_06ce6047","line":131,"range":{"start_line":131,"start_character":23,"end_line":131,"end_character":25},"updated":"2021-08-04 14:57:37.000000000","message":"nit: \u0027timeout\u0027. Also should it be moved before #125?","commit_id":"fafcabdbe0dccf2747884a35f3a094486c806fa6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d7a54bf23d954570fbb5e986eb8046a0dbb5783","unresolved":true,"context_lines":[{"line_number":128,"context_line":"            except queue.Empty:"},{"line_number":129,"context_line":"                raise exception"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # Wait at most 10 seconds to spawn workers"},{"line_number":132,"context_line":"        condition \u003d lambda: self.workers \u003d\u003d len(get_workers_pid())"},{"line_number":133,"context_line":"        utils.wait_until_true(condition, timeout\u003dtimeout, sleep\u003d0.1,"},{"line_number":134,"context_line":"                              exception\u003dexception)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f98f2dee_4cdde60f","line":131,"range":{"start_line":131,"start_character":23,"end_line":131,"end_character":25},"in_reply_to":"a579dc8c_06ce6047","updated":"2021-08-10 08:04:08.000000000","message":"1) you are right, this should be \"timeout\"\n2) IMO is OK to pass this value as a function parameter (although this is being called once).","commit_id":"fafcabdbe0dccf2747884a35f3a094486c806fa6"}]}