)]}'
{"neutron/db/migration/__init__.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d2ee5053fdf45635cfaf865c592ca4ee5b936c38","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        if (CISCO_PLUGIN not in migrate_plugins and"},{"line_number":27,"context_line":"                OVS_PLUGIN in migrate_plugins):"},{"line_number":28,"context_line":"                migrate_plugins.append(CISCO_PLUGIN)"},{"line_number":29,"context_line":"        return set(active_plugins) \u0026 set(migrate_plugins)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bp6w%3D","line":28,"updated":"2014-03-25 09:25:32.000000000","message":"small nit: I think only 4 spaces indent from \"if\" should be here. This indentation doesn\u0027t break pep8 test but it\u0027s more readable with correct indentation.\n\nThis seems too hackish for me and may cause creation of tables that are not used. Would you consider putting cisco plugin to every specific place where tables needed for cisco plugin are created? It would also provide better overview on which tables are needed for specific plugin.","commit_id":"0cd805ffb5ce53f624fa35564b34e246118cd4e1"},{"author":{"_account_id":7021,"name":"Hareesh Puthalath","email":"hareesh.puthalath@gmail.com","username":"hareesh"},"change_message_id":"930694f9ad1ac7558da37bc76b70e10ec5ed0886","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        if (CISCO_PLUGIN not in migrate_plugins and"},{"line_number":27,"context_line":"                OVS_PLUGIN in migrate_plugins):"},{"line_number":28,"context_line":"                migrate_plugins.append(CISCO_PLUGIN)"},{"line_number":29,"context_line":"        return set(active_plugins) \u0026 set(migrate_plugins)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bkdc%3D","line":28,"in_reply_to":"AAAAWH%2F%2Bp6w%3D","updated":"2014-03-25 20:37:01.000000000","message":"Done","commit_id":"0cd805ffb5ce53f624fa35564b34e246118cd4e1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"477e04668b4569b0685420fcf4f07957013f8d7b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        if (CISCO_PLUGIN not in migrate_plugins and"},{"line_number":27,"context_line":"                OVS_PLUGIN in migrate_plugins):"},{"line_number":28,"context_line":"                migrate_plugins.append(CISCO_PLUGIN)"},{"line_number":29,"context_line":"        return set(active_plugins) \u0026 set(migrate_plugins)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bma8%3D","line":28,"in_reply_to":"AAAAWH%2F%2Bp6w%3D","updated":"2014-03-25 16:31:38.000000000","message":"I am going to answer the second part since I am responsible for coming up with this idea for fixing the cisco plugin migrations.\n\nAdding the cisco plugin to all the migrations where it is missing was my first thought for the solution. Yet that still leaves the problem of future migrations that we might miss, which this proposed solution addresses.\n\nI realize that this is a vendor-specific hack to the core code. However, it does not affect any other plugin. In the future we will deprecate the cisco plugin in favor of ML2, and then we can remove this code.","commit_id":"0cd805ffb5ce53f624fa35564b34e246118cd4e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d7d29b0d823e1857be8b66515e71d3c55dd2d8f8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        if (CISCO_PLUGIN not in migrate_plugins and"},{"line_number":27,"context_line":"                OVS_PLUGIN in migrate_plugins):"},{"line_number":28,"context_line":"            migrate_plugins.append(CISCO_PLUGIN)"},{"line_number":29,"context_line":"        return set(active_plugins) \u0026 set(migrate_plugins)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BUTw%3D","line":28,"updated":"2014-03-27 16:50:37.000000000","message":"(suggestion; not required to change now) Hopefully we have this logic in a separate module. AFAIK metaplugin folks are thinking the similar thing. It can be improved later.","commit_id":"f23d081b26071e1b309f49e5a5ab0cdc1a739e9d"}]}