)]}'
{"neutron/agent/ovn/metadata/ovsdb.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47771f8cb8f5cafde0e7fbd44a93089c91fb97dd","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            None, connection_string, helper)"},{"line_number":45,"context_line":"        # ovn metadata agent doesn\u0027t write to southbound database, so there"},{"line_number":46,"context_line":"        # is no need to keep connection with cluster leader."},{"line_number":47,"context_line":"        self.leader_only \u003d False"},{"line_number":48,"context_line":"        if chassis:"},{"line_number":49,"context_line":"            for table in set(tables).intersection({\u0027Chassis\u0027,"},{"line_number":50,"context_line":"                                                   \u0027Chassis_Private\u0027}):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1227e86e_0becc9fb","line":47,"updated":"2021-08-23 10:55:08.000000000","message":"I think it still writes to the SB DB - https://github.com/openstack/neutron/blob/master/neutron/agent/ovn/metadata/agent.py#L270\n\nI have a patch up for review that\u0027s been abandoned recently that makes writes to SB DB configurable - https://review.opendev.org/c/openstack/neutron/+/792998\n\nPerhaps it would make sense to set leader_only \u003d False only for the NonReporting agent?","commit_id":"9b7ac0538e7357db1943b3defdb3556592440ece"},{"author":{"_account_id":16036,"name":"Krzysztof Klimonda","email":"kklimonda@syntaxhighlighted.com","username":"kklimonda"},"change_message_id":"f1a4950f12fca6569d0051396b60624366c5b841","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            None, connection_string, helper)"},{"line_number":45,"context_line":"        # ovn metadata agent doesn\u0027t write to southbound database, so there"},{"line_number":46,"context_line":"        # is no need to keep connection with cluster leader."},{"line_number":47,"context_line":"        self.leader_only \u003d False"},{"line_number":48,"context_line":"        if chassis:"},{"line_number":49,"context_line":"            for table in set(tables).intersection({\u0027Chassis\u0027,"},{"line_number":50,"context_line":"                                                   \u0027Chassis_Private\u0027}):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d080a22f_da89d549","line":47,"in_reply_to":"1227e86e_0becc9fb","updated":"2021-08-23 12:39:18.000000000","message":"I think the real tough one is actually this: https://github.com/openstack/neutron/blob/master/neutron/agent/ovn/metadata/agent.py#L176 - from what I can tell, for every nb_cfg change in Northbound DB, every chassis will send update to Chassis_Private setting external_ids:\"neutron:ovn-metadata-sb-cfg\" to match it. I see that you\u0027re disabling this update in your patch - any idea what is it used for?\n\nThat comment definitely should be changed, although at least in clustered mode followers forward writes to the leader[1] (with \"some\" extra processing in case of transaction congestion) so some writes would not be terrible, although seemingly writing on every Northbound is painful anyway.\n\nI\u0027ll take a look at your patch and review it, disabling all writes seem critical in large scale deployments.\n\n[1] See https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#understanding-cluster-consistency","commit_id":"9b7ac0538e7357db1943b3defdb3556592440ece"}]}