)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"53ae8ca0f4d8f727569e70d98f404312a94519bd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2021-08-27 10:06:34 +0300"},{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-27 10:32:32 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do less locking on l3 agent greenpool resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently each pool resize attempt tries to grab a syncronized lock,"},{"line_number":10,"context_line":"even if it will actually do not resize the pool in the end."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9c0c638c_4c9b10fc","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":44},"updated":"2021-08-27 08:37:58.000000000","message":"Please file a bug in lauchpad with more details of the issue, then we can understand the real problem.","commit_id":"05162fce3e994907c526c451fb8dd975e2fb74d5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"53ae8ca0f4d8f727569e70d98f404312a94519bd","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Due to this, when max pool size is reached, agent may spawn many"},{"line_number":13,"context_line":"greenthreads that all at once are trying to grab the lock, hogging"},{"line_number":14,"context_line":"resources, which is particularly noticible on full sync of large enough"},{"line_number":15,"context_line":"number of routers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch does attempt to grab the lock only if the pool is actually"},{"line_number":18,"context_line":"going to be resized."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fafc0151_560e224d","line":15,"range":{"start_line":14,"start_character":59,"end_line":15,"end_character":18},"updated":"2021-08-27 08:37:58.000000000","message":"I wonder how many? From my personal experiences, when your l3-agent hosts more than 250 routers, your l3-agent, ovs-agent, openvswitch  are almost dead because there are too many resource (especially port) to handle.","commit_id":"05162fce3e994907c526c451fb8dd975e2fb74d5"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"53ae8ca0f4d8f727569e70d98f404312a94519bd","unresolved":true,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @lockutils.synchronized(\u0027resize_greenpool\u0027)"},{"line_number":472,"context_line":"    def _resize_process_pool(self):"},{"line_number":473,"context_line":"        pool_size \u003d max([ROUTER_PROCESS_GREENLET_MIN,"},{"line_number":474,"context_line":"                         min([ROUTER_PROCESS_GREENLET_MAX,"},{"line_number":475,"context_line":"                              len(self.router_info)])])"},{"line_number":476,"context_line":"        if pool_size \u003d\u003d self._pool_size:"},{"line_number":477,"context_line":"            return"},{"line_number":478,"context_line":"        LOG.info(\"Resizing router processing queue green pool size to: %d\","},{"line_number":479,"context_line":"                 pool_size)"},{"line_number":480,"context_line":"        self._pool.resize(pool_size)"},{"line_number":481,"context_line":"        self._pool_size \u003d pool_size"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def _router_added(self, router_id, router):"},{"line_number":484,"context_line":"        ri \u003d self._create_router(router_id, router)"}],"source_content_type":"text/x-python","patch_set":1,"id":"905398e5_3ab8ac83","side":"PARENT","line":481,"range":{"start_line":473,"start_character":0,"end_line":481,"end_character":35},"updated":"2021-08-27 08:37:58.000000000","message":"All these actions are lightweight, it should not be the bottleneck of the router processing.","commit_id":"701214481ff1df13b188d7826b44a1c8b51227ea"}]}