)]}'
{"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"53c070691bd64f2dcaaf693415340e264968ace3","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"oc_check_public_network() {"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    [ \"$VALIDATE_MIGRATION\" !\u003d \"True\" ] \u0026\u0026 return 0"},{"line_number":223,"context_line":"    source $OVERCLOUDRC_FILE"},{"line_number":224,"context_line":"    openstack network show $PUBLIC_NETWORK_NAME 1\u003e/dev/null || {"},{"line_number":225,"context_line":"        echo \"ERROR: PUBLIC_NETWORK_NAME\u003d${PUBLIC_NETWORK_NAME} can\u0027t be accessed by the\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"de8863e6_3d5af2ff","line":222,"updated":"2021-09-02 08:23:21.000000000","message":"Is this because if VALIDATE_MIGRATION \u003d\u003d  False the migration scripts will not pre create resources prior to the migration and then this check will fail later ?","commit_id":"3c305bf6ae37bd26cda8545bb1a76302dc830dee"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"d81871dc3a37ee398c4b488345b142c6fccea412","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"oc_check_public_network() {"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    [ \"$VALIDATE_MIGRATION\" !\u003d \"True\" ] \u0026\u0026 return 0"},{"line_number":223,"context_line":"    source $OVERCLOUDRC_FILE"},{"line_number":224,"context_line":"    openstack network show $PUBLIC_NETWORK_NAME 1\u003e/dev/null || {"},{"line_number":225,"context_line":"        echo \"ERROR: PUBLIC_NETWORK_NAME\u003d${PUBLIC_NETWORK_NAME} can\u0027t be accessed by the\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"c44b075f_88f711ad","line":222,"in_reply_to":"29ebcd0a_a576280e","updated":"2021-09-02 10:05:17.000000000","message":"small correction to the above, OVERCLOUDRC_FILE should be set properly since it\u0027s value then used by delete-neutron-resources.sh.j2 in addition to create/delete/validate resources templates but PUBLIC_NETWORK_NAME used only in create_resources template which is skipped in case VALIDATE_MIGRATION \u003d\u003d False.","commit_id":"3c305bf6ae37bd26cda8545bb1a76302dc830dee"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"a45db9920a0835516cd13355c8184176ebb99c95","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"oc_check_public_network() {"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    [ \"$VALIDATE_MIGRATION\" !\u003d \"True\" ] \u0026\u0026 return 0"},{"line_number":223,"context_line":"    source $OVERCLOUDRC_FILE"},{"line_number":224,"context_line":"    openstack network show $PUBLIC_NETWORK_NAME 1\u003e/dev/null || {"},{"line_number":225,"context_line":"        echo \"ERROR: PUBLIC_NETWORK_NAME\u003d${PUBLIC_NETWORK_NAME} can\u0027t be accessed by the\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"29ebcd0a_a576280e","line":222,"in_reply_to":"de8863e6_3d5af2ff","updated":"2021-09-02 09:07:19.000000000","message":"OVN migration documentation (https://docs.openstack.org/networking-ovn/latest/install/migration.html) directs user to set VALIDATE_MIGRATION to False in case customer environment does not meet requirements regarding available FIPs. Our (RHOSP) customer tried to set VALIDATE_MIGRATION to False and received errors on generate_inventory command since it calls the oc_check_public_network function. The errors can be avoided if user specifies some additional environment variables like OVERCLOUDRC_FILE and PUBLIC_NETWORK_NAME and has spare FIPs on the public network. These environment variables are used only by the ovn_migration script and not used by the migration playbooks. Downstream CI passes with VALIDATE_MIGRATION\u003dFalse but we have spare FIPs and set OVERCLOUDRC_FILE and PUBLIC_NETWORK_NAME properly.\nThere are some more details in RHBZ https://bugzilla.redhat.com/show_bug.cgi?id\u003d1997254","commit_id":"3c305bf6ae37bd26cda8545bb1a76302dc830dee"}]}
