)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b04eb6fed9dcd5edacd2cb2468dede8e001bd215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67165a89_ea401040","updated":"2021-10-18 11:25:03.000000000","message":"LGTM after Lajos\u0027 comments are resolved","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9149144b9b462cdc49553654446916824767c376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d35e4bc4_3c95f177","updated":"2021-10-15 06:58:26.000000000","message":"recheck","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b2f5dd194397e977be98f164aefa15d54647e1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff10b04d_d3f948f4","updated":"2021-10-12 07:58:19.000000000","message":"recheck","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73376be4febdb91b1949d618a8c1e82463f95745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f419998_2462defb","updated":"2021-10-21 11:03:38.000000000","message":"Waiting for the CI, but patch looks ok.","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"5d8e9784c3697b37748366067bdd093268ea5dad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"03fa6491_efdf07a8","updated":"2021-10-29 02:25:35.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"183a4c8819b5c93ea9994ad3520814b6e7be0eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06d82e20_7f482736","updated":"2021-10-22 15:16:43.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ee8c7f92e0c365cf53d94a13a90af60273eee238","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27e5c288_d84b1fd6","updated":"2021-10-25 12:08:13.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0c898cea5c978e083fcc189d2997fc5b1bf172bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"380f8ec1_786702f1","updated":"2021-11-02 07:44:33.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c8e77c27ca5dac0dc60b0f12e4f41fe5d77aa5cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"526e6fe9_d642ba39","updated":"2021-10-26 06:26:45.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"94fd0f15fb844a72b28765a2a18db69326e799b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"669631c0_2a62c0e6","updated":"2021-11-02 04:41:47.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"398fbd9dbb2ad5e2d0b8ba9966bb1712352f1040","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"864fe6b5_4df5cb10","updated":"2021-11-04 08:07:22.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"256b624021255bd66a35066a90507f2d32317a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"995cbc36_4394b2ce","updated":"2021-10-28 18:14:16.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"50e0392cc23adfb2d27010aa0e6c1607cb0555ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdf014b7_a8f8ea35","updated":"2021-10-30 07:28:22.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"c18d067d569fd1ce00758bb2e6aed4ebbe9dd8b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7f3f30c_09d350c1","updated":"2021-10-28 04:36:59.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"928cc02e1a09fd8550e6d1fbfe4c4a80d05aa9c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ebc90c81_cbb88626","updated":"2021-11-04 09:59:00.000000000","message":"recheck","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"b0aadcba0b61c0761eabe11265764d0261a3e821","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3940dda_28e475e6","updated":"2021-11-01 19:30:02.000000000","message":"recheck\n\n\n\n","commit_id":"042de7e6bbb3a187e8e12462eb35e6740448b2be"}],"neutron/conf/common.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e661dbac7df2a2a21eda46793c530b385c12570","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                       \" notification to DHCP agent\")),"},{"line_number":90,"context_line":"    cfg.BoolOpt(\u0027allow_overlapping_ips\u0027, default\u003dFalse,"},{"line_number":91,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":92,"context_line":"                deprecated_since\u003dversionutils.deprecated.XENA,"},{"line_number":93,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron. \""},{"line_number":94,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":95,"context_line":"                       \"False if Neutron is being used in conjunction with \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3b474925_ee1912ea","line":92,"updated":"2021-09-08 17:58:56.000000000","message":"This change is actually removing support for this option as changing it\u0027s value has no effect.  Is it better to both deprecate and set it to True?  That way users get the effect of the change but can still set to False, even if no one probably ever will.  The majority of this patch would still apply, but the IPAM code would need to stay one more cycle.","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffd53d0652b98e791ce9a1af216ae08dc755c8fd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                       \" notification to DHCP agent\")),"},{"line_number":90,"context_line":"    cfg.BoolOpt(\u0027allow_overlapping_ips\u0027, default\u003dFalse,"},{"line_number":91,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":92,"context_line":"                deprecated_since\u003dversionutils.deprecated.XENA,"},{"line_number":93,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron. \""},{"line_number":94,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":95,"context_line":"                       \"False if Neutron is being used in conjunction with \""}],"source_content_type":"text/x-python","patch_set":1,"id":"77595a0e_8d9c18a9","line":92,"in_reply_to":"3b474925_ee1912ea","updated":"2021-10-11 11:06:41.000000000","message":"Done","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"}],"releasenotes/notes/Deprecate-allow_overlapping_ips-config-option-0e33af8876bad28f.yaml":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5babd25ebb401fb1f77f86840efeb4d3af310f7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13d73922_fb098b52","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":60},"updated":"2021-09-08 11:52:20.000000000","message":"for?","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffd53d0652b98e791ce9a1af216ae08dc755c8fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2f3af0bf_a7bd8c8b","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":60},"in_reply_to":"13d73922_fb098b52","updated":"2021-10-11 11:06:41.000000000","message":"Done","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5babd25ebb401fb1f77f86840efeb4d3af310f7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfff130c_d055334a","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":41},"updated":"2021-09-08 11:52:20.000000000","message":"behave","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffd53d0652b98e791ce9a1af216ae08dc755c8fd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"575e2c05_c6cf2d1a","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":41},"in_reply_to":"bfff130c_d055334a","updated":"2021-10-11 11:06:41.000000000","message":"Done","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5babd25ebb401fb1f77f86840efeb4d3af310f7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"49fef922_1a602aef","line":7,"range":{"start_line":6,"start_character":66,"end_line":7,"end_character":12},"updated":"2021-09-08 11:52:20.000000000","message":"Sounds a bit confusing: it was False by default, but now it will be always True. Maybe a few words to explain why default is changed would be useful.","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e661dbac7df2a2a21eda46793c530b385c12570","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b78271ea_9d806891","line":7,"range":{"start_line":6,"start_character":66,"end_line":7,"end_character":12},"in_reply_to":"49fef922_1a602aef","updated":"2021-09-08 17:58:56.000000000","message":"I would agree with Oleg that the text is a little confusing, especially\nsince the config option now has no effect on the IPAM code.  Perhaps\nthe below paragraph along with my other suggestion is better?\n\nConfig option ``allow_overlapping_ips`` is deprecated for removal.\nGoing forward, the value for this option will default to ``True``\nin the default IPAM module of Neutron, as the only reason it was\ndefaulting to ``False`` was to keep compatibility with Nova security\ngroup code that was removed in a previous cycle. The config option\nitself will removed in a future cycle.","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffd53d0652b98e791ce9a1af216ae08dc755c8fd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated to removal now."},{"line_number":5,"context_line":"    Default value for that option is ``False`` but Neutron with default IPAM"},{"line_number":6,"context_line":"    module will now ignore it and behaves always like it would be set to"},{"line_number":7,"context_line":"    ``True``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a68a4e20_cbeecc84","line":7,"range":{"start_line":6,"start_character":66,"end_line":7,"end_character":12},"in_reply_to":"b78271ea_9d806891","updated":"2021-10-11 11:06:41.000000000","message":"Done","commit_id":"05d422f0f3dfae4ab38954bc90f092830e5caf28"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9149144b9b462cdc49553654446916824767c376","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated for removal now."},{"line_number":5,"context_line":"    Default value for that option is now changed to the ``True`` in the default"},{"line_number":6,"context_line":"    IPAM module of Neutron, as the only reason it was defaulting to ``False``"},{"line_number":7,"context_line":"    was to keep compatibility with Nova security group code that was removed in"},{"line_number":8,"context_line":"    already.  The config option itself will removed in a future cycle."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7e68c2f_2af92647","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":79},"updated":"2021-10-15 06:58:26.000000000","message":"nit: it\u0027s not needed","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d38430a61624a78c41d26354ad41f18c1cd6a206","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Config option ``allow_overlapping_ips`` is deprecated for removal now."},{"line_number":5,"context_line":"    Default value for that option is now changed to the ``True`` in the default"},{"line_number":6,"context_line":"    IPAM module of Neutron, as the only reason it was defaulting to ``False``"},{"line_number":7,"context_line":"    was to keep compatibility with Nova security group code that was removed in"},{"line_number":8,"context_line":"    already.  The config option itself will removed in a future cycle."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"67b3dc71_a2628038","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":79},"in_reply_to":"c7e68c2f_2af92647","updated":"2021-10-21 10:56:46.000000000","message":"Done","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9149144b9b462cdc49553654446916824767c376","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    Default value for that option is now changed to the ``True`` in the default"},{"line_number":6,"context_line":"    IPAM module of Neutron, as the only reason it was defaulting to ``False``"},{"line_number":7,"context_line":"    was to keep compatibility with Nova security group code that was removed in"},{"line_number":8,"context_line":"    already.  The config option itself will removed in a future cycle."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c143a81e_65487491","line":8,"range":{"start_line":8,"start_character":57,"end_line":8,"end_character":69},"updated":"2021-10-15 06:58:26.000000000","message":"the commit msg says Z cycle","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d38430a61624a78c41d26354ad41f18c1cd6a206","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Default value for that option is now changed to the ``True`` in the default"},{"line_number":6,"context_line":"    IPAM module of Neutron, as the only reason it was defaulting to ``False``"},{"line_number":7,"context_line":"    was to keep compatibility with Nova security group code that was removed in"},{"line_number":8,"context_line":"    already.  The config option itself will removed in a future cycle."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d6c7fd79_ece43962","line":8,"range":{"start_line":8,"start_character":57,"end_line":8,"end_character":69},"in_reply_to":"c143a81e_65487491","updated":"2021-10-21 10:56:46.000000000","message":"Done","commit_id":"cfcd3abdbbffed2c348cd725f35a8884531eedf5"}]}