)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BFD for Neutron, server side"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TODO: For get_bfd_session_status at the moment I lack the idea how to"},{"line_number":10,"context_line":"pull BFD session state from the agent. My idea was to use pull rpc, but"},{"line_number":11,"context_line":"that is for the other direction for fetching OvO from the server to the"},{"line_number":12,"context_line":"agents."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I31a03c14e8ef183fee939d3e8366e8071a4f3b69"},{"line_number":15,"context_line":"Related-Bug: #1907089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f132cc6_284bb49c","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":7},"updated":"2021-09-14 14:22:27.000000000","message":"Do we want to block an api transaction until we request info from the agent and get a response? Wouldn\u0027t it be better to use the usual pattern like:\n\n1) the agent sending regular reports in a heartbeat message which gets persisted in the db\n2) neutron-server pulling info from the db?","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"}],"neutron/conf/policies/bfd.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027POST\u0027, \u0027path\u0027: COLLECTION_PATH}],"},{"line_number":28,"context_line":"    ),"},{"line_number":29,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":30,"context_line":"        name\u003d\u0027get_bf_monitor\u0027,"},{"line_number":31,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":32,"context_line":"        description\u003d\u0027Get bfd_monitors\u0027,"},{"line_number":33,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: COLLECTION_PATH},"}],"source_content_type":"text/x-python","patch_set":2,"id":"53d206c0_4056a345","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":20},"updated":"2021-09-14 14:22:27.000000000","message":"typo","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027POST\u0027, \u0027path\u0027: COLLECTION_PATH}],"},{"line_number":28,"context_line":"    ),"},{"line_number":29,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":30,"context_line":"        name\u003d\u0027get_bf_monitor\u0027,"},{"line_number":31,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":32,"context_line":"        description\u003d\u0027Get bfd_monitors\u0027,"},{"line_number":33,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: COLLECTION_PATH},"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc1901b9_87e7f65b","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":20},"in_reply_to":"53d206c0_4056a345","updated":"2021-09-20 11:51:49.000000000","message":"Done","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    ),"},{"line_number":29,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":30,"context_line":"        name\u003d\u0027get_bf_monitor\u0027,"},{"line_number":31,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":32,"context_line":"        description\u003d\u0027Get bfd_monitors\u0027,"},{"line_number":33,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: COLLECTION_PATH},"},{"line_number":34,"context_line":"                    {\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: RESOURCE_PATH}],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f42eb75_5a6cbc06","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":36},"updated":"2021-09-14 14:22:27.000000000","message":"What about SYSTEM_OR_PROJECT_READER?","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ),"},{"line_number":29,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":30,"context_line":"        name\u003d\u0027get_bf_monitor\u0027,"},{"line_number":31,"context_line":"        check_str\u003dbase.SYSTEM_READER,"},{"line_number":32,"context_line":"        description\u003d\u0027Get bfd_monitors\u0027,"},{"line_number":33,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: COLLECTION_PATH},"},{"line_number":34,"context_line":"                    {\u0027method\u0027: \u0027GET\u0027, \u0027path\u0027: RESOURCE_PATH}],"}],"source_content_type":"text/x-python","patch_set":2,"id":"441df27d_644e83c4","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":36},"in_reply_to":"5f42eb75_5a6cbc06","updated":"2021-09-20 11:51:49.000000000","message":"Done","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"    ),"},{"line_number":37,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":38,"context_line":"        name\u003d\u0027update_bf_monitor\u0027,"},{"line_number":39,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":40,"context_line":"        description\u003d\u0027Update a bfd_monitor\u0027,"},{"line_number":41,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027PUT\u0027, \u0027path\u0027: RESOURCE_PATH}],"}],"source_content_type":"text/x-python","patch_set":2,"id":"45fb5650_6ff7f983","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":23},"updated":"2021-09-14 14:22:27.000000000","message":"typo","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"    ),"},{"line_number":37,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":38,"context_line":"        name\u003d\u0027update_bf_monitor\u0027,"},{"line_number":39,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":40,"context_line":"        description\u003d\u0027Update a bfd_monitor\u0027,"},{"line_number":41,"context_line":"        operations\u003d[{\u0027method\u0027: \u0027PUT\u0027, \u0027path\u0027: RESOURCE_PATH}],"}],"source_content_type":"text/x-python","patch_set":2,"id":"43f29289_353cfe9a","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":23},"in_reply_to":"45fb5650_6ff7f983","updated":"2021-09-20 11:51:49.000000000","message":"Done","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"}],"neutron/db/bfd_db.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":32,"context_line":"AUTH_TPYE_PWD \u003d \u0027password\u0027  # nosec"},{"line_number":33,"context_line":"AUTH_TYPE_MD5 \u003d \u0027MD5\u0027"},{"line_number":34,"context_line":"AUTH_TYPE_METIC_MD5 \u003d \u0027MeticulousMD5\u0027"},{"line_number":35,"context_line":"AUTH_TYPE_SHA1 \u003d \u0027SHAI\u0027"},{"line_number":36,"context_line":"AUTH_TYPE_METIC_SHA1 \u003d \u0027MeticulousSHA1\u0027"},{"line_number":37,"context_line":"VALID_AUTH_TYPES \u003d (AUTH_TPYE_PWD, AUTH_TYPE_MD5, AUTH_TYPE_METIC_MD5,"},{"line_number":38,"context_line":"                    AUTH_TYPE_SHA1, AUTH_TYPE_METIC_SHA1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"861d063d_4009e0f1","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":22},"updated":"2021-09-14 14:22:27.000000000","message":"typo?","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":false,"context_lines":[{"line_number":32,"context_line":"AUTH_TPYE_PWD \u003d \u0027password\u0027  # nosec"},{"line_number":33,"context_line":"AUTH_TYPE_MD5 \u003d \u0027MD5\u0027"},{"line_number":34,"context_line":"AUTH_TYPE_METIC_MD5 \u003d \u0027MeticulousMD5\u0027"},{"line_number":35,"context_line":"AUTH_TYPE_SHA1 \u003d \u0027SHAI\u0027"},{"line_number":36,"context_line":"AUTH_TYPE_METIC_SHA1 \u003d \u0027MeticulousSHA1\u0027"},{"line_number":37,"context_line":"VALID_AUTH_TYPES \u003d (AUTH_TPYE_PWD, AUTH_TYPE_MD5, AUTH_TYPE_METIC_MD5,"},{"line_number":38,"context_line":"                    AUTH_TYPE_SHA1, AUTH_TYPE_METIC_SHA1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d40d159_8aef15ce","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":22},"in_reply_to":"861d063d_4009e0f1","updated":"2021-09-20 11:51:49.000000000","message":"Done","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @log_helpers.log_method_call"},{"line_number":63,"context_line":"    def _validate_bfd_monitor(self, fields):"},{"line_number":64,"context_line":"        if \u0027mode\u0027 in fields and fields[\u0027mode\u0027] not in VALID_MODES:"},{"line_number":65,"context_line":"            msg \u003d (_(\u0027BFD monitor mode can be only one of %s,\u0027) %"},{"line_number":66,"context_line":"                   (VALID_MODES,))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fe4f07f_ff6d3dc3","line":63,"updated":"2021-09-14 14:22:27.000000000","message":"This is usually done by introducing validators in neutron_lib/api/validators/ which we can use from the RESOURCE_ATTRIBUTE_MAP.","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @log_helpers.log_method_call"},{"line_number":63,"context_line":"    def _validate_bfd_monitor(self, fields):"},{"line_number":64,"context_line":"        if \u0027mode\u0027 in fields and fields[\u0027mode\u0027] not in VALID_MODES:"},{"line_number":65,"context_line":"            msg \u003d (_(\u0027BFD monitor mode can be only one of %s,\u0027) %"},{"line_number":66,"context_line":"                   (VALID_MODES,))"}],"source_content_type":"text/x-python","patch_set":2,"id":"67cad1d2_cb679395","line":63,"in_reply_to":"5fe4f07f_ff6d3dc3","updated":"2021-09-20 11:51:49.000000000","message":"That\u0027s true, I added new validators for the mode and auth_type validation (https://review.opendev.org/c/openstack/neutron-lib/+/809978 ), thanks.\nI have to keep the auth key validation here, as this validation needs what is or what\u0027s not in auth_type.","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            min_rx\u003dfields.get(\u0027min_rx\u0027),"},{"line_number":101,"context_line":"            min_tx\u003dfields.get(\u0027min_tx\u0027),"},{"line_number":102,"context_line":"            multiplier\u003dfields.get(\u0027multiplier\u0027),"},{"line_number":103,"context_line":"            status\u003dn_const.ACTIVE,"},{"line_number":104,"context_line":"        )"},{"line_number":105,"context_line":"        if (not fields.get(\u0027auth_type\u0027) or"},{"line_number":106,"context_line":"                fields[\u0027auth_type\u0027] \u003d\u003d n_const.ATTR_NOT_SPECIFIED):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c83c380_f7a62706","line":103,"updated":"2021-09-14 14:22:27.000000000","message":"Do we go to ACTIVE status right away?","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            min_rx\u003dfields.get(\u0027min_rx\u0027),"},{"line_number":101,"context_line":"            min_tx\u003dfields.get(\u0027min_tx\u0027),"},{"line_number":102,"context_line":"            multiplier\u003dfields.get(\u0027multiplier\u0027),"},{"line_number":103,"context_line":"            status\u003dn_const.ACTIVE,"},{"line_number":104,"context_line":"        )"},{"line_number":105,"context_line":"        if (not fields.get(\u0027auth_type\u0027) or"},{"line_number":106,"context_line":"                fields[\u0027auth_type\u0027] \u003d\u003d n_const.ATTR_NOT_SPECIFIED):"}],"source_content_type":"text/x-python","patch_set":2,"id":"72a87210_ac734021","line":103,"in_reply_to":"4c83c380_f7a62706","updated":"2021-09-20 11:51:49.000000000","message":"No, this is just the current state of the code, and I jumped this part :-)","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                                                   router_id\u003drouter.id,"},{"line_number":137,"context_line":"                                                   bfd_monitor_id\u003dbfd_id)"},{"line_number":138,"context_line":"            if routes:"},{"line_number":139,"context_line":"                all_routes \u003d routes"},{"line_number":140,"context_line":"        return all_routes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":2,"id":"01755174_44dbb99c","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":28},"updated":"2021-09-14 14:22:27.000000000","message":"Is this intentional? Didn\u0027t you want to append here?","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                                                   router_id\u003drouter.id,"},{"line_number":137,"context_line":"                                                   bfd_monitor_id\u003dbfd_id)"},{"line_number":138,"context_line":"            if routes:"},{"line_number":139,"context_line":"                all_routes \u003d routes"},{"line_number":140,"context_line":"        return all_routes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":2,"id":"84e7d22e_748395f1","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":28},"in_reply_to":"01755174_44dbb99c","updated":"2021-09-20 11:51:49.000000000","message":"thanks, that was a mistake","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"}],"neutron/db/migration/alembic_migrations/versions/xena/expand/ad888b9c65d9_bfd_support_for_neutron.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f8ef7582c35a789faf636179fdd39bca802bfb07","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            length\u003dconstants.DESCRIPTION_FIELD_SIZE), nullable\u003dTrue),"},{"line_number":43,"context_line":"        sa.Column(\u0027mode\u0027, sa.String(length\u003dconstants.STATUS_FIELD_SIZE)),"},{"line_number":44,"context_line":"        sa.Column(\u0027dst_ip\u0027, sa.String(length\u003d64)),"},{"line_number":45,"context_line":"        sa.Column(\u0027src_ip\u0027, sa.String(length\u003d64)),"},{"line_number":46,"context_line":"        sa.Column(\u0027min_rx\u0027, sa.Integer(), nullable\u003dFalse,"},{"line_number":47,"context_line":"                  server_default\u003d\u00271000\u0027),"},{"line_number":48,"context_line":"        sa.Column(\u0027min_tx\u0027, sa.Integer(), nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8f3454eb_bbeab9a4","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":25},"updated":"2021-09-14 14:22:27.000000000","message":"In the ovo definition class this is nullable.","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"}],"neutron/db/migration/alembic_migrations/versions/yoga/expand/ad888b9c65d9_bfd_support_for_neutron.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6d9c168339911bdb541164657dbf8157c0b1f85","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"337cc841_e171a885","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":25},"in_reply_to":"8f3454eb_bbeab9a4","updated":"2021-09-20 11:51:49.000000000","message":"thanks, good catch","commit_id":"9d63e75cd8f26ebcb9f8f5fdb44a161ffb8f16fe"}]}