)]}'
{"neutron/plugins/ofagent/agent/ofa_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a52edc2132860e82957a93738802520b7b59ec83","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # they are not used since there is no guarantee the notifications"},{"line_number":359,"context_line":"        # are processed in the same order as the relevant API requests"},{"line_number":360,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":361,"context_line":"        LOG.debug(_(\"port_update received port %s\"), port[\u0027id\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":364,"context_line":"        LOG.debug(_(\"tunnel_update received\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F8gI%3D","line":361,"updated":"2014-04-09 10:25:05.000000000","message":"I think you should add the port to the updated_ports set\n\nself.updated_ports.add(port[\u0027id\u0027])","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"44d4d0cf64a600bd262b6129a1f248ff18ce9e97","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # they are not used since there is no guarantee the notifications"},{"line_number":359,"context_line":"        # are processed in the same order as the relevant API requests"},{"line_number":360,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":361,"context_line":"        LOG.debug(_(\"port_update received port %s\"), port[\u0027id\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":364,"context_line":"        LOG.debug(_(\"tunnel_update received\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FzgQ%3D","line":361,"in_reply_to":"AAAAW3%2F%2F2bA%3D","updated":"2014-04-10 09:46:47.000000000","message":"Sorry, I wonder now how I could miss that line :) !","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"29846511793bf637cc8101ec0364376f4c7edd40","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # they are not used since there is no guarantee the notifications"},{"line_number":359,"context_line":"        # are processed in the same order as the relevant API requests"},{"line_number":360,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":361,"context_line":"        LOG.debug(_(\"port_update received port %s\"), port[\u0027id\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":364,"context_line":"        LOG.debug(_(\"tunnel_update received\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F2bA%3D","line":361,"in_reply_to":"AAAAW3%2F%2F8gI%3D","updated":"2014-04-09 23:31:44.000000000","message":"Thank you for your check. But are you not forgetting to check the L360 ?","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a52edc2132860e82957a93738802520b7b59ec83","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                        self.context, device, self.agent_id, cfg.CONF.host)"},{"line_number":1088,"context_line":"                LOG.info(_(\"Configuration for device %s completed.\"), device)"},{"line_number":1089,"context_line":"            else:"},{"line_number":1090,"context_line":"                LOG.warn(_(\"Device %s not defined on plugin\"), device)"},{"line_number":1091,"context_line":"                if (port and int(port.ofport) !\u003d -1):"},{"line_number":1092,"context_line":"                    self.port_dead(port)"},{"line_number":1093,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F8eg%3D","line":1090,"updated":"2014-04-09 10:25:05.000000000","message":"why warn level?","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"44d4d0cf64a600bd262b6129a1f248ff18ce9e97","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                        self.context, device, self.agent_id, cfg.CONF.host)"},{"line_number":1088,"context_line":"                LOG.info(_(\"Configuration for device %s completed.\"), device)"},{"line_number":1089,"context_line":"            else:"},{"line_number":1090,"context_line":"                LOG.warn(_(\"Device %s not defined on plugin\"), device)"},{"line_number":1091,"context_line":"                if (port and int(port.ofport) !\u003d -1):"},{"line_number":1092,"context_line":"                    self.port_dead(port)"},{"line_number":1093,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2Fzfw%3D","line":1090,"in_reply_to":"AAAAW3%2F%2F2a4%3D","updated":"2014-04-10 09:46:47.000000000","message":"Got it","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"29846511793bf637cc8101ec0364376f4c7edd40","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"                        self.context, device, self.agent_id, cfg.CONF.host)"},{"line_number":1088,"context_line":"                LOG.info(_(\"Configuration for device %s completed.\"), device)"},{"line_number":1089,"context_line":"            else:"},{"line_number":1090,"context_line":"                LOG.warn(_(\"Device %s not defined on plugin\"), device)"},{"line_number":1091,"context_line":"                if (port and int(port.ofport) !\u003d -1):"},{"line_number":1092,"context_line":"                    self.port_dead(port)"},{"line_number":1093,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F2a4%3D","line":1090,"in_reply_to":"AAAAW3%2F%2F8eg%3D","updated":"2014-04-09 23:31:44.000000000","message":"This is what a part of patch 2702baed390d094b0eac07d0ae167ed236868d00 remained when split the patch set 2. But this will be no problem even if I do that patch here.","commit_id":"cfb09ab62cf84c7dee077f72259ef2b760832413"}]}