)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"666d5975369e3b92320cffa225c47ca82fefce79","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Show neutron API request body with debug enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Shows the contents of udpate and create requests"},{"line_number":10,"context_line":"to the neutron API when debugging is enabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #982504"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fa0w%3D","line":9,"updated":"2014-03-18 00:49:04.000000000","message":"s/udpate/update","commit_id":"1e0f492cce101d5cc43fbf84e50a2b8342096acf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b6266d53899a305e7b8ca904bb1f9755d5686d69","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Show neutron API request body with debug enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Shows the contents of udpate and create requests"},{"line_number":10,"context_line":"to the neutron API when debugging is enabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #982504"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fajc%3D","line":9,"in_reply_to":"AAAAWH%2F%2Fa0w%3D","updated":"2014-03-18 01:46:40.000000000","message":"Done","commit_id":"1e0f492cce101d5cc43fbf84e50a2b8342096acf"}],"neutron/api/v2/base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"666d5975369e3b92320cffa225c47ca82fefce79","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        body argument must be the deserialized body."},{"line_number":549,"context_line":"        \"\"\""},{"line_number":550,"context_line":"        LOG.debug(_(\"Request body: %(body)s\"), {\u0027body\u0027: body})"},{"line_number":551,"context_line":"        collection \u003d resource + \"s\""},{"line_number":552,"context_line":"        if not body:"},{"line_number":553,"context_line":"            raise webob.exc.HTTPBadRequest(_(\"Resource body required\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fa0A%3D","line":550,"updated":"2014-03-18 00:49:04.000000000","message":"This debug message is done before even verifying that the body is not None (see line 552 below). Not sure I see the worth of this debug statement until at least line 577, which is after all the common error handling.","commit_id":"1e0f492cce101d5cc43fbf84e50a2b8342096acf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b6266d53899a305e7b8ca904bb1f9755d5686d69","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        body argument must be the deserialized body."},{"line_number":549,"context_line":"        \"\"\""},{"line_number":550,"context_line":"        LOG.debug(_(\"Request body: %(body)s\"), {\u0027body\u0027: body})"},{"line_number":551,"context_line":"        collection \u003d resource + \"s\""},{"line_number":552,"context_line":"        if not body:"},{"line_number":553,"context_line":"            raise webob.exc.HTTPBadRequest(_(\"Resource body required\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FakY%3D","line":550,"in_reply_to":"AAAAWH%2F%2Fa0A%3D","updated":"2014-03-18 01:46:40.000000000","message":"I intentionally had put it up here to see when the body is none, although I suppose that\u0027s not necessary since there is a specific error just for that. I\u0027ll move it after that. However, I do think it belongs up above the validation routines because one of the more useful times to have the body is when it\u0027s failing validation.","commit_id":"1e0f492cce101d5cc43fbf84e50a2b8342096acf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"c423992e65753404054cda99de8fa7204d6fc618","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        if not body:"},{"line_number":552,"context_line":"            raise webob.exc.HTTPBadRequest(_(\"Resource body required\"))"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        LOG.debug(_(\"Request body: %(body)s\"), {\u0027body\u0027: body})"},{"line_number":555,"context_line":"        prep_req_body \u003d lambda x: Controller.prepare_request_body("},{"line_number":556,"context_line":"            context,"},{"line_number":557,"context_line":"            x if resource in x else {resource: x},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FP9Y%3D","line":554,"updated":"2014-03-19 05:49:51.000000000","message":"I  this should just be , body) just by convention but  no worries since we don\u0027t have a checker for it.","commit_id":"10a721bb5044fdc36aba4e6a6af753a1233655a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"34bd1a27fcc69167284704a521f9d6ee49d74c1b","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        if not body:"},{"line_number":552,"context_line":"            raise webob.exc.HTTPBadRequest(_(\"Resource body required\"))"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        LOG.debug(_(\"Request body: %(body)s\"), {\u0027body\u0027: body})"},{"line_number":555,"context_line":"        prep_req_body \u003d lambda x: Controller.prepare_request_body("},{"line_number":556,"context_line":"            context,"},{"line_number":557,"context_line":"            x if resource in x else {resource: x},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FPHs%3D","line":554,"in_reply_to":"AAAAWH%2F%2FP9Y%3D","updated":"2014-03-19 08:01:18.000000000","message":"There is a checker tools/check_i18n.py but it is not automated because it has some false positives AFAIK.","commit_id":"10a721bb5044fdc36aba4e6a6af753a1233655a1"}]}