)]}'
{"neutron/services/vpn/device_drivers/ipsec.py":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"a122ebbe7da47cab569a32a022b111cd882a9eab","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    def update_downed_connections(self, process_id, new_status):"},{"line_number":628,"context_line":"        \"\"\"Update info to be reported, if connections just went down."},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        If there is no longer any information for a connection (because it"},{"line_number":631,"context_line":"        has been removed (e.g. due to an admin down of VPN service or IPSec"},{"line_number":632,"context_line":"        connection), but there was previous status information for the"},{"line_number":633,"context_line":"        connection, mark the connection as down for reporting purposes."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BbkA%3D","line":630,"updated":"2014-03-27 12:48:16.000000000","message":"Looks like you\u0027re missing a closing \")\".","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"104f81cf5db2ba782f8273dd447f86505936c303","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    def update_downed_connections(self, process_id, new_status):"},{"line_number":628,"context_line":"        \"\"\"Update info to be reported, if connections just went down."},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        If there is no longer any information for a connection (because it"},{"line_number":631,"context_line":"        has been removed (e.g. due to an admin down of VPN service or IPSec"},{"line_number":632,"context_line":"        connection), but there was previous status information for the"},{"line_number":633,"context_line":"        connection, mark the connection as down for reporting purposes."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BU9Q%3D","line":630,"in_reply_to":"AAAAWH%2F%2BbkA%3D","updated":"2014-03-27 17:15:37.000000000","message":"Will do, if need to update diff, otherwise in a later commit.","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0fa65378f80fe1260c1d2ef5ca3cd6e873a337bf","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        connection, mark the connection as down for reporting purposes."},{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        if process_id in self.process_status_cache:"},{"line_number":636,"context_line":"            for conn in self.process_status_cache[process_id][IPSEC_CONNS]:"},{"line_number":637,"context_line":"                if conn not in new_status[IPSEC_CONNS]:"},{"line_number":638,"context_line":"                    new_status[IPSEC_CONNS][conn] \u003d {"},{"line_number":639,"context_line":"                        \u0027status\u0027: constants.DOWN,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BVUQ%3D","line":636,"updated":"2014-03-27 15:15:08.000000000","message":"this has the downside that then if an agent crashes and does not report anymore the connection would never be downed; but there is no need to address now. can be done as a follow-up","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"104f81cf5db2ba782f8273dd447f86505936c303","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        connection, mark the connection as down for reporting purposes."},{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        if process_id in self.process_status_cache:"},{"line_number":636,"context_line":"            for conn in self.process_status_cache[process_id][IPSEC_CONNS]:"},{"line_number":637,"context_line":"                if conn not in new_status[IPSEC_CONNS]:"},{"line_number":638,"context_line":"                    new_status[IPSEC_CONNS][conn] \u003d {"},{"line_number":639,"context_line":"                        \u0027status\u0027: constants.DOWN,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BUIA%3D","line":636,"in_reply_to":"AAAAWH%2F%2BVUQ%3D","updated":"2014-03-27 17:15:37.000000000","message":"Correct, however, in that case the connection would be down, even though the status would not indicate the change,\n\nNote: There currently isn\u0027t any support in the reference implementation for agent restart (no sync upon startup). It\u0027s a failure mode that needs addressing.","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"}],"neutron/services/vpn/plugin.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"f8a396dfd2ca32fc7be2fb2522620b82c48312ec","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return ipsec_site_connection"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def update_vpnservice(self, context, vpnservice_id, vpnservice):"},{"line_number":95,"context_line":"        LOG.info(_(\"PCM plugin called for update service %r\"), vpnservice)"},{"line_number":96,"context_line":"        old_vpn_service \u003d self.get_vpnservice(context, vpnservice_id)"},{"line_number":97,"context_line":"        new_vpn_service \u003d super("},{"line_number":98,"context_line":"            VPNDriverPlugin, self).update_vpnservice(context, vpnservice_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fan8%3D","line":95,"updated":"2014-03-18 01:30:58.000000000","message":"Did you mean VPN plugin?\nI will remove the -1 if that is indeed the case.","commit_id":"f18caf6631a38375f1ef4d45686b637cd57917ce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b9f34d44716f2516e2c71ad166cccc8a66293156","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return ipsec_site_connection"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def update_vpnservice(self, context, vpnservice_id, vpnservice):"},{"line_number":95,"context_line":"        LOG.info(_(\"PCM plugin called for update service %r\"), vpnservice)"},{"line_number":96,"context_line":"        old_vpn_service \u003d self.get_vpnservice(context, vpnservice_id)"},{"line_number":97,"context_line":"        new_vpn_service \u003d super("},{"line_number":98,"context_line":"            VPNDriverPlugin, self).update_vpnservice(context, vpnservice_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FXJ8%3D","line":95,"in_reply_to":"AAAAWH%2F%2Fan8%3D","updated":"2014-03-18 11:24:53.000000000","message":"It was a left over debug log. Will remove on next patch.","commit_id":"f18caf6631a38375f1ef4d45686b637cd57917ce"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"a122ebbe7da47cab569a32a022b111cd882a9eab","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        old_vpn_service \u003d self.get_vpnservice(context, vpnservice_id)"},{"line_number":96,"context_line":"        new_vpn_service \u003d super("},{"line_number":97,"context_line":"            VPNDriverPlugin, self).update_vpnservice(context, vpnservice_id,"},{"line_number":98,"context_line":"                                                     vpnservice)"},{"line_number":99,"context_line":"        driver \u003d self._get_driver_for_vpnservice(old_vpn_service)"},{"line_number":100,"context_line":"        driver.update_vpnservice(context, old_vpn_service, new_vpn_service)"},{"line_number":101,"context_line":"        return new_vpn_service"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BbhI%3D","line":98,"updated":"2014-03-27 12:48:16.000000000","message":"Don\u0027t care if you change it but I\u0027m a bit surprised your python editor didn\u0027t line up vpnservice directly under context.","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"104f81cf5db2ba782f8273dd447f86505936c303","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        old_vpn_service \u003d self.get_vpnservice(context, vpnservice_id)"},{"line_number":96,"context_line":"        new_vpn_service \u003d super("},{"line_number":97,"context_line":"            VPNDriverPlugin, self).update_vpnservice(context, vpnservice_id,"},{"line_number":98,"context_line":"                                                     vpnservice)"},{"line_number":99,"context_line":"        driver \u003d self._get_driver_for_vpnservice(old_vpn_service)"},{"line_number":100,"context_line":"        driver.update_vpnservice(context, old_vpn_service, new_vpn_service)"},{"line_number":101,"context_line":"        return new_vpn_service"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BUHU%3D","line":98,"in_reply_to":"AAAAWH%2F%2BbhI%3D","updated":"2014-03-27 17:15:37.000000000","message":"It is lined up. Just an artifact of Gerrit\u0027s output on the browser. IT passes the anal PEP8 :)","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"}],"neutron/tests/unit/services/vpn/device_drivers/test_ipsec.py":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"a122ebbe7da47cab569a32a022b111cd882a9eab","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_status_updated_on_connection_admin_down(self):"},{"line_number":195,"context_line":"        self.driver.process_status_cache \u003d {"},{"line_number":196,"context_line":"            \u00271\u0027: {"},{"line_number":197,"context_line":"                \u0027status\u0027: constants.ACTIVE,"},{"line_number":198,"context_line":"                \u0027id\u0027: 123,"},{"line_number":199,"context_line":"                \u0027updated_pending_status\u0027: False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Bbec%3D","line":196,"updated":"2014-03-27 12:48:16.000000000","message":"It may be helpful to create variables for \u00271\u0027, \u002710\u0027 and \u002720\u0027 in this module.","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"104f81cf5db2ba782f8273dd447f86505936c303","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_status_updated_on_connection_admin_down(self):"},{"line_number":195,"context_line":"        self.driver.process_status_cache \u003d {"},{"line_number":196,"context_line":"            \u00271\u0027: {"},{"line_number":197,"context_line":"                \u0027status\u0027: constants.ACTIVE,"},{"line_number":198,"context_line":"                \u0027id\u0027: 123,"},{"line_number":199,"context_line":"                \u0027updated_pending_status\u0027: False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BUFg%3D","line":196,"in_reply_to":"AAAAWH%2F%2Bbec%3D","updated":"2014-03-27 17:15:37.000000000","message":"Gonna leave this as-is, they are arbitrary numbers for the service and connection IDs (rather than using UUIDs). Providing a label doesn\u0027t much value, IMHO.","commit_id":"23037823adbbf0bfc9c6398e8d460e84d49e4e6f"}]}