)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c51a7bcae00c86f6315a8fc9266f715c88bb1a71","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove SubnetDNSPublishFixedIP from Subnet query"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change \"SubnetDNSPublishFixedIP.subnet\" load method to \"subquery\"."},{"line_number":10,"context_line":"Now in the subnet OVO query, the register \"subnet_dns_publish_fixed_ips\""},{"line_number":11,"context_line":"won\u0027t be present, reducing the query complexity."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5788e10b_797f4f0a","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":64},"updated":"2021-11-19 13:21:32.000000000","message":"\u0027select\u0027","commit_id":"4bb09f429a8e6575eaa5518ece52a4d2a95e1cd8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6bace200045010a3b85e0a62c3cbd6a10da6ba27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove SubnetDNSPublishFixedIP from Subnet query"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change \"SubnetDNSPublishFixedIP.subnet\" load method to \"subquery\"."},{"line_number":10,"context_line":"Now in the subnet OVO query, the register \"subnet_dns_publish_fixed_ips\""},{"line_number":11,"context_line":"won\u0027t be present, reducing the query complexity."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8033f45b_f4e9fe02","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":64},"in_reply_to":"5788e10b_797f4f0a","updated":"2021-11-19 13:58:21.000000000","message":"Done","commit_id":"4bb09f429a8e6575eaa5518ece52a4d2a95e1cd8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d6f7c9e926881f139cae6ced77755f6a2d038bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a201ff7_c92b6869","updated":"2021-10-27 16:10:54.000000000","message":"Thanks for this, I just copied what was already there when I created the extension, but I agree with the idea, just some comments inline.","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"006c5b33956e062482e4d7c7fa624ec07e606ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f9cb18f_af3a85e6","updated":"2021-11-20 19:11:40.000000000","message":"The failures look real to me. Guess it shows the sad state of neutron CI stability that people just keep rechecking instead of actually looking at failures :-(","commit_id":"82fe02650ccf0db0e686d9a057cc5f704ace58a9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"33de52a6a7f08cb62f521f34a33ac1d56df4326e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04b1f340_c0804872","in_reply_to":"1f9cb18f_af3a85e6","updated":"2021-11-21 09:33:37.000000000","message":"No, it isn\u0027t. I admit using a script to recheck some patches that I knew for sure were working. This is not the case.\n\nBut we are working hard on stabilizing one of the most complex CIs in OpenStack. I take this comment as personal as I\u0027m involved in it.","commit_id":"82fe02650ccf0db0e686d9a057cc5f704ace58a9"}],"neutron/db/models/dns.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d6f7c9e926881f139cae6ced77755f6a2d038bf0","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                                     server_default\u003dsql.false())"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Add a relationship to the Subnet model in order to instruct"},{"line_number":115,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":116,"context_line":"    subnet \u003d orm.relationship(models_v2.Subnet,"},{"line_number":117,"context_line":"                              load_on_pending\u003dTrue,"},{"line_number":118,"context_line":"                              backref\u003dorm.backref(\"dns_publish_fixed_ip\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a54cf69_695d241e","line":115,"updated":"2021-10-27 16:10:54.000000000","message":"I think you want to update this description accordingly","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b543f59f0c06eda72bce5c257733771874fcaf97","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                     server_default\u003dsql.false())"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Add a relationship to the Subnet model in order to instruct"},{"line_number":115,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":116,"context_line":"    subnet \u003d orm.relationship(models_v2.Subnet,"},{"line_number":117,"context_line":"                              load_on_pending\u003dTrue,"},{"line_number":118,"context_line":"                              backref\u003dorm.backref(\"dns_publish_fixed_ip\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1d9edf5d_8441bc6f","line":115,"in_reply_to":"7a54cf69_695d241e","updated":"2021-11-19 12:39:55.000000000","message":"Done","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d6f7c9e926881f139cae6ced77755f6a2d038bf0","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    subnet \u003d orm.relationship(models_v2.Subnet,"},{"line_number":117,"context_line":"                              load_on_pending\u003dTrue,"},{"line_number":118,"context_line":"                              backref\u003dorm.backref(\"dns_publish_fixed_ip\","},{"line_number":119,"context_line":"                                                  lazy\u003d\u0027subquery\u0027,"},{"line_number":120,"context_line":"                                                  uselist\u003dFalse,"},{"line_number":121,"context_line":"                                                  cascade\u003d\u0027delete\u0027))"},{"line_number":122,"context_line":"    revises_on_change \u003d (\u0027subnet\u0027, )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab5deb40_7a34e050","line":119,"updated":"2021-10-27 16:10:54.000000000","message":"From https://docs.sqlalchemy.org/en/14/orm/loading_relationships.html it seems that \"lazy\u003dselect\" might be even more ... lazy?","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5228417b14540e98ef1305accf17640dc0b2a7fb","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    subnet \u003d orm.relationship(models_v2.Subnet,"},{"line_number":117,"context_line":"                              load_on_pending\u003dTrue,"},{"line_number":118,"context_line":"                              backref\u003dorm.backref(\"dns_publish_fixed_ip\","},{"line_number":119,"context_line":"                                                  lazy\u003d\u0027subquery\u0027,"},{"line_number":120,"context_line":"                                                  uselist\u003dFalse,"},{"line_number":121,"context_line":"                                                  cascade\u003d\u0027delete\u0027))"},{"line_number":122,"context_line":"    revises_on_change \u003d (\u0027subnet\u0027, )"}],"source_content_type":"text/x-python","patch_set":3,"id":"eab58549_3b0c9220","line":119,"in_reply_to":"10c877b5_67e48058","updated":"2021-11-22 09:57:13.000000000","message":"When testing this feature, I found that \"select\" will issue a new query each time we need to access to this parameter [1]. That will reduce the subnet complexity but add new request to the DB. That seems inefficient.\n\n[1]https://8fbe67ff850b8e597cb2-09419825a71508c658bc83d968b5572f.ssl.cf1.rackcdn.com/811999/5/check/openstack-tox-py36/4ad7470/testr_results.html","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b543f59f0c06eda72bce5c257733771874fcaf97","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    subnet \u003d orm.relationship(models_v2.Subnet,"},{"line_number":117,"context_line":"                              load_on_pending\u003dTrue,"},{"line_number":118,"context_line":"                              backref\u003dorm.backref(\"dns_publish_fixed_ip\","},{"line_number":119,"context_line":"                                                  lazy\u003d\u0027subquery\u0027,"},{"line_number":120,"context_line":"                                                  uselist\u003dFalse,"},{"line_number":121,"context_line":"                                                  cascade\u003d\u0027delete\u0027))"},{"line_number":122,"context_line":"    revises_on_change \u003d (\u0027subnet\u0027, )"}],"source_content_type":"text/x-python","patch_set":3,"id":"10c877b5_67e48058","line":119,"in_reply_to":"ab5deb40_7a34e050","updated":"2021-11-19 12:39:55.000000000","message":"You are right and this parameter is only used when the extension is loaded. By default we don\u0027t need to read \"dns_publish_fixed_ip\" field.","commit_id":"3448d7e38ca3c3591538d9b61bb6355685c9ca53"}]}