)]}'
{"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"9c76d147510f6a930cd728896cc3ded08155c24b","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    grep -q -- \u0027--answers-file\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":61,"context_line":"    check3\u003d$?"},{"line_number":62,"context_line":"    grep -q -- \u0027--templates-directory\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":63,"context_line":"    check4\u003d$?"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"}],"source_content_type":"text/x-sh","patch_set":1,"id":"d0c506b4_809681f8","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":37},"updated":"2021-10-06 21:21:40.000000000","message":"I am not so familiar with the parameters of \u0027openstack overcloud deploy\u0027 but in the help I can\u0027t find --templates-directory, found only --templates parameter.","commit_id":"a5aff819946bbe8435d10cebe6ad4958a0b3eebd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"323af240d8bfeb44626f284dbafcb11bde74e6b0","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        exit 1"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    grep -q -- \u0027--answers-file\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":61,"context_line":"    check3\u003d$?"},{"line_number":62,"context_line":"    grep -q -- \u0027--templates-directory\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":63,"context_line":"    check4\u003d$?"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":66,"context_line":"    if [[ $? -eq 1 ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"de866a6f_5f26c38e","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":13},"updated":"2021-10-06 19:43:50.000000000","message":"I know this is the format that\u0027s been used before. But perhaps since we\u0027re touching the code would the following be better?\n\n grep -q -- \u0027--answers-file\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT || grep -q -- \u0027--templates-directory\u0027  $OVERCLOUD_OVN_DEPLOY_SCRIPT\n answers_templates_check\u003d$?\n\n ...\n\n if [[ $answers_templates_check -ne 0 ]]; then\n     ...","commit_id":"a5aff819946bbe8435d10cebe6ad4958a0b3eebd"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"9c76d147510f6a930cd728896cc3ded08155c24b","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":66,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":67,"context_line":"        if [[ $check3 -eq 1 || $check4 -eq 1 ]]; then"},{"line_number":68,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory ( --answers-file/--templates-directory) \" \\"},{"line_number":69,"context_line":"                    \"\\nYou MUST make sure the proper OVN files are included in the templates called by your deploy script\""},{"line_number":70,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bcf08212_7de4856a","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":48},"updated":"2021-10-06 21:21:40.000000000","message":"shouldn\u0027t it be \"if [[ $check3 -eq 0 || $check4 -eq 0 ]]? i.e. print WARNING if either --answers-file or --templates-directory was found. Currently it prints the warning if either of them is NOT found.","commit_id":"a5aff819946bbe8435d10cebe6ad4958a0b3eebd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"323af240d8bfeb44626f284dbafcb11bde74e6b0","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            exit 1"},{"line_number":75,"context_line":"        fi"},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    grep -q \\$HOME/ovn-extras.yaml $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":79,"context_line":"    check1\u003d$?"},{"line_number":80,"context_line":"    grep -q $HOME/ovn-extras.yaml $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":81,"context_line":"    check2\u003d$?"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if [[ $check1 -eq 1 \u0026\u0026 $check2 -eq 1 ]]; then"},{"line_number":84,"context_line":"        # specific case of --answers-file/--templates-directory"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5b8406_744f19f2","line":81,"range":{"start_line":77,"start_character":0,"end_line":81,"end_character":13},"updated":"2021-10-06 19:43:50.000000000","message":"ditto","commit_id":"a5aff819946bbe8435d10cebe6ad4958a0b3eebd"}]}