)]}'
{"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2b242051952123ff95b4b14eeb9acc9cdbc0de5e","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":64,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":65,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":66,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":67,"context_line":"                    \" ( --answers-file/--environment-directory) \" \\"},{"line_number":68,"context_line":"                    \"\\nYou MUST make sure the proper OVN files are included in the templates called by your deploy script\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"e80a4951_649ca4b0","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":42},"updated":"2021-10-07 19:42:14.000000000","message":"Shouldn\u0027t this be -ne ?","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ce7382b0511403409375bfb64d32ae611c1bce9b","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":64,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":65,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":66,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":67,"context_line":"                    \" ( --answers-file/--environment-directory) \" \\"},{"line_number":68,"context_line":"                    \"\\nYou MUST make sure the proper OVN files are included in the templates called by your deploy script\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"c31a00d9_ab0b764b","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":42},"in_reply_to":"9449d7f2_28851123","updated":"2021-10-26 13:16:56.000000000","message":"ah, gotcha. :) sorry","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":19743,"name":"VIncent S. Cojot","email":"vincent@cojot.name","username":"ElCoyote"},"change_message_id":"a77ce6c3e30bb4b175340b947ded6bf06f86684b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":64,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":65,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":66,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":67,"context_line":"                    \" ( --answers-file/--environment-directory) \" \\"},{"line_number":68,"context_line":"                    \"\\nYou MUST make sure the proper OVN files are included in the templates called by your deploy script\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7aa086bb_c340295b","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":42},"in_reply_to":"e80a4951_649ca4b0","updated":"2021-11-22 14:05:42.000000000","message":"I think you\u0027re right, answers file could be found, or environment directory or both\nI tested the script today with \u0027-eq 0\u0027 and it worked fine (displaying the proper outputs).\nI\u0027ll test your changes and report back here.\n\nI tested again with \u0027-eq 0\u0027 and it does the right thing:\ncase #1) no \u0027answers-file\u0027 and no \u0027environment directory\u0027\ncase #2) 1 \u0027answers-file\u0027 and no \u0027environment directory\u0027\ncase #3) no \u0027answers-file\u0027 and 1 \u0027environment directory\u0027\ncase #4) 1 \u0027answers-file\u0027 and 1 \u0027environment directory\u0027\n\nboth 4 cases work displaying the right message when using \u0027-eq 0\u0027","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0045a8601681705eb0c70b53c4b1bba0ae0c7cd5","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    grep -q -- \u0027neutron-ovn\u0027 $OVERCLOUD_OVN_DEPLOY_SCRIPT"},{"line_number":64,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":65,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":66,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":67,"context_line":"                    \" ( --answers-file/--environment-directory) \" \\"},{"line_number":68,"context_line":"                    \"\\nYou MUST make sure the proper OVN files are included in the templates called by your deploy script\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9449d7f2_28851123","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":42},"in_reply_to":"e80a4951_649ca4b0","updated":"2021-10-08 05:55:06.000000000","message":"IMO it\u0027s ok - if there is answers file but there is no \u0027neutron-ovn\u0027 in the $OVERCLOUD_OVN_DEPLOY_SCRIPT then we are in this case. And that\u0027s what warning message says - \"You ARE using an answers-file...\" :)","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2b242051952123ff95b4b14eeb9acc9cdbc0de5e","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if [[ $check1 -eq 1 \u0026\u0026 $check2 -eq 1 ]]; then"},{"line_number":83,"context_line":"        # specific case of --answers-file/--environment-directory"},{"line_number":84,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":85,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":86,"context_line":"                 \" ( --answers-file/--environment-directory) \" \\"},{"line_number":87,"context_line":"                 \"\\nYou MUST add ovn-extras.yaml to your new set of templates for OVN-based deploys.\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c921d4b5_d3f56d44","line":84,"range":{"start_line":84,"start_character":39,"end_line":84,"end_character":42},"updated":"2021-10-07 19:42:14.000000000","message":"ditto","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0045a8601681705eb0c70b53c4b1bba0ae0c7cd5","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if [[ $check1 -eq 1 \u0026\u0026 $check2 -eq 1 ]]; then"},{"line_number":83,"context_line":"        # specific case of --answers-file/--environment-directory"},{"line_number":84,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":85,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":86,"context_line":"                 \" ( --answers-file/--environment-directory) \" \\"},{"line_number":87,"context_line":"                 \"\\nYou MUST add ovn-extras.yaml to your new set of templates for OVN-based deploys.\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"45718e49_135dfeaa","line":84,"range":{"start_line":84,"start_character":39,"end_line":84,"end_character":42},"in_reply_to":"c921d4b5_d3f56d44","updated":"2021-10-08 05:55:06.000000000","message":"here the same - it is true if answers file IS used.","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"},{"author":{"_account_id":19743,"name":"VIncent S. Cojot","email":"vincent@cojot.name","username":"ElCoyote"},"change_message_id":"a77ce6c3e30bb4b175340b947ded6bf06f86684b","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if [[ $check1 -eq 1 \u0026\u0026 $check2 -eq 1 ]]; then"},{"line_number":83,"context_line":"        # specific case of --answers-file/--environment-directory"},{"line_number":84,"context_line":"        if [[ $answers_templates_check -eq 0 ]]; then"},{"line_number":85,"context_line":"            echo -e \"\\nWARNING!!! You are using an answers-file or a templates directory\" \\"},{"line_number":86,"context_line":"                 \" ( --answers-file/--environment-directory) \" \\"},{"line_number":87,"context_line":"                 \"\\nYou MUST add ovn-extras.yaml to your new set of templates for OVN-based deploys.\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"17bcaf9a_cc1efa8d","line":84,"range":{"start_line":84,"start_character":39,"end_line":84,"end_character":42},"in_reply_to":"c921d4b5_d3f56d44","updated":"2021-11-22 14:05:42.000000000","message":"same as above, will report about testing later\nWorks as expected with \u0027-eq 0\u0027.","commit_id":"09019f1ffa8590c3d5ab6a9a779d9d11e2ec6e79"}]}