)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58a25be19ed628e7182c6389c9ee4a193de6aeb7","unresolved":true,"context_lines":[{"line_number":15,"context_line":"register to be created is present in the DB and all parameters match,"},{"line_number":16,"context_line":"no transaction is commited to the DB."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/822138"},{"line_number":19,"context_line":"Closes-Bug: #1947334"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib597b62017b56b41009dd4d7359e169f424272b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ccc5041f_c09a8e47","line":18,"updated":"2022-01-26 11:17:07.000000000","message":"this patch is merged and I assume that it\u0027s already in ovsdbapp 1.15 as You bumped minimal required version to that one, right?","commit_id":"e7e7967e39e58586fd1f3720c0b6f693875649a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4051d602971eed60326451b53ca4483b9621c09c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"register to be created is present in the DB and all parameters match,"},{"line_number":16,"context_line":"no transaction is commited to the DB."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/822138"},{"line_number":19,"context_line":"Closes-Bug: #1947334"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib597b62017b56b41009dd4d7359e169f424272b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"36a2c6dd_0ef299e5","line":18,"in_reply_to":"ccc5041f_c09a8e47","updated":"2022-01-27 08:56:12.000000000","message":"Yes, that\u0027s right. This patch is in ovsdbapp 1.15.0","commit_id":"e7e7967e39e58586fd1f3720c0b6f693875649a5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"01bfe2f963f3b2cd2d4a3b3f8bdb4b59dd013663","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5646bfbd_49c3a9cb","updated":"2021-10-28 10:09:26.000000000","message":"recheck","commit_id":"a9612b368b6d3a1cfee5603456cf0e05644244bb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f648f8eef4f50fcad00357cf9027f43e329e9975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7022e76d_813ca785","updated":"2021-11-04 08:12:33.000000000","message":"Hello fellow reviewers. We have tested this patch internally and it is working. The port and the FIP QoS policies are applied in the OVN DB.\n\nThe migration process is not covered in the OpenStack CI yet.","commit_id":"c7c726f323ca5b5a7f16bc453da6976207e2687f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eee952f4ec0b4a8477c02821ea0c48416b11f5da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d70bca5_19a99e0e","updated":"2021-11-19 12:17:58.000000000","message":"recheck","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d2065b680ae3f704f8be403c063926fae8632f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"db518c96_2592c771","updated":"2021-11-11 11:12:01.000000000","message":"recheck","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f102e9a035fcab80f6c008ee8aeb32ee4463bc70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c0be5c96_8ebf904a","updated":"2021-12-21 10:09:15.000000000","message":"Failed functional test seems to be related to this change. Please check it first, before rechecking patch.","commit_id":"b0d2ced7407141d79a3062aa8024fda9b5c7f58b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af094789e57d5ac5fdb7e2a404f612303710237e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"041d4edc_53827f9a","in_reply_to":"c0be5c96_8ebf904a","updated":"2021-12-21 14:42:17.000000000","message":"OK but I didn\u0027t re-check last time, I uploaded PS10 that is a WIP patch.","commit_id":"b0d2ced7407141d79a3062aa8024fda9b5c7f58b"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"24a12ace1277259a7f39d4740ca3f5f932f703c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ecfac04c_36113c56","updated":"2022-02-02 16:56:02.000000000","message":"Looks good to me in general, though I defer to QoS/OVN experts for details!","commit_id":"e7e7967e39e58586fd1f3720c0b6f693875649a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a32694ff3460a61eb97f5df826932fd71fb7d73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"848f401d_be7a0a2b","updated":"2022-02-01 11:28:02.000000000","message":"ping fellow reviewers","commit_id":"e7e7967e39e58586fd1f3720c0b6f693875649a5"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a417496e768dcec365ff4e5a11acf619e1d57a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"74962412_ee6e5d6f","updated":"2022-02-04 21:49:55.000000000","message":"This was a lot of good work. Thanks!","commit_id":"cde5657a504f6658cb1c9c98235c120030f86130"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"66f654dd9e154e9839d930a3a10cffa225c27ecb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a3249a2d_4d7fd2d0","updated":"2022-02-17 10:43:44.000000000","message":"recheck","commit_id":"cde5657a504f6658cb1c9c98235c120030f86130"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76f49cf4da601bbc00626999609f49e770e4b06d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f4652611_971a516c","updated":"2022-02-17 13:48:12.000000000","message":"recheck","commit_id":"cde5657a504f6658cb1c9c98235c120030f86130"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"33b787446625a6cad0c47dff31fe78f50427b6d2","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        # TODO(ralonsoh): we need to benchmark this transaction in systems with"},{"line_number":330,"context_line":"        # a huge amount of ports. This can take a while and could block other"},{"line_number":331,"context_line":"        # operations."},{"line_number":332,"context_line":"        with self._driver._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":333,"context_line":"            for network_id in bound_networks:"},{"line_number":334,"context_line":"                network \u003d {\u0027qos_policy_id\u0027: policy.id, \u0027id\u0027: network_id}"},{"line_number":335,"context_line":"                updated_port_ids.update("}],"source_content_type":"text/x-python","patch_set":5,"id":"20965482_420f3ad6","line":332,"range":{"start_line":332,"start_character":13,"end_line":332,"end_character":33},"updated":"2021-10-26 08:15:25.000000000","message":"self.nb_idl","commit_id":"40f16a27146e9a22dbbe7a886ceb55c7320acd61"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"378426bbc598b8964a48c8e6dd102a40651f93c7","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        # TODO(ralonsoh): we need to benchmark this transaction in systems with"},{"line_number":330,"context_line":"        # a huge amount of ports. This can take a while and could block other"},{"line_number":331,"context_line":"        # operations."},{"line_number":332,"context_line":"        with self._driver._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":333,"context_line":"            for network_id in bound_networks:"},{"line_number":334,"context_line":"                network \u003d {\u0027qos_policy_id\u0027: policy.id, \u0027id\u0027: network_id}"},{"line_number":335,"context_line":"                updated_port_ids.update("}],"source_content_type":"text/x-python","patch_set":5,"id":"f223ba70_b28dddbe","line":332,"range":{"start_line":332,"start_character":13,"end_line":332,"end_character":33},"in_reply_to":"20965482_420f3ad6","updated":"2021-10-26 13:53:34.000000000","message":"Done","commit_id":"40f16a27146e9a22dbbe7a886ceb55c7320acd61"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":27369,"name":"Wang Weijia","email":"330636097@qq.com","username":"Ben"},"change_message_id":"75cf2aa758ffa74da3f1a5938ce11edbb46c1471","unresolved":true,"context_lines":[{"line_number":1244,"context_line":"            for port in self.core_plugin.get_ports(ctx):"},{"line_number":1245,"context_line":"                if not ovn_qos_ext.port_effective_qos_policy_id(port)[0]:"},{"line_number":1246,"context_line":"                    continue"},{"line_number":1247,"context_line":"                ovn_qos_ext.create_port(txn, port)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        LOG.debug(\u0027Port QoS policies migration task finished\u0027)"},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6a54835c_e162a236","line":1247,"updated":"2021-12-10 08:55:14.000000000","message":"OvnNbSynchronizer.do_sync() will process everytime when neutron-server restart.\nSo, it will be better to compare DB of qos in Neutron and OVN first.\nIf port qos has been set in ovn correctly, we do not need to set it again.","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6d6e44b5c3d2e4690c286305f08c9cd4c6849eb","unresolved":true,"context_lines":[{"line_number":1244,"context_line":"            for port in self.core_plugin.get_ports(ctx):"},{"line_number":1245,"context_line":"                if not ovn_qos_ext.port_effective_qos_policy_id(port)[0]:"},{"line_number":1246,"context_line":"                    continue"},{"line_number":1247,"context_line":"                ovn_qos_ext.create_port(txn, port)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        LOG.debug(\u0027Port QoS policies migration task finished\u0027)"},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ba61b56_df7a00db","line":1247,"in_reply_to":"6a54835c_e162a236","updated":"2021-12-16 17:25:32.000000000","message":"You are right. To force the OVN QoS port reset in every restart is excessive. I\u0027ll implement something like a port refresh: only if the QOS OVN DB differs from the Neutron QOS DB, I\u0027ll reset the port.","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"99f0fa8ef83cf578df2f0c706b76ca099376077e","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"            for port in self.core_plugin.get_ports(ctx):"},{"line_number":1245,"context_line":"                if not ovn_qos_ext.port_effective_qos_policy_id(port)[0]:"},{"line_number":1246,"context_line":"                    continue"},{"line_number":1247,"context_line":"                ovn_qos_ext.create_port(txn, port)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        LOG.debug(\u0027Port QoS policies migration task finished\u0027)"},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"03cd57bc_375563e1","line":1247,"in_reply_to":"7ba61b56_df7a00db","updated":"2022-01-21 10:50:15.000000000","message":"Done","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":27369,"name":"Wang Weijia","email":"330636097@qq.com","username":"Ben"},"change_message_id":"75cf2aa758ffa74da3f1a5938ce11edbb46c1471","unresolved":true,"context_lines":[{"line_number":1257,"context_line":"            for fip in self.l3_plugin.get_floatingips(ctx):"},{"line_number":1258,"context_line":"                if not fip.get(\u0027qos_policy_id\u0027):"},{"line_number":1259,"context_line":"                    continue"},{"line_number":1260,"context_line":"                ovn_qos_ext.create_floatingip(txn, fip)"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        LOG.debug(\u0027Floating IP QoS policies migration task finished\u0027)"},{"line_number":1263,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"4e36b840_787c04bc","line":1260,"updated":"2021-12-10 08:55:14.000000000","message":"Same as above","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"050a1521c27f757d761fe5946dce22c79ef5c8fa","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"            for fip in self.l3_plugin.get_floatingips(ctx):"},{"line_number":1258,"context_line":"                if not fip.get(\u0027qos_policy_id\u0027):"},{"line_number":1259,"context_line":"                    continue"},{"line_number":1260,"context_line":"                ovn_qos_ext.create_floatingip(txn, fip)"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"        LOG.debug(\u0027Floating IP QoS policies migration task finished\u0027)"},{"line_number":1263,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"982626a3_f2dfbedb","line":1260,"in_reply_to":"4e36b840_787c04bc","updated":"2022-01-21 10:50:38.000000000","message":"Done","commit_id":"665d9401459e297f8823f9ead5d6328c61a00a33"}]}