)]}'
{"tools/ovn_migration/tripleo_environment/playbooks/roles/migration/tasks/cleanup-dataplane.yml":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"92286a71c3b098e7ce4b4f9ce80817e5003459f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    for p in `ovs-vsctl show | egrep \u0027qr-|ha-|qg-|rfp-\u0027 | grep Interface | awk \u0027{print $2}\u0027`"},{"line_number":5,"context_line":"    do"},{"line_number":6,"context_line":"      # p will be having quotes. Eg. \"hr-xxxx\". So strip the quotes"},{"line_number":7,"context_line":"      p\u003d`echo $p | sed -e \u0027s/\"//g\u0027`"},{"line_number":8,"context_line":"      ovs-vsctl del-port $p"},{"line_number":9,"context_line":"    done"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":12,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d96c61d8_2321eab2","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":8},"updated":"2021-10-08 15:20:12.000000000","message":"Aha, now I know where the construct at https://review.opendev.org/c/openstack/neutron/+/813187/1/tools/ovn_migration/tripleo_environment/playbooks/roles/migration/tasks/cleanup-dataplane.yml is coming from 😊\n\nSince we\u0027re already touching this area of the code, maybe we can improve it similarly? I have no strong opinion - just thought we can do things simpler :)","commit_id":"a64103d68c9eea144752d205463ca997318d28f1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"09c511d60dac908082bf4bf434eedf2415dd0f62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    for p in `ovs-vsctl show | egrep \u0027qr-|ha-|qg-|rfp-\u0027 | grep Interface | awk \u0027{print $2}\u0027`"},{"line_number":5,"context_line":"    do"},{"line_number":6,"context_line":"      # p will be having quotes. Eg. \"hr-xxxx\". So strip the quotes"},{"line_number":7,"context_line":"      p\u003d`echo $p | sed -e \u0027s/\"//g\u0027`"},{"line_number":8,"context_line":"      ovs-vsctl del-port $p"},{"line_number":9,"context_line":"    done"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":12,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0e2b080c_ee9f93a1","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"d96c61d8_2321eab2","updated":"2021-10-08 17:34:53.000000000","message":"Done","commit_id":"a64103d68c9eea144752d205463ca997318d28f1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eaf61e77f538f86d0be88c9bb48647c2bc90be26","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"},{"line_number":8,"context_line":"    for netns in `ip netns  | awk \u0027{ print $1 }\u0027 | grep qdhcp-`; do"},{"line_number":9,"context_line":"      for dhcp_port in `ip netns exec $netns ip -o link show | awk -F\u0027: \u0027 \u0027{print $2}\u0027 | grep tap`; do"},{"line_number":10,"context_line":"        ovs-vsctl del-port $dhcp_port"},{"line_number":11,"context_line":"      done"},{"line_number":12,"context_line":"    done"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6eefd269_308c6321","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":37},"updated":"2021-10-18 10:43:33.000000000","message":"We delete the namespace. Any device created inside should be deleted but not the OVS ports, these should be deleted manually.\n\n+1","commit_id":"5092f3fb98b4c6bf8334de0e71548ddd073f6234"}]}