)]}'
{"neutron/db/migration/alembic_migrations/env.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0f401f9ded1c619af144470b2433e653446ace38","unresolved":false,"context_lines":[{"line_number":78,"context_line":"@event.listens_for(sa.Table, \u0027before_parent_attach\u0027)"},{"line_number":79,"context_line":"def set_storage_engine(target, parent):"},{"line_number":80,"context_line":"    if MYSQL_ENGINE:"},{"line_number":81,"context_line":"        target.kwargs[\u0027mysql_engine\u0027] \u003d MYSQL_ENGINE"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_2f47ddbd","line":81,"updated":"2014-07-23 08:08:08.000000000","message":"This is good change, but incorrect. All test failed, seems that this change was not tested. Should be target.mysql_engine, not target.kwargs[\u0027mysql_engine\u0027].","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9f97c439f079ee93b30b5161559773ca2ff71ee9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"@event.listens_for(sa.Table, \u0027before_parent_attach\u0027)"},{"line_number":79,"context_line":"def set_storage_engine(target, parent):"},{"line_number":80,"context_line":"    if MYSQL_ENGINE:"},{"line_number":81,"context_line":"        target.kwargs[\u0027mysql_engine\u0027] \u003d MYSQL_ENGINE"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a0ea170c","line":81,"in_reply_to":"baada198_2f47ddbd","updated":"2014-07-23 09:55:28.000000000","message":"Hmmm, it requires sqlalchemy \u003e\u003d 0.9.2","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6cb9e77523cfd39a36c6e2d36ebe2fc86fcdf982","unresolved":false,"context_lines":[{"line_number":78,"context_line":"@event.listens_for(sa.Table, \u0027before_parent_attach\u0027)"},{"line_number":79,"context_line":"def set_storage_engine(target, parent):"},{"line_number":80,"context_line":"    if MYSQL_ENGINE:"},{"line_number":81,"context_line":"        target.kwargs[\u0027mysql_engine\u0027] \u003d MYSQL_ENGINE"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_40f05b91","line":81,"in_reply_to":"baada198_a0ea170c","updated":"2014-07-23 10:28:51.000000000","message":"We have sqlalchemy \u003e\u003d 0.8.4","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0f401f9ded1c619af144470b2433e653446ace38","unresolved":false,"context_lines":[{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"},{"line_number":85,"context_line":"    for table in connection.engine.table_names():"},{"line_number":86,"context_line":"        connection.execute(\"ALTER TABLE %s ENGINE \u003d %s\" %"},{"line_number":87,"context_line":"                           (table, mysql_engine))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def run_migrations_online():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_0fc77966","line":87,"updated":"2014-07-23 08:08:08.000000000","message":"I don\u0027t like the idea that \u0027alter table\u0027 is going to be done for all tables, whether it is needed or not, because it will take a lot of time.","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6cb9e77523cfd39a36c6e2d36ebe2fc86fcdf982","unresolved":false,"context_lines":[{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"},{"line_number":85,"context_line":"    for table in connection.engine.table_names():"},{"line_number":86,"context_line":"        connection.execute(\"ALTER TABLE %s ENGINE \u003d %s\" %"},{"line_number":87,"context_line":"                           (table, mysql_engine))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def run_migrations_online():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9be74446","line":87,"in_reply_to":"baada198_00dbc37d","updated":"2014-07-23 10:28:51.000000000","message":"I suggest to leave this change to heal script that will check and fix where it is needed or to create some functions that will check this.","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9f97c439f079ee93b30b5161559773ca2ff71ee9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"def change_storage_engine(connection, mysql_engine):"},{"line_number":85,"context_line":"    for table in connection.engine.table_names():"},{"line_number":86,"context_line":"        connection.execute(\"ALTER TABLE %s ENGINE \u003d %s\" %"},{"line_number":87,"context_line":"                           (table, mysql_engine))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def run_migrations_online():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_00dbc37d","line":87,"in_reply_to":"baada198_0fc77966","updated":"2014-07-23 09:55:28.000000000","message":"I wanted to make conditional to do it only for tables that have storage engine different from mysql_engine but I didn\u0027t find a way how to do that.","commit_id":"9691c5de34cb64759cb0895e2d9ea99bde07c4cd"}],"neutron/db/migration/cli.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"563a7257e92735f7bef1e6c2b6654166aae89e03","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument(\u0027--delta\u0027, type\u003dint)"},{"line_number":136,"context_line":"        parser.add_argument(\u0027--sql\u0027, action\u003d\u0027store_true\u0027)"},{"line_number":137,"context_line":"        parser.add_argument(\u0027revision\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":138,"context_line":"        parser.add_argument(\u0027--mysql-engine\u0027,"},{"line_number":139,"context_line":"                            default\u003d\u0027\u0027,"},{"line_number":140,"context_line":"                            help\u003d\u0027Change MySQL storage engine of current \u0027"},{"line_number":141,"context_line":"                                 \u0027existing tables\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_fce9fa19","line":138,"updated":"2014-07-31 10:54:36.000000000","message":"why do we need this at all?\nAFAIK, mysql has only 2 engines, where only InnoDB is recommended. Why not just explicitly use this engine everywhere?","commit_id":"5d34d398f002b9a4dbd0c5cae7c17b8468b55906"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"970ad7dc4081e141067b3bbbccbc6d1ae7b4f080","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument(\u0027--delta\u0027, type\u003dint)"},{"line_number":136,"context_line":"        parser.add_argument(\u0027--sql\u0027, action\u003d\u0027store_true\u0027)"},{"line_number":137,"context_line":"        parser.add_argument(\u0027revision\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":138,"context_line":"        parser.add_argument(\u0027--mysql-engine\u0027,"},{"line_number":139,"context_line":"                            default\u003d\u0027\u0027,"},{"line_number":140,"context_line":"                            help\u003d\u0027Change MySQL storage engine of current \u0027"},{"line_number":141,"context_line":"                                 \u0027existing tables\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b2eec9eb","line":138,"in_reply_to":"baada198_fce9fa19","updated":"2014-07-31 11:52:59.000000000","message":"I agree that InnoDB is recommended but there are more engines, not just two. Hardcoding configurable doesn\u0027t sound like a smart thing to do.","commit_id":"5d34d398f002b9a4dbd0c5cae7c17b8468b55906"}]}
