)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6c2539c_6b23793d","updated":"2021-10-25 14:10:11.000000000","message":"I have a couple of nits inline but overall looks good","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88d8c4a5_3b62bbb0","updated":"2021-10-27 09:58:29.000000000","message":"-1 for the comments.\n\nBut thanks a lot for this kind of documentation, always welcome!","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ddb0d2e9c1af9b6a5710a2833cf4d9aca37d315f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c94a9798_1e40265f","updated":"2021-11-09 08:08:19.000000000","message":"Looks good to me","commit_id":"77b3a1a7749341ff4cd8b809edf84459f95fe276"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dfc5cd4655b283c37b2bd7b2b3805fddd86b8b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a07d21a4_90480b3e","updated":"2021-11-17 14:02:47.000000000","message":"Thanks","commit_id":"77b3a1a7749341ff4cd8b809edf84459f95fe276"}],"doc/source/admin/config-qos-min-pps.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    At the time of writing this guide, only placement enforcement is supported."},{"line_number":30,"context_line":"    For detailed list of supported enforcement types and backends, please refer"},{"line_number":31,"context_line":"    to :doc:`QoS configuration chapter of the Networking Guide \u003cconfig-qos\u003e`."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The solution needs to differentiate between two different deployment scenarios:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fc17ea6d_23375a42","line":30,"updated":"2021-10-25 14:10:11.000000000","message":"Do you have a follow up patch that updates the \u0027QoS configuration chapter of the Networking Guide\u0027 to show that minimum packet rate data plane enforcement is not supported in any backend at the momement?","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    At the time of writing this guide, only placement enforcement is supported."},{"line_number":30,"context_line":"    For detailed list of supported enforcement types and backends, please refer"},{"line_number":31,"context_line":"    to :doc:`QoS configuration chapter of the Networking Guide \u003cconfig-qos\u003e`."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The solution needs to differentiate between two different deployment scenarios:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ff1ed5a_9aca3420","line":30,"in_reply_to":"fc17ea6d_23375a42","updated":"2021-10-27 08:28:20.000000000","message":"It was included with API extension patch: https://review.opendev.org/c/openstack/neutron/+/803045/15/doc/source/admin/config-qos.rst\n\nAdditionally, this patch is still waiting to be merged: https://review.opendev.org/c/openstack/neutron/+/805391/13/doc/source/admin/config-qos.rst","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Nova pre-requisites"},{"line_number":98,"context_line":"-------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Nova must support `microversion 2.72"},{"line_number":101,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_."},{"line_number":102,"context_line":"This was first released in Stein."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Not all Nova virt drivers are supported, please refer to the"},{"line_number":105,"context_line":"`Virt Driver Support section of the Nova Admin Guide"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ddf9c51_7a87e363","line":102,"range":{"start_line":100,"start_character":0,"end_line":102,"end_character":33},"updated":"2021-10-25 14:10:11.000000000","message":"This is a bit misleading, sure we need 2.72 as microversion. But nova Stein alone is not enough from nova. I suggest to add an extra sentence:\n\n\"Top of microversion 2.72 also the Nova Xena release is needed to support the new ``port-resource-request-groups`` Neutron API extension.\"","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Nova pre-requisites"},{"line_number":98,"context_line":"-------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Nova must support `microversion 2.72"},{"line_number":101,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_."},{"line_number":102,"context_line":"This was first released in Stein."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Not all Nova virt drivers are supported, please refer to the"},{"line_number":105,"context_line":"`Virt Driver Support section of the Nova Admin Guide"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e88b0810_25ba9e76","line":102,"range":{"start_line":100,"start_character":0,"end_line":102,"end_character":33},"in_reply_to":"5ddf9c51_7a87e363","updated":"2021-10-27 08:28:20.000000000","message":"Done","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":129,"context_line":"    $ neutron-status upgrade check"},{"line_number":130,"context_line":"    # If ``Port Binding profile sanity check`` fails, DB sanitization is needed"},{"line_number":131,"context_line":"    $ neutron-sanitize-port-binding-profile-allocation --config-file /etc/neutron/neutron.conf"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Supported drivers and agents"},{"line_number":134,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"35b4dcf0_515e4566","line":132,"updated":"2021-10-25 14:10:11.000000000","message":"As in Yoga the new neutron API extension is enabled automatically this DB data migration needs to be run _before_ upgrading neutron to Yoga. I suggest to mention this.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    $ neutron-status upgrade check"},{"line_number":130,"context_line":"    # If ``Port Binding profile sanity check`` fails, DB sanitization is needed"},{"line_number":131,"context_line":"    $ neutron-sanitize-port-binding-profile-allocation --config-file /etc/neutron/neutron.conf"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Supported drivers and agents"},{"line_number":134,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"84b425df_b179eac5","line":132,"in_reply_to":"35b4dcf0_515e4566","updated":"2021-10-27 08:28:20.000000000","message":"Done","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":136,"context_line":"In release Yoga the following agent-based ML2 mechanism drivers are"},{"line_number":137,"context_line":"supported:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"neutron-server config"},{"line_number":142,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b07efca7_fb162529","line":139,"updated":"2021-10-25 14:10:11.000000000","message":"do we hardcoded somewhere that only normal is supported? I think the ml2/ovs supports direct as well (for the hw offloaded case) and I guess we transparently supports that too.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":136,"context_line":"In release Yoga the following agent-based ML2 mechanism drivers are"},{"line_number":137,"context_line":"supported:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"neutron-server config"},{"line_number":142,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0fc8f603_5e13db0b","line":139,"in_reply_to":"b07efca7_fb162529","updated":"2021-10-27 08:28:20.000000000","message":"It\u0027s not hardcoded. We\u0027re reporting all VNIC traits on agent RP that agent was configured to support, so in case of HW offloaded OVS direct is also supported.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    #resource_provider_packet_processing_inventory_defaults \u003d step_size:1000,..."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Propagation of resource information"},{"line_number":217,"context_line":"-----------------------------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The flow of information is different for available and used resources."}],"source_content_type":"text/x-rst","patch_set":1,"id":"22ce64a3_fbfd85ff","line":216,"updated":"2021-10-25 14:10:11.000000000","message":"This is mostly a copy-paste from the min bw doc. I think it is OK to simply refer to that doc instead of duplicating it.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    #resource_provider_packet_processing_inventory_defaults \u003d step_size:1000,..."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Propagation of resource information"},{"line_number":217,"context_line":"-----------------------------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The flow of information is different for available and used resources."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7afc3967_ac96e15a","line":216,"in_reply_to":"22ce64a3_fbfd85ff","updated":"2021-10-27 08:28:20.000000000","message":"I agree. The flow of information is pretty much the same for both features. Done.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":390,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* Moving the server, which will delete the wrong allocation and create the"},{"line_number":393,"context_line":"  correct allocation as soon as move operations are implemented (not in Stein"},{"line_number":394,"context_line":"  unfortunately). Moving servers fixes local overallocations."},{"line_number":395,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":396,"context_line":"  `bug 1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":397,"context_line":"* Manually, by using `openstack resource provider allocation set"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ed355a0d_8d8e4a65","line":394,"range":{"start_line":393,"start_character":20,"end_line":394,"end_character":17},"updated":"2021-10-25 14:10:11.000000000","message":"you can drop this","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":390,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* Moving the server, which will delete the wrong allocation and create the"},{"line_number":393,"context_line":"  correct allocation as soon as move operations are implemented (not in Stein"},{"line_number":394,"context_line":"  unfortunately). Moving servers fixes local overallocations."},{"line_number":395,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":396,"context_line":"  `bug 1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":397,"context_line":"* Manually, by using `openstack resource provider allocation set"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fdeaaae1_86075b2c","line":394,"range":{"start_line":393,"start_character":20,"end_line":394,"end_character":17},"in_reply_to":"ed355a0d_8d8e4a65","updated":"2021-10-27 08:28:20.000000000","message":"Done","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f0e975a97f62035cb525aecfad03ebcd2911351","unresolved":true,"context_lines":[{"line_number":392,"context_line":"* Moving the server, which will delete the wrong allocation and create the"},{"line_number":393,"context_line":"  correct allocation as soon as move operations are implemented (not in Stein"},{"line_number":394,"context_line":"  unfortunately). Moving servers fixes local overallocations."},{"line_number":395,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":396,"context_line":"  `bug 1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":397,"context_line":"* Manually, by using `openstack resource provider allocation set"},{"line_number":398,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":399,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c3a50f26_890241d6","line":396,"range":{"start_line":395,"start_character":2,"end_line":396,"end_character":64},"updated":"2021-10-25 14:10:11.000000000","message":"replace this with a reference to https://docs.openstack.org/nova/latest/cli/nova-manage.html#placement-heal-allocations as the tool is available. I will make sure that the min_pps support patches for it also merges in Yoga.","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"748111650c7a61a0b29d47cb7623e7b897775984","unresolved":false,"context_lines":[{"line_number":392,"context_line":"* Moving the server, which will delete the wrong allocation and create the"},{"line_number":393,"context_line":"  correct allocation as soon as move operations are implemented (not in Stein"},{"line_number":394,"context_line":"  unfortunately). Moving servers fixes local overallocations."},{"line_number":395,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":396,"context_line":"  `bug 1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":397,"context_line":"* Manually, by using `openstack resource provider allocation set"},{"line_number":398,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":399,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"33839813_92185f28","line":396,"range":{"start_line":395,"start_character":2,"end_line":396,"end_character":64},"in_reply_to":"c3a50f26_890241d6","updated":"2021-10-27 08:28:20.000000000","message":"Done","commit_id":"7121de97ed342e51965304e2f4bee4d8d648c6e3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":63,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a"},{"line_number":64,"context_line":"  ``minimum_packet_rate`` rule, or changing the ``min_kpps`` field of a"},{"line_number":65,"context_line":"  ``minimum_packet_rate`` rule) is only possible while the policy is not in"},{"line_number":66,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":67,"context_line":"  to change guarantees of in-use policies are rejected."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Changing the QoS policy of the port with new ``minimum_packet_rate`` rules"}],"source_content_type":"text/x-rst","patch_set":2,"id":"aea11b38_d70b90d1","line":66,"range":{"start_line":66,"start_character":54,"end_line":66,"end_character":66},"updated":"2021-10-27 09:58:29.000000000","message":"are not yet bound","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a"},{"line_number":64,"context_line":"  ``minimum_packet_rate`` rule, or changing the ``min_kpps`` field of a"},{"line_number":65,"context_line":"  ``minimum_packet_rate`` rule) is only possible while the policy is not in"},{"line_number":66,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":67,"context_line":"  to change guarantees of in-use policies are rejected."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Changing the QoS policy of the port with new ``minimum_packet_rate`` rules"}],"source_content_type":"text/x-rst","patch_set":2,"id":"736c625b_925fff62","line":66,"range":{"start_line":66,"start_character":54,"end_line":66,"end_character":66},"in_reply_to":"aea11b38_d70b90d1","updated":"2021-10-29 12:45:55.000000000","message":"Done","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  changes placement ``allocations`` from Yoga release."},{"line_number":71,"context_line":"  If the VM was booted with port without QoS policy and ``minimum_packet_rate``"},{"line_number":72,"context_line":"  rules the port update succeeds but placement allocations will not change."},{"line_number":73,"context_line":"  The same is true if the port has no ``binding:profile``, thus no placement"},{"line_number":74,"context_line":"  allocation record exists for it. But if the VM was booted with a port with"},{"line_number":75,"context_line":"  QoS policy and ``minimum_packet_rate`` rules the update is possible and the"},{"line_number":76,"context_line":"  allocations are changed in placement as well."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f2abc815_56cbc757","line":74,"range":{"start_line":73,"start_character":2,"end_line":74,"end_character":33},"updated":"2021-10-27 09:58:29.000000000","message":"A port has always a \"binding:profile\" record. I think what you want to say here is that we can bind a port without calling placement and without creating a placement allocation record (or placement didn\u0027t reply). Is that what you mean?","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  changes placement ``allocations`` from Yoga release."},{"line_number":71,"context_line":"  If the VM was booted with port without QoS policy and ``minimum_packet_rate``"},{"line_number":72,"context_line":"  rules the port update succeeds but placement allocations will not change."},{"line_number":73,"context_line":"  The same is true if the port has no ``binding:profile``, thus no placement"},{"line_number":74,"context_line":"  allocation record exists for it. But if the VM was booted with a port with"},{"line_number":75,"context_line":"  QoS policy and ``minimum_packet_rate`` rules the update is possible and the"},{"line_number":76,"context_line":"  allocations are changed in placement as well."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa4039b_74e4fc0d","line":74,"range":{"start_line":73,"start_character":2,"end_line":74,"end_character":33},"in_reply_to":"f2abc815_56cbc757","updated":"2021-10-29 12:45:55.000000000","message":"It means that original QoS policy needs to have allocation record in Placement (and RP UUID in binding:profile attribute).\n\nPlease refer to [1] for a detailed support matrix.\n\nWhat do you think about: \"The same is true if the port had no allocation record in Placement before QoS policy update.\"?\n\n[1] https://review.opendev.org/c/openstack/neutron-specs/+/809202/4/specs/yoga/qos-minimum-guaranteed-packet-rate.rst#595","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  As it is possible to update a port to remove the QoS policy, updating it"},{"line_number":81,"context_line":"  back to have QoS policy with ``minimum_packet_rate`` rule will not result in"},{"line_number":82,"context_line":"  ``placement allocation`` record. If the rule being added supports dataplane"},{"line_number":83,"context_line":"  enforcement, it will be executed."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. note::"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"499b3aa2_2a19ef74","line":83,"range":{"start_line":82,"start_character":35,"end_line":83,"end_character":35},"updated":"2021-10-27 09:58:29.000000000","message":"What will be executed? Sorry, I don\u0027t understand this.\n\nIf we create a port with qos, then we update the port removing qos, the placement record will be removed. Then, as when initially a port is bind without qos rules (L71-72), it won\u0027t matter if we add a new qos rule; no placement record will be created. Right?","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  As it is possible to update a port to remove the QoS policy, updating it"},{"line_number":81,"context_line":"  back to have QoS policy with ``minimum_packet_rate`` rule will not result in"},{"line_number":82,"context_line":"  ``placement allocation`` record. If the rule being added supports dataplane"},{"line_number":83,"context_line":"  enforcement, it will be executed."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. note::"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"01e8458e_e8d2f868","line":83,"range":{"start_line":82,"start_character":35,"end_line":83,"end_character":35},"in_reply_to":"499b3aa2_2a19ef74","updated":"2021-10-29 12:45:55.000000000","message":"Rephrased.\n\nGibi prepared support matrix: https://review.opendev.org/c/openstack/neutron-specs/+/809202/4/specs/yoga/qos-minimum-guaranteed-packet-rate.rst#595\n\nPerhaps we should add it to Netowrking guide as well.","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Neutron must support the following API extensions:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* ``qos-pps-minimum``"},{"line_number":121,"context_line":"* ``port-resource-request-groups``"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"These were all first released in Yoga."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b40389f1_1d10ff18","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":1},"updated":"2021-10-27 09:58:29.000000000","message":"Is this one strictly needed?","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Neutron must support the following API extensions:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* ``qos-pps-minimum``"},{"line_number":121,"context_line":"* ``port-resource-request-groups``"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"These were all first released in Yoga."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5d732095_810536cf","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":1},"in_reply_to":"b40389f1_1d10ff18","updated":"2021-10-29 12:45:55.000000000","message":"Yes - min PPS is build on top of port-resource-request-groups and it\u0027s enabled by default.","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"These were all first released in Yoga."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"ml2_port_bindings DB table sanitization"},{"line_number":126,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"With the introduction of ``port-resource-request-groups`` extension in Neutron"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1c877677_957a9f2d","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":39},"updated":"2021-10-27 09:58:29.000000000","message":"I know this is related to the feature you implemented. Now we have more than placement resource to request, the new format is needed.\n\nBut I think you need to introduce this properly, explaining (in a better way) why this extension is needed, talking about min-bw (the first extension using placement) and the new format.","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"These were all first released in Yoga."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"ml2_port_bindings DB table sanitization"},{"line_number":126,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"With the introduction of ``port-resource-request-groups`` extension in Neutron"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7802b2ac_8455d529","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":39},"in_reply_to":"1c877677_957a9f2d","updated":"2021-10-29 12:45:55.000000000","message":"Added more details. Let me know what you think.","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":156,"context_line":"Since neutron-server talks to Placement you need to configure how"},{"line_number":157,"context_line":"neutron-server should find Placement and authenticate to it."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"``/etc/neutron/neutron.conf`` (on controller nodes):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. code-block:: ini"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3803e992_b11de849","line":159,"range":{"start_line":159,"start_character":2,"end_line":159,"end_character":52},"updated":"2021-10-27 09:58:29.000000000","message":"It is worth mentioning that when \"placement\" service plugin is enabled in Neutron, devstack will configure this section. See neutron/devstack/lib/placement","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Since neutron-server talks to Placement you need to configure how"},{"line_number":157,"context_line":"neutron-server should find Placement and authenticate to it."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"``/etc/neutron/neutron.conf`` (on controller nodes):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. code-block:: ini"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5eb7ac74_da48aeff","line":159,"range":{"start_line":159,"start_character":2,"end_line":159,"end_character":52},"in_reply_to":"3803e992_b11de849","updated":"2021-10-29 12:45:55.000000000","message":"I replaced this section with a reference to min-bw guide. Such note can be added to min-bw guide in subsequent patch.","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e277056426ee189124ebdbff9f5c1f5f3c0bea23","unresolved":true,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. note::"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ``egress`` / ``ingress`` is meant from the perspective of a cloud server."},{"line_number":198,"context_line":"    That is ``egress`` \u003d cloud server upload, ``ingress`` \u003d download."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    Egress and ingress available packet rate values are in ``kilo packet/sec"}],"source_content_type":"text/x-rst","patch_set":2,"id":"331c0ad5_7582981e","line":197,"range":{"start_line":197,"start_character":38,"end_line":197,"end_character":76},"updated":"2021-10-27 09:58:29.000000000","message":"from the VM point of view","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"f65195789c177822b07255b2b644d3279c4506ea","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. note::"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ``egress`` / ``ingress`` is meant from the perspective of a cloud server."},{"line_number":198,"context_line":"    That is ``egress`` \u003d cloud server upload, ``ingress`` \u003d download."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    Egress and ingress available packet rate values are in ``kilo packet/sec"}],"source_content_type":"text/x-rst","patch_set":2,"id":"030762c7_5d7e6a22","line":197,"range":{"start_line":197,"start_character":38,"end_line":197,"end_character":76},"in_reply_to":"331c0ad5_7582981e","updated":"2021-10-29 12:45:55.000000000","message":"Done","commit_id":"292557bbf5d842c9a87ce16a7fee1f58d31edcd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dfc5cd4655b283c37b2bd7b2b3805fddd86b8b18","unresolved":true,"context_lines":[{"line_number":357,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":358,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"Debugging"},{"line_number":361,"context_line":"---------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"* Is Nova running at least Xena release and Neutron at least the Yoga release?"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"73241943_45a571be","line":361,"range":{"start_line":360,"start_character":0,"end_line":361,"end_character":9},"updated":"2021-11-17 14:02:47.000000000","message":"+1","commit_id":"77b3a1a7749341ff4cd8b809edf84459f95fe276"}]}