)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3eb13777d63ddf9090648b9a0038825fcb5c2cd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98b0d237_493c34a3","updated":"2021-10-26 09:10:43.000000000","message":"good catch","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"0633f444ed14261991e4532680981ef65b5ce5cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f09b609_96ffabed","updated":"2021-10-27 09:10:20.000000000","message":"recheck","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"caf53eaaff2a95030d89ffefa4a73665243a341b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a9051a0_30ac0002","updated":"2021-11-02 07:14:28.000000000","message":"recheck","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"6c87481b8e98b7f2b59dab4c55e27cc3e50f0227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6aa890ed_bf4ddf85","updated":"2021-10-27 12:20:47.000000000","message":"recheck","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"c6afde177961f79f0eb407b1dc63e87dfe1ae37d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e7e02aa_df626787","updated":"2021-10-26 13:35:37.000000000","message":"recheck","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"e0e9a54ba8267ebb02a58615cf79b789e982cf02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5ce6940_ef8e8b98","updated":"2021-10-29 13:07:54.000000000","message":"recheck","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d71b9feff63a233c8d23584af1f01c0f491d7e1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"461e2a4a_8ca445dc","updated":"2022-01-10 16:17:42.000000000","message":"It was just a hard rebase....","commit_id":"18ec0eb20921e41ba4cade555f9da823c9dbfa13"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c98e6e99eeca6527887dd3ad0f694389d647907d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eab9cb40_0232f9c2","updated":"2022-01-11 12:16:15.000000000","message":"recheck\ntest_revert_cold_migration failed with status remained in REVERT_RESIZE","commit_id":"18ec0eb20921e41ba4cade555f9da823c9dbfa13"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4bc27d674efc6467ef40c703278eb67b0775504b","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3c2ef3b_a2275db1","line":397,"range":{"start_line":397,"start_character":49,"end_line":397,"end_character":52},"updated":"2021-11-04 10:22:26.000000000","message":"Do we need both QOS_POLICY_ID and QOS_NETWORK_POLICY_ID?","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"456f8fa91c5ab6fa55abbc02953a4bce7a4ba5e4","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"}],"source_content_type":"text/x-python","patch_set":1,"id":"2640a5c4_135dfb03","line":397,"range":{"start_line":397,"start_character":49,"end_line":397,"end_character":52},"in_reply_to":"f3c2ef3b_a2275db1","updated":"2021-11-15 14:17:00.000000000","message":"See below","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3eb13777d63ddf9090648b9a0038825fcb5c2cd4","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":401,"context_line":"            port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"89356b3a_fd6c38f2","line":399,"range":{"start_line":397,"start_character":8,"end_line":399,"end_character":18},"updated":"2021-10-26 09:10:43.000000000","message":"Why this check? This is the original port that comes from a DB query. If qos is enabled, the port will always have those keys.","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"c6afde177961f79f0eb407b1dc63e87dfe1ae37d","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":401,"context_line":"            port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"92e165e8_7c8825b9","line":399,"range":{"start_line":397,"start_character":8,"end_line":399,"end_character":18},"in_reply_to":"89356b3a_fd6c38f2","updated":"2021-10-26 13:35:37.000000000","message":"My first impression was that this check is redundant and can be removed, but I found it was added to fix a bug [1]. So I extended it for network QoS policy ID as well.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1898994","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4bc27d674efc6467ef40c703278eb67b0775504b","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":401,"context_line":"            port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dff19873_7221d3c4","line":399,"range":{"start_line":397,"start_character":8,"end_line":399,"end_character":18},"in_reply_to":"92e165e8_7c8825b9","updated":"2021-11-04 10:22:26.000000000","message":"As I remember it happened that the before_update event arrived without fully filled port dict. not sure if this is still true after the payload change (as all the related code was refactored)","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"456f8fa91c5ab6fa55abbc02953a4bce7a4ba5e4","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        port \u003d payload.latest_state"},{"line_number":395,"context_line":"        original_policy_id \u003d (orig_port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":396,"context_line":"            orig_port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":397,"context_line":"        if (qos_consts.QOS_POLICY_ID not in port and"},{"line_number":398,"context_line":"                qos_consts.QOS_NETWORK_POLICY_ID not in port):"},{"line_number":399,"context_line":"            return"},{"line_number":400,"context_line":"        policy_id \u003d (port.get(qos_consts.QOS_POLICY_ID) or"},{"line_number":401,"context_line":"            port.get(qos_consts.QOS_NETWORK_POLICY_ID))"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"78cbc146_a1169771","line":399,"range":{"start_line":397,"start_character":8,"end_line":399,"end_character":18},"in_reply_to":"dff19873_7221d3c4","updated":"2021-11-15 14:17:00.000000000","message":"I added a log message here and updated QoS policy assigned to a port. This is the output https://paste.openstack.org/show/811002/\nAs you can see, QOS_POLICY_ID or QOS_NETWORK_POLICY_ID might not be present in port. I believe we need to keep this IF condition here.","commit_id":"c353d03f27240538c273c92a68bff3a5a71df391"}]}