)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"65b990ba2d4e24d076ac324ae15a4bff4440b40b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49362edc_f76044c2","updated":"2021-11-04 03:44:36.000000000","message":"Hi Rodolfo, I don\u0027t have experience with unit test. I don\u0027t know why function _make_port don\u0027t create port with port security. Can you have me fix that?","commit_id":"a673b6f6bb2341c8f33307964913745d1fe1ab6a"},{"author":{"_account_id":30636,"name":"Chung Phan","email":"chungphan7819@gmail.com","username":"archiephan"},"change_message_id":"1bb17af7dd0a5cb7f9e552a780eb22ff158afdef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0557f707_b5a2998f","updated":"2021-11-11 10:25:47.000000000","message":"recheck","commit_id":"989204bf743e4f79a4bba729f8586c244be699aa"},{"author":{"_account_id":30636,"name":"Chung Phan","email":"chungphan7819@gmail.com","username":"archiephan"},"change_message_id":"1db7ba3a150e2c7e54f65235efac1c32c40b179d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0da00883_6de667f6","updated":"2021-11-12 02:09:44.000000000","message":"recheck","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"},{"author":{"_account_id":10338,"name":"Daniel Speichert","email":"daniel@speichert.pl","username":"daniel"},"change_message_id":"1dd4e03be7f45936f844585aef7c3542ee9c1fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"38f29575_185f33b7","updated":"2021-11-12 00:32:49.000000000","message":"recheck","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"},{"author":{"_account_id":30636,"name":"Chung Phan","email":"chungphan7819@gmail.com","username":"archiephan"},"change_message_id":"9f095c0b87f1539c407f1be38343e1b4e0c16c4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5e871690_84065bc9","updated":"2021-11-12 03:59:34.000000000","message":"recheck","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ff0c2d57d8a0474813aee1ec653c707c9f4293f","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":488,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":489,"context_line":"            # is dropped by default."},{"line_number":490,"context_line":"            if not utils.is_lsp_trusted(port) or port_info.port_security:"},{"line_number":491,"context_line":"                self._add_port_to_drop_port_group(port_cmd, txn)"},{"line_number":492,"context_line":"            # Just add the port to its Port Group."},{"line_number":493,"context_line":"            for sg in sg_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"393c9e0d_c646b9c1","side":"PARENT","line":490,"range":{"start_line":490,"start_character":46,"end_line":490,"end_character":48},"updated":"2021-11-11 13:05:31.000000000","message":"Why not changing this with \"and\"? That will behave the same as your patch but in just one condition line.","commit_id":"7a32f9c971eef13012510ac524c2d81caac03ba4"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"1193829429b47b57e6ac15b3a3a3e8ac1c6f5bf5","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":488,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":489,"context_line":"            # is dropped by default."},{"line_number":490,"context_line":"            if not utils.is_lsp_trusted(port) or port_info.port_security:"},{"line_number":491,"context_line":"                self._add_port_to_drop_port_group(port_cmd, txn)"},{"line_number":492,"context_line":"            # Just add the port to its Port Group."},{"line_number":493,"context_line":"            for sg in sg_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"d3dcb499_917fbc59","side":"PARENT","line":490,"range":{"start_line":490,"start_character":46,"end_line":490,"end_character":48},"in_reply_to":"393c9e0d_c646b9c1","updated":"2021-11-11 13:36:08.000000000","message":"No, if we change this with \"and\". Only port with device_owner start with \"network\" AND enable port security then added to neutron_pg_drop like router port and dhcp port. The remaining ports are not added","commit_id":"7a32f9c971eef13012510ac524c2d81caac03ba4"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"7949ada2d21323c14e912c35be2539860b7e33c0","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":488,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":489,"context_line":"            # is dropped by default."},{"line_number":490,"context_line":"            if not utils.is_lsp_trusted(port) or port_info.port_security:"},{"line_number":491,"context_line":"                self._add_port_to_drop_port_group(port_cmd, txn)"},{"line_number":492,"context_line":"            # Just add the port to its Port Group."},{"line_number":493,"context_line":"            for sg in sg_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb21d604_afba4d4e","side":"PARENT","line":490,"range":{"start_line":490,"start_character":46,"end_line":490,"end_character":48},"in_reply_to":"d3dcb499_917fbc59","updated":"2021-11-11 13:51:50.000000000","message":"Sorry, i am wrong. We just need change to and. Thank you","commit_id":"7a32f9c971eef13012510ac524c2d81caac03ba4"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"9322fc408ce6496d151b10c041b582ec221e6bf8","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":488,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":489,"context_line":"            # is dropped by default."},{"line_number":490,"context_line":"            if not utils.is_lsp_trusted(port) or port_info.port_security:"},{"line_number":491,"context_line":"                self._add_port_to_drop_port_group(port_cmd, txn)"},{"line_number":492,"context_line":"            # Just add the port to its Port Group."},{"line_number":493,"context_line":"            for sg in sg_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"b163cb12_98b8ccb7","side":"PARENT","line":490,"range":{"start_line":490,"start_character":46,"end_line":490,"end_character":48},"in_reply_to":"eb21d604_afba4d4e","updated":"2021-11-15 08:04:10.000000000","message":"Done","commit_id":"7a32f9c971eef13012510ac524c2d81caac03ba4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52a4a5e1f1780af7e6f1ce661f785ca6490aa90e","unresolved":true,"context_lines":[{"line_number":488,"context_line":"                **kwargs))"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"            sg_ids \u003d utils.get_lsp_security_groups(port)"},{"line_number":491,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":492,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":493,"context_line":"            # is dropped by default."},{"line_number":494,"context_line":"            if not utils.is_lsp_trusted(port) and port_info.port_security:"}],"source_content_type":"text/x-python","patch_set":9,"id":"d9d4473e_34a949bc","line":491,"updated":"2021-11-12 15:53:21.000000000","message":"nit: please also update that comment here 😊","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"9322fc408ce6496d151b10c041b582ec221e6bf8","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                **kwargs))"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"            sg_ids \u003d utils.get_lsp_security_groups(port)"},{"line_number":491,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":492,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":493,"context_line":"            # is dropped by default."},{"line_number":494,"context_line":"            if not utils.is_lsp_trusted(port) and port_info.port_security:"}],"source_content_type":"text/x-python","patch_set":9,"id":"f4054b78_1a185f9b","line":491,"in_reply_to":"9ff0365c_2e06674d","updated":"2021-11-15 08:04:10.000000000","message":"Done","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"cb4aaab4375ff7319d60795a3eff68a7d0d58b7c","unresolved":true,"context_lines":[{"line_number":488,"context_line":"                **kwargs))"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"            sg_ids \u003d utils.get_lsp_security_groups(port)"},{"line_number":491,"context_line":"            # If this is not a trusted port or port security is enabled,"},{"line_number":492,"context_line":"            # add it to the default drop Port Group so that all traffic"},{"line_number":493,"context_line":"            # is dropped by default."},{"line_number":494,"context_line":"            if not utils.is_lsp_trusted(port) and port_info.port_security:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ff0365c_2e06674d","line":491,"in_reply_to":"d9d4473e_34a949bc","updated":"2021-11-12 16:03:07.000000000","message":"thank you for your comment. i am fixed 😊","commit_id":"d13ab07460c2ebe0289c2a26ab8724e958527a10"}]}