)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"27183164c217458977cc046a034b1c295e68d4bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2a24c71_5b3464fa","updated":"2021-11-04 13:50:10.000000000","message":"Agree with kuba\u0027s cmmment ","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e4725b1568d6e7dbc4bf001b99e664b40464e808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b8070d1_f6c43632","updated":"2021-11-04 13:48:05.000000000","message":"Thanks!","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6615cbe7d80e307a47ff48bce27b2854c186d84d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c352204_2a2c70bc","updated":"2021-11-11 07:47:08.000000000","message":"Ops...\n\nExpected: execute(\u0027ovsdb-client\u0027, \u0027transact\u0027, \u0027tcp:127.0.0.1:6642\u0027, \u0027--timeout\u0027, \u002730\u0027, \u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\u0027, log_errors\u003d\u003cLogErrors.FINAL: 2\u003e)\nActual: execute(\u0027ovsdb-client\u0027, \u0027transact\u0027, \u0027tcp:127.0.0.1:6642\u0027, \u0027--timeout\u0027, 30, \u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\u0027, log_errors\u003d\u003cLogErrors.FINAL: 2\u003e)","commit_id":"8fac636ecb7d60234feadb83df2263c4d10033e0"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"8c6e9500793109a81fd894c401db49fbce7308f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"440515d1_db93cd7f","updated":"2021-11-11 11:18:05.000000000","message":"LGTM! I left a question in the code.","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d6e8b857eb078ed2ec0494217035d7bed0306303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4d1d74b_7c566e2a","updated":"2021-11-11 19:56:52.000000000","message":"recheck","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f74dd5f974d85e4cf256a4287237c08d91656809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"adead17d_30ad070a","updated":"2021-11-11 13:44:48.000000000","message":"thanks!","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"b333e65620e09eadb415f0626fc1b70abee752df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa56cec0_dd91ce68","in_reply_to":"440515d1_db93cd7f","updated":"2021-11-11 11:23:28.000000000","message":"I just realized I didn\u0027t send it so I will ask it here :)\n\nIs there any default for the timeout now in the ovn_configuration?","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"72d33b7f9bff92e7b9b2e5b20e1eec1ebd50f51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae1e2f81_f415b8a0","in_reply_to":"81ad5e1e_a1f2cd6d","updated":"2021-11-11 13:59:56.000000000","message":"True that! thanks","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"16abf8b1ec8f5307dc10da752e353ca6ab24011c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"81ad5e1e_a1f2cd6d","in_reply_to":"fa56cec0_dd91ce68","updated":"2021-11-11 13:11:10.000000000","message":"Thanks for the review Elvira. I think that the default is 180 [0] right?\n\n[0] https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py#L73","commit_id":"7874c576013928c036dca4d9c0a38e5b8ae06bb4"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bc03cd82e7214dc349e1df6875a26734d19dfc7e","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_delete_mac_binding_entries(self):"},{"line_number":137,"context_line":"        self.config(group\u003d\u0027ovn\u0027, ovn_sb_private_key\u003dNone)"},{"line_number":138,"context_line":"        expected \u003d (\u0027ovsdb-client transact tcp:127.0.0.1:6642 --timeout 180\u0027"},{"line_number":139,"context_line":"                   \u0027\\\u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \u0027"},{"line_number":140,"context_line":"                   \u0027\"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\\\u0027\u0027)"},{"line_number":141,"context_line":"        with mock.patch.object(processutils, \u0027execute\u0027) as mock_execute:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0580c05_23b24898","line":138,"range":{"start_line":138,"start_character":72,"end_line":138,"end_character":75},"updated":"2021-11-04 13:42:55.000000000","message":"It\u0027ll be good to override the default timeout somewhere on the lines around L100 to avoid failure if the default is changed.","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b260e1bae5faeb9311f9352e421d71e6bbd5651b","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_delete_mac_binding_entries(self):"},{"line_number":137,"context_line":"        self.config(group\u003d\u0027ovn\u0027, ovn_sb_private_key\u003dNone)"},{"line_number":138,"context_line":"        expected \u003d (\u0027ovsdb-client transact tcp:127.0.0.1:6642 --timeout 180\u0027"},{"line_number":139,"context_line":"                   \u0027\\\u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \u0027"},{"line_number":140,"context_line":"                   \u0027\"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\\\u0027\u0027)"},{"line_number":141,"context_line":"        with mock.patch.object(processutils, \u0027execute\u0027) as mock_execute:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bee7005_2fb4e0c6","line":138,"range":{"start_line":138,"start_character":72,"end_line":138,"end_character":76},"updated":"2021-11-04 13:43:38.000000000","message":"space missing at the end of this line","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e4725b1568d6e7dbc4bf001b99e664b40464e808","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_delete_mac_binding_entries(self):"},{"line_number":137,"context_line":"        self.config(group\u003d\u0027ovn\u0027, ovn_sb_private_key\u003dNone)"},{"line_number":138,"context_line":"        expected \u003d (\u0027ovsdb-client transact tcp:127.0.0.1:6642 --timeout 180\u0027"},{"line_number":139,"context_line":"                   \u0027\\\u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \u0027"},{"line_number":140,"context_line":"                   \u0027\"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\\\u0027\u0027)"},{"line_number":141,"context_line":"        with mock.patch.object(processutils, \u0027execute\u0027) as mock_execute:"}],"source_content_type":"text/x-python","patch_set":1,"id":"115a6ca2_b8e020f1","line":138,"range":{"start_line":138,"start_character":72,"end_line":138,"end_character":76},"in_reply_to":"9bee7005_2fb4e0c6","updated":"2021-11-04 13:48:05.000000000","message":"Ack","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e4725b1568d6e7dbc4bf001b99e664b40464e808","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_delete_mac_binding_entries(self):"},{"line_number":137,"context_line":"        self.config(group\u003d\u0027ovn\u0027, ovn_sb_private_key\u003dNone)"},{"line_number":138,"context_line":"        expected \u003d (\u0027ovsdb-client transact tcp:127.0.0.1:6642 --timeout 180\u0027"},{"line_number":139,"context_line":"                   \u0027\\\u0027[\"OVN_Southbound\", {\"op\": \"delete\", \"table\": \u0027"},{"line_number":140,"context_line":"                   \u0027\"MAC_Binding\", \"where\": [[\"ip\", \"\u003d\u003d\", \"1.1.1.1\"]]}]\\\u0027\u0027)"},{"line_number":141,"context_line":"        with mock.patch.object(processutils, \u0027execute\u0027) as mock_execute:"}],"source_content_type":"text/x-python","patch_set":1,"id":"895f2b3b_9de5cffd","line":138,"range":{"start_line":138,"start_character":72,"end_line":138,"end_character":75},"in_reply_to":"a0580c05_23b24898","updated":"2021-11-04 13:48:05.000000000","message":"totally agree","commit_id":"62c54ab1c0ff7c5bc8644f27be3e4f6edc81db9d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cd9d21debd36efdd0932b1f8ad9e96ad22736203","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027, [\u00278.8.8.8\u0027],"},{"line_number":104,"context_line":"                                       group\u003d\u0027ovn\u0027)"},{"line_number":105,"context_line":"        cfg.CONF.set_override(\u0027vlan_transparent\u0027, True)"},{"line_number":106,"context_line":"        cfg.CONF.set_override(\u0027ovsdb_connection_timeout\u0027, 180, group\u003d\u0027ovn\u0027)"},{"line_number":107,"context_line":"        mock.patch.object(impl_idl_ovn.Backend, \u0027schema_helper\u0027).start()"},{"line_number":108,"context_line":"        super().setUp()"},{"line_number":109,"context_line":"        neutron_agent.AgentCache(self.mech_driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3cb0cac3_d7a911cf","line":106,"range":{"start_line":106,"start_character":58,"end_line":106,"end_character":61},"updated":"2021-11-04 15:47:05.000000000","message":"supernit: I would not pick the default value to make sure it works","commit_id":"5b1c4b67851a2120fc7cb6177c86883a2a9ef9ed"}]}